aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMichal Hocko <mhocko@suse.com>2017-07-06 18:37:38 -0400
committerLinus Torvalds <torvalds@linux-foundation.org>2017-07-06 19:24:32 -0400
commitc8f9565716e37fe764a3007d90cecb35b3b4a77a (patch)
treecee5f4754c29d70e0388f89af15cc09dbe92988d
parentdc0bbf3b7fb9ed2246f62bba4379070589e2135c (diff)
mm, memory_hotplug: use node instead of zone in can_online_high_movable
The primary purpose of this helper is to query the node state so use the node id directly. This is a preparatory patch for later changes. This shouldn't introduce any functional change Link: http://lkml.kernel.org/r/20170515085827.16474-3-mhocko@kernel.org Signed-off-by: Michal Hocko <mhocko@suse.com> Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com> Acked-by: Vlastimil Babka <vbabka@suse.cz> Cc: Andi Kleen <ak@linux.intel.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: Balbir Singh <bsingharora@gmail.com> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Daniel Kiper <daniel.kiper@oracle.com> Cc: David Rientjes <rientjes@google.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Igor Mammedov <imammedo@redhat.com> Cc: Jerome Glisse <jglisse@redhat.com> Cc: Joonsoo Kim <js1304@gmail.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Mel Gorman <mgorman@suse.de> Cc: Reza Arbab <arbab@linux.vnet.ibm.com> Cc: Tobias Regnery <tobias.regnery@gmail.com> Cc: Toshi Kani <toshi.kani@hpe.com> Cc: Vitaly Kuznetsov <vkuznets@redhat.com> Cc: Xishi Qiu <qiuxishi@huawei.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r--mm/memory_hotplug.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index b93c88125766..6b6362819be2 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -941,15 +941,15 @@ static int online_pages_range(unsigned long start_pfn, unsigned long nr_pages,
941 * When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't have 941 * When CONFIG_MOVABLE_NODE, we permit onlining of a node which doesn't have
942 * normal memory. 942 * normal memory.
943 */ 943 */
944static bool can_online_high_movable(struct zone *zone) 944static bool can_online_high_movable(int nid)
945{ 945{
946 return true; 946 return true;
947} 947}
948#else /* CONFIG_MOVABLE_NODE */ 948#else /* CONFIG_MOVABLE_NODE */
949/* ensure every online node has NORMAL memory */ 949/* ensure every online node has NORMAL memory */
950static bool can_online_high_movable(struct zone *zone) 950static bool can_online_high_movable(int nid)
951{ 951{
952 return node_state(zone_to_nid(zone), N_NORMAL_MEMORY); 952 return node_state(nid, N_NORMAL_MEMORY);
953} 953}
954#endif /* CONFIG_MOVABLE_NODE */ 954#endif /* CONFIG_MOVABLE_NODE */
955 955
@@ -1083,7 +1083,7 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ
1083 1083
1084 if ((zone_idx(zone) > ZONE_NORMAL || 1084 if ((zone_idx(zone) > ZONE_NORMAL ||
1085 online_type == MMOP_ONLINE_MOVABLE) && 1085 online_type == MMOP_ONLINE_MOVABLE) &&
1086 !can_online_high_movable(zone)) 1086 !can_online_high_movable(pfn_to_nid(pfn)))
1087 return -EINVAL; 1087 return -EINVAL;
1088 1088
1089 if (online_type == MMOP_ONLINE_KERNEL) { 1089 if (online_type == MMOP_ONLINE_KERNEL) {