diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-22 11:39:44 -0500 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2013-11-22 11:39:44 -0500 |
commit | c85e07278e50bdfbb50fe038d9cca01cdf1074d1 (patch) | |
tree | 28dbd0761d6d11d14a25b99d1ccc705e4d2c361f | |
parent | fb0d1eb8925daaabc45ef67be740a41f49303d07 (diff) | |
parent | ea0341e071527d5cec350917b01ab901af09d758 (diff) |
Merge tag 'gfs2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes
Pull GFS2 fixes from Steven Whitehouse:
"A couple of small, but important bug fixes for GFS2. The first one
fixes a possible NULL pointer dereference, and the second one resolves
a reference counting issue in one of the lesser used paths through
atomic_open"
* tag 'gfs2-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/steve/gfs2-3.0-fixes:
GFS2: Fix ref count bug relating to atomic_open
GFS2: fix potential NULL pointer dereference
-rw-r--r-- | fs/gfs2/glock.c | 3 | ||||
-rw-r--r-- | fs/gfs2/inode.c | 5 |
2 files changed, 6 insertions, 2 deletions
diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c index e66a8009aff1..c8420f7e4db6 100644 --- a/fs/gfs2/glock.c +++ b/fs/gfs2/glock.c | |||
@@ -1899,7 +1899,8 @@ static int gfs2_glock_iter_next(struct gfs2_glock_iter *gi) | |||
1899 | gi->nhash = 0; | 1899 | gi->nhash = 0; |
1900 | } | 1900 | } |
1901 | /* Skip entries for other sb and dead entries */ | 1901 | /* Skip entries for other sb and dead entries */ |
1902 | } while (gi->sdp != gi->gl->gl_sbd || __lockref_is_dead(&gl->gl_lockref)); | 1902 | } while (gi->sdp != gi->gl->gl_sbd || |
1903 | __lockref_is_dead(&gi->gl->gl_lockref)); | ||
1903 | 1904 | ||
1904 | return 0; | 1905 | return 0; |
1905 | } | 1906 | } |
diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c index 1615df16cf4e..7119504159f1 100644 --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c | |||
@@ -1171,8 +1171,11 @@ static int gfs2_atomic_open(struct inode *dir, struct dentry *dentry, | |||
1171 | if (d != NULL) | 1171 | if (d != NULL) |
1172 | dentry = d; | 1172 | dentry = d; |
1173 | if (dentry->d_inode) { | 1173 | if (dentry->d_inode) { |
1174 | if (!(*opened & FILE_OPENED)) | 1174 | if (!(*opened & FILE_OPENED)) { |
1175 | if (d == NULL) | ||
1176 | dget(dentry); | ||
1175 | return finish_no_open(file, dentry); | 1177 | return finish_no_open(file, dentry); |
1178 | } | ||
1176 | dput(d); | 1179 | dput(d); |
1177 | return 0; | 1180 | return 0; |
1178 | } | 1181 | } |