diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2019-01-29 12:05:23 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-01-29 13:55:25 -0500 |
| commit | c829f5f52db9bae0379b98fca2645f6ca9b0fb1e (patch) | |
| tree | acbedc1085b4fc1952010c9b5febd01e2563e25d | |
| parent | 9f672984338d160aa262be7ad6d19fd182dc384d (diff) | |
cxgb4: cxgb4_tc_u32: use struct_size() in kvzalloc()
One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:
struct foo {
int stuff;
struct boo entry[];
};
instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);
Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:
instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL);
This code was detected with the help of Coccinelle.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c index c7d2b4dc7568..02fc63fa7f25 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c | |||
| @@ -444,8 +444,7 @@ struct cxgb4_tc_u32_table *cxgb4_init_tc_u32(struct adapter *adap) | |||
| 444 | if (!max_tids) | 444 | if (!max_tids) |
| 445 | return NULL; | 445 | return NULL; |
| 446 | 446 | ||
| 447 | t = kvzalloc(sizeof(*t) + | 447 | t = kvzalloc(struct_size(t, table, max_tids), GFP_KERNEL); |
| 448 | (max_tids * sizeof(struct cxgb4_link)), GFP_KERNEL); | ||
| 449 | if (!t) | 448 | if (!t) |
| 450 | return NULL; | 449 | return NULL; |
| 451 | 450 | ||
