diff options
| author | Eric Biggers <ebiggers@google.com> | 2019-03-15 16:54:32 -0400 |
|---|---|---|
| committer | Richard Weinberger <richard@nod.at> | 2019-05-07 15:36:39 -0400 |
| commit | c64cda8a99135c584a1c61074e225aacdf31060f (patch) | |
| tree | a3f5f4f091dcaf0cb79f59f86e43ef3a8a7fa61e | |
| parent | 37624b58542fb9f2d9a70e6ea006ef8a5f66c30b (diff) | |
ubifs: remove unnecessary calls to set up directory key
In ubifs_unlink() and ubifs_rmdir(), remove the call to
fscrypt_get_encryption_info() that precedes fscrypt_setup_filename().
This call was unnecessary, because fscrypt_setup_filename() already
tries to set up the directory's encryption key.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
| -rw-r--r-- | fs/ubifs/dir.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c index 5767b373a8ff..c3311ea68fe5 100644 --- a/fs/ubifs/dir.c +++ b/fs/ubifs/dir.c | |||
| @@ -792,12 +792,6 @@ static int ubifs_unlink(struct inode *dir, struct dentry *dentry) | |||
| 792 | dentry, inode->i_ino, | 792 | dentry, inode->i_ino, |
| 793 | inode->i_nlink, dir->i_ino); | 793 | inode->i_nlink, dir->i_ino); |
| 794 | 794 | ||
| 795 | if (ubifs_crypt_is_encrypted(dir)) { | ||
| 796 | err = fscrypt_get_encryption_info(dir); | ||
| 797 | if (err && err != -ENOKEY) | ||
| 798 | return err; | ||
| 799 | } | ||
| 800 | |||
| 801 | err = fscrypt_setup_filename(dir, &dentry->d_name, 1, &nm); | 795 | err = fscrypt_setup_filename(dir, &dentry->d_name, 1, &nm); |
| 802 | if (err) | 796 | if (err) |
| 803 | return err; | 797 | return err; |
| @@ -902,12 +896,6 @@ static int ubifs_rmdir(struct inode *dir, struct dentry *dentry) | |||
| 902 | if (err) | 896 | if (err) |
| 903 | return err; | 897 | return err; |
| 904 | 898 | ||
| 905 | if (ubifs_crypt_is_encrypted(dir)) { | ||
| 906 | err = fscrypt_get_encryption_info(dir); | ||
| 907 | if (err && err != -ENOKEY) | ||
| 908 | return err; | ||
| 909 | } | ||
| 910 | |||
| 911 | err = fscrypt_setup_filename(dir, &dentry->d_name, 1, &nm); | 899 | err = fscrypt_setup_filename(dir, &dentry->d_name, 1, &nm); |
| 912 | if (err) | 900 | if (err) |
| 913 | return err; | 901 | return err; |
