diff options
author | Lars-Peter Clausen <lars@metafoo.de> | 2015-03-30 15:04:47 -0400 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2015-04-01 16:27:41 -0400 |
commit | c59e6abba9dd7bc273c3dd389ae9927d1da88f35 (patch) | |
tree | 90d05d998f5ec8c5037dea0534de65f3bcde28e5 | |
parent | 643518403c3fdecd40d9edfd50f4bafcebeda79b (diff) |
ASoC: wm8971: Cleanup manual bias level transitions
Set the CODEC driver's suspend_bias_off flag rather than manually going to
SND_SOC_BIAS_OFF in suspend and SND_SOC_BIAS_STANDBY in resume. This makes
the code a bit shorter and cleaner.
Since the ASoC core now takes care of setting the bias level to
SND_SOC_BIAS_OFF when removing the CODEC there is no need to do it manually
anymore either.
The manual transition to SND_SOC_BIAS_STANDBY at the end of CODEC probe()
can also be removed as the core will automatically do this after the CODEC
has been probed.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | sound/soc/codecs/wm8971.c | 27 |
1 files changed, 1 insertions, 26 deletions
diff --git a/sound/soc/codecs/wm8971.c b/sound/soc/codecs/wm8971.c index 4ab034d48474..f9cbabdc6238 100644 --- a/sound/soc/codecs/wm8971.c +++ b/sound/soc/codecs/wm8971.c | |||
@@ -629,18 +629,6 @@ static struct snd_soc_dai_driver wm8971_dai = { | |||
629 | .ops = &wm8971_dai_ops, | 629 | .ops = &wm8971_dai_ops, |
630 | }; | 630 | }; |
631 | 631 | ||
632 | static int wm8971_suspend(struct snd_soc_codec *codec) | ||
633 | { | ||
634 | wm8971_set_bias_level(codec, SND_SOC_BIAS_OFF); | ||
635 | return 0; | ||
636 | } | ||
637 | |||
638 | static int wm8971_resume(struct snd_soc_codec *codec) | ||
639 | { | ||
640 | wm8971_set_bias_level(codec, SND_SOC_BIAS_STANDBY); | ||
641 | return 0; | ||
642 | } | ||
643 | |||
644 | static int wm8971_probe(struct snd_soc_codec *codec) | 632 | static int wm8971_probe(struct snd_soc_codec *codec) |
645 | { | 633 | { |
646 | struct wm8971_priv *wm8971 = snd_soc_codec_get_drvdata(codec); | 634 | struct wm8971_priv *wm8971 = snd_soc_codec_get_drvdata(codec); |
@@ -649,8 +637,6 @@ static int wm8971_probe(struct snd_soc_codec *codec) | |||
649 | 637 | ||
650 | wm8971_reset(codec); | 638 | wm8971_reset(codec); |
651 | 639 | ||
652 | wm8971_set_bias_level(codec, SND_SOC_BIAS_STANDBY); | ||
653 | |||
654 | /* set the update bits */ | 640 | /* set the update bits */ |
655 | snd_soc_update_bits(codec, WM8971_LDAC, 0x0100, 0x0100); | 641 | snd_soc_update_bits(codec, WM8971_LDAC, 0x0100, 0x0100); |
656 | snd_soc_update_bits(codec, WM8971_RDAC, 0x0100, 0x0100); | 642 | snd_soc_update_bits(codec, WM8971_RDAC, 0x0100, 0x0100); |
@@ -664,21 +650,10 @@ static int wm8971_probe(struct snd_soc_codec *codec) | |||
664 | return 0; | 650 | return 0; |
665 | } | 651 | } |
666 | 652 | ||
667 | |||
668 | /* power down chip */ | ||
669 | static int wm8971_remove(struct snd_soc_codec *codec) | ||
670 | { | ||
671 | wm8971_set_bias_level(codec, SND_SOC_BIAS_OFF); | ||
672 | |||
673 | return 0; | ||
674 | } | ||
675 | |||
676 | static struct snd_soc_codec_driver soc_codec_dev_wm8971 = { | 653 | static struct snd_soc_codec_driver soc_codec_dev_wm8971 = { |
677 | .probe = wm8971_probe, | 654 | .probe = wm8971_probe, |
678 | .remove = wm8971_remove, | ||
679 | .suspend = wm8971_suspend, | ||
680 | .resume = wm8971_resume, | ||
681 | .set_bias_level = wm8971_set_bias_level, | 655 | .set_bias_level = wm8971_set_bias_level, |
656 | .suspend_bias_off = true, | ||
682 | 657 | ||
683 | .controls = wm8971_snd_controls, | 658 | .controls = wm8971_snd_controls, |
684 | .num_controls = ARRAY_SIZE(wm8971_snd_controls), | 659 | .num_controls = ARRAY_SIZE(wm8971_snd_controls), |