aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorColin Ian King <colin.king@canonical.com>2019-09-05 12:20:49 -0400
committerKalle Valo <kvalo@codeaurora.org>2019-09-13 09:44:49 -0400
commitc57391f4157256a86c85424a16285d27ba92035c (patch)
tree784061feac251408afb9dcc42f5f5bf77eb7758d
parent569ce0a486fdf79606adc763086455b4534999a0 (diff)
bcma: make arrays pwr_info_offset and sprom_sizes static const, shrinks object size
Arrays pwr_info_offset and sprom_sizes can be make static const rather than populating them on the stack. Shrinks object size by 236 bytes. Before: text data bss dec hex filename 11300 1320 64 12684 318c drivers/bcma/sprom.o After: text data bss dec hex filename 10904 1480 64 12448 30a0 drivers/bcma/sprom.o (gcc version 9.2.1, amd64) Signed-off-by: Colin Ian King <colin.king@canonical.com> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
-rw-r--r--drivers/bcma/sprom.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/drivers/bcma/sprom.c b/drivers/bcma/sprom.c
index 206edd3ba668..bd2c923a6586 100644
--- a/drivers/bcma/sprom.c
+++ b/drivers/bcma/sprom.c
@@ -222,7 +222,7 @@ static void bcma_sprom_extract_r8(struct bcma_bus *bus, const u16 *sprom)
222{ 222{
223 u16 v, o; 223 u16 v, o;
224 int i; 224 int i;
225 u16 pwr_info_offset[] = { 225 static const u16 pwr_info_offset[] = {
226 SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1, 226 SSB_SROM8_PWR_INFO_CORE0, SSB_SROM8_PWR_INFO_CORE1,
227 SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3 227 SSB_SROM8_PWR_INFO_CORE2, SSB_SROM8_PWR_INFO_CORE3
228 }; 228 };
@@ -578,9 +578,11 @@ int bcma_sprom_get(struct bcma_bus *bus)
578{ 578{
579 u16 offset = BCMA_CC_SPROM; 579 u16 offset = BCMA_CC_SPROM;
580 u16 *sprom; 580 u16 *sprom;
581 size_t sprom_sizes[] = { SSB_SPROMSIZE_WORDS_R4, 581 static const size_t sprom_sizes[] = {
582 SSB_SPROMSIZE_WORDS_R10, 582 SSB_SPROMSIZE_WORDS_R4,
583 SSB_SPROMSIZE_WORDS_R11, }; 583 SSB_SPROMSIZE_WORDS_R10,
584 SSB_SPROMSIZE_WORDS_R11,
585 };
584 int i, err = 0; 586 int i, err = 0;
585 587
586 if (!bus->drv_cc.core) 588 if (!bus->drv_cc.core)