diff options
author | Arvind Yadav <arvind.yadav.cs@gmail.com> | 2017-11-25 05:19:49 -0500 |
---|---|---|
committer | Tejun Heo <tj@kernel.org> | 2017-11-27 14:46:26 -0500 |
commit | c1da86c19ad6bfb77ceef3414c82269e8466f410 (patch) | |
tree | 83d45b613ff7e20523fd63a14017ec3786054770 | |
parent | 16a27dfd218566f9604d5542c6285395cfc6831c (diff) |
pata_pdc2027x: Remove unnecessary error check
Here, The function pdc_hardware_init always return zero. So it is not
necessary to check its return value.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
-rw-r--r-- | drivers/ata/pata_pdc2027x.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/drivers/ata/pata_pdc2027x.c b/drivers/ata/pata_pdc2027x.c index ffd8d33c6e0f..4a9d532bdbb8 100644 --- a/drivers/ata/pata_pdc2027x.c +++ b/drivers/ata/pata_pdc2027x.c | |||
@@ -649,7 +649,7 @@ static long pdc_detect_pll_input_clock(struct ata_host *host) | |||
649 | * @host: target ATA host | 649 | * @host: target ATA host |
650 | * @board_idx: board identifier | 650 | * @board_idx: board identifier |
651 | */ | 651 | */ |
652 | static int pdc_hardware_init(struct ata_host *host, unsigned int board_idx) | 652 | static void pdc_hardware_init(struct ata_host *host, unsigned int board_idx) |
653 | { | 653 | { |
654 | long pll_clock; | 654 | long pll_clock; |
655 | 655 | ||
@@ -665,8 +665,6 @@ static int pdc_hardware_init(struct ata_host *host, unsigned int board_idx) | |||
665 | 665 | ||
666 | /* Adjust PLL control register */ | 666 | /* Adjust PLL control register */ |
667 | pdc_adjust_pll(host, pll_clock, board_idx); | 667 | pdc_adjust_pll(host, pll_clock, board_idx); |
668 | |||
669 | return 0; | ||
670 | } | 668 | } |
671 | 669 | ||
672 | /** | 670 | /** |
@@ -753,8 +751,7 @@ static int pdc2027x_init_one(struct pci_dev *pdev, | |||
753 | //pci_enable_intx(pdev); | 751 | //pci_enable_intx(pdev); |
754 | 752 | ||
755 | /* initialize adapter */ | 753 | /* initialize adapter */ |
756 | if (pdc_hardware_init(host, board_idx) != 0) | 754 | pdc_hardware_init(host, board_idx); |
757 | return -EIO; | ||
758 | 755 | ||
759 | pci_set_master(pdev); | 756 | pci_set_master(pdev); |
760 | return ata_host_activate(host, pdev->irq, ata_bmdma_interrupt, | 757 | return ata_host_activate(host, pdev->irq, ata_bmdma_interrupt, |
@@ -778,8 +775,7 @@ static int pdc2027x_reinit_one(struct pci_dev *pdev) | |||
778 | else | 775 | else |
779 | board_idx = PDC_UDMA_133; | 776 | board_idx = PDC_UDMA_133; |
780 | 777 | ||
781 | if (pdc_hardware_init(host, board_idx)) | 778 | pdc_hardware_init(host, board_idx); |
782 | return -EIO; | ||
783 | 779 | ||
784 | ata_host_resume(host); | 780 | ata_host_resume(host); |
785 | return 0; | 781 | return 0; |