diff options
author | Yannick Brosseau <scientist@fb.com> | 2015-06-17 19:41:10 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2015-06-19 17:14:05 -0400 |
commit | c05676c06232e6459a6106ddf0d4e154ce6cd859 (patch) | |
tree | 999a0847ccfcced28533205a0b8ed7d9dbc760bb | |
parent | 3e323dc0a80c3921f30d03ca300426f70dc5a327 (diff) |
perf report: Fix sort__sym_cmp to also compare end of symbol
When using a map file from a JIT, due to memory reuse, we can obtain
multiple symbols with the same start address but a different length.
The symbols__find does check for the end so not doing it in
sort__sym_cmp was causing the hist_entry in the annotate part of a
report to match to the wrong entry, causing a fatal error.
Signed-off-by: Yannick Brosseau <scientist@fb.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: kernel-team@fb.com
Link: http://lkml.kernel.org/r/1434584470-17771-1-git-send-email-scientist@fb.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/util/sort.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 09d4696fd9a1..4c65a143a34c 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c | |||
@@ -182,18 +182,16 @@ static int64_t _sort__addr_cmp(u64 left_ip, u64 right_ip) | |||
182 | 182 | ||
183 | static int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r) | 183 | static int64_t _sort__sym_cmp(struct symbol *sym_l, struct symbol *sym_r) |
184 | { | 184 | { |
185 | u64 ip_l, ip_r; | ||
186 | |||
187 | if (!sym_l || !sym_r) | 185 | if (!sym_l || !sym_r) |
188 | return cmp_null(sym_l, sym_r); | 186 | return cmp_null(sym_l, sym_r); |
189 | 187 | ||
190 | if (sym_l == sym_r) | 188 | if (sym_l == sym_r) |
191 | return 0; | 189 | return 0; |
192 | 190 | ||
193 | ip_l = sym_l->start; | 191 | if (sym_l->start != sym_r->start) |
194 | ip_r = sym_r->start; | 192 | return (int64_t)(sym_r->start - sym_l->start); |
195 | 193 | ||
196 | return (int64_t)(ip_r - ip_l); | 194 | return (int64_t)(sym_r->end - sym_l->end); |
197 | } | 195 | } |
198 | 196 | ||
199 | static int64_t | 197 | static int64_t |