diff options
author | Daniel Borkmann <daniel@iogearbox.net> | 2015-03-13 21:27:17 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2015-03-15 21:57:25 -0400 |
commit | c04167ce2ca0ecaeaafef006cb0d65cf01b68e42 (patch) | |
tree | ef0c4dc4642696d84bd56c4f409dd32507981bb0 | |
parent | 03e69b508b6f7c51743055c9f61d1dfeadf4b635 (diff) |
ebpf: add helper for obtaining current processor id
This patch adds the possibility to obtain raw_smp_processor_id() in
eBPF. Currently, this is only possible in classic BPF where commit
da2033c28226 ("filter: add SKF_AD_RXHASH and SKF_AD_CPU") has added
facilities for this.
Perhaps most importantly, this would also allow us to track per CPU
statistics with eBPF maps, or to implement a poor-man's per CPU data
structure through eBPF maps.
Example function proto-type looks like:
u32 (*smp_processor_id)(void) = (void *)BPF_FUNC_get_smp_processor_id;
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | include/linux/bpf.h | 1 | ||||
-rw-r--r-- | include/uapi/linux/bpf.h | 1 | ||||
-rw-r--r-- | kernel/bpf/core.c | 1 | ||||
-rw-r--r-- | kernel/bpf/helpers.c | 12 | ||||
-rw-r--r-- | net/core/filter.c | 2 |
5 files changed, 17 insertions, 0 deletions
diff --git a/include/linux/bpf.h b/include/linux/bpf.h index 50bf95e29a96..30bfd331882a 100644 --- a/include/linux/bpf.h +++ b/include/linux/bpf.h | |||
@@ -155,5 +155,6 @@ extern const struct bpf_func_proto bpf_map_update_elem_proto; | |||
155 | extern const struct bpf_func_proto bpf_map_delete_elem_proto; | 155 | extern const struct bpf_func_proto bpf_map_delete_elem_proto; |
156 | 156 | ||
157 | extern const struct bpf_func_proto bpf_get_prandom_u32_proto; | 157 | extern const struct bpf_func_proto bpf_get_prandom_u32_proto; |
158 | extern const struct bpf_func_proto bpf_get_smp_processor_id_proto; | ||
158 | 159 | ||
159 | #endif /* _LINUX_BPF_H */ | 160 | #endif /* _LINUX_BPF_H */ |
diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 1c2ca2b477c8..de1f63668daf 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h | |||
@@ -166,6 +166,7 @@ enum bpf_func_id { | |||
166 | BPF_FUNC_map_update_elem, /* int map_update_elem(&map, &key, &value, flags) */ | 166 | BPF_FUNC_map_update_elem, /* int map_update_elem(&map, &key, &value, flags) */ |
167 | BPF_FUNC_map_delete_elem, /* int map_delete_elem(&map, &key) */ | 167 | BPF_FUNC_map_delete_elem, /* int map_delete_elem(&map, &key) */ |
168 | BPF_FUNC_get_prandom_u32, /* u32 prandom_u32(void) */ | 168 | BPF_FUNC_get_prandom_u32, /* u32 prandom_u32(void) */ |
169 | BPF_FUNC_get_smp_processor_id, /* u32 raw_smp_processor_id(void) */ | ||
169 | __BPF_FUNC_MAX_ID, | 170 | __BPF_FUNC_MAX_ID, |
170 | }; | 171 | }; |
171 | 172 | ||
diff --git a/kernel/bpf/core.c b/kernel/bpf/core.c index c1dbbb5d289b..4139a0f8b558 100644 --- a/kernel/bpf/core.c +++ b/kernel/bpf/core.c | |||
@@ -662,6 +662,7 @@ const struct bpf_func_proto bpf_map_update_elem_proto __weak; | |||
662 | const struct bpf_func_proto bpf_map_delete_elem_proto __weak; | 662 | const struct bpf_func_proto bpf_map_delete_elem_proto __weak; |
663 | 663 | ||
664 | const struct bpf_func_proto bpf_get_prandom_u32_proto __weak; | 664 | const struct bpf_func_proto bpf_get_prandom_u32_proto __weak; |
665 | const struct bpf_func_proto bpf_get_smp_processor_id_proto __weak; | ||
665 | 666 | ||
666 | /* To execute LD_ABS/LD_IND instructions __bpf_prog_run() may call | 667 | /* To execute LD_ABS/LD_IND instructions __bpf_prog_run() may call |
667 | * skb_copy_bits(), so provide a weak definition of it for NET-less config. | 668 | * skb_copy_bits(), so provide a weak definition of it for NET-less config. |
diff --git a/kernel/bpf/helpers.c b/kernel/bpf/helpers.c index 95eb59a045ea..bd7f5988ed9c 100644 --- a/kernel/bpf/helpers.c +++ b/kernel/bpf/helpers.c | |||
@@ -12,6 +12,7 @@ | |||
12 | #include <linux/bpf.h> | 12 | #include <linux/bpf.h> |
13 | #include <linux/rcupdate.h> | 13 | #include <linux/rcupdate.h> |
14 | #include <linux/random.h> | 14 | #include <linux/random.h> |
15 | #include <linux/smp.h> | ||
15 | 16 | ||
16 | /* If kernel subsystem is allowing eBPF programs to call this function, | 17 | /* If kernel subsystem is allowing eBPF programs to call this function, |
17 | * inside its own verifier_ops->get_func_proto() callback it should return | 18 | * inside its own verifier_ops->get_func_proto() callback it should return |
@@ -99,3 +100,14 @@ const struct bpf_func_proto bpf_get_prandom_u32_proto = { | |||
99 | .gpl_only = false, | 100 | .gpl_only = false, |
100 | .ret_type = RET_INTEGER, | 101 | .ret_type = RET_INTEGER, |
101 | }; | 102 | }; |
103 | |||
104 | static u64 bpf_get_smp_processor_id(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5) | ||
105 | { | ||
106 | return raw_smp_processor_id(); | ||
107 | } | ||
108 | |||
109 | const struct bpf_func_proto bpf_get_smp_processor_id_proto = { | ||
110 | .func = bpf_get_smp_processor_id, | ||
111 | .gpl_only = false, | ||
112 | .ret_type = RET_INTEGER, | ||
113 | }; | ||
diff --git a/net/core/filter.c b/net/core/filter.c index 4344db39af2e..33310eee6134 100644 --- a/net/core/filter.c +++ b/net/core/filter.c | |||
@@ -1141,6 +1141,8 @@ sk_filter_func_proto(enum bpf_func_id func_id) | |||
1141 | return &bpf_map_delete_elem_proto; | 1141 | return &bpf_map_delete_elem_proto; |
1142 | case BPF_FUNC_get_prandom_u32: | 1142 | case BPF_FUNC_get_prandom_u32: |
1143 | return &bpf_get_prandom_u32_proto; | 1143 | return &bpf_get_prandom_u32_proto; |
1144 | case BPF_FUNC_get_smp_processor_id: | ||
1145 | return &bpf_get_smp_processor_id_proto; | ||
1144 | default: | 1146 | default: |
1145 | return NULL; | 1147 | return NULL; |
1146 | } | 1148 | } |