aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRafał Miłecki <zajec5@gmail.com>2016-07-08 08:53:38 -0400
committerJacek Anaszewski <j.anaszewski@samsung.com>2016-07-11 04:15:03 -0400
commitbff23714bc36a1322d0f14519022df0d1a4b21f3 (patch)
treedf64ffc4e17874fd4e4da43a5ff62649053b9149
parenta3eac76cdf7225aa1f87aa4514664f0372b9a1c1 (diff)
leds: leds-gpio: Set of_node for created LED devices
When working with Device Tree we iterate over children of "gpio-leds" compatible node and create LED device for each of them. We take care of all common DT properties (label, default trigger, state, etc.), however some triggers may want to support more of them. It could be useful for timer trigger to support setting delay on/off values with Device Tree property. Or for transient trigger to support e.g. duration property. We obviously should handle such properties in triggers, not in generic code. To let trigger drivers read properties from DT node we need to set of_node to point the relevant node. This change allows using all kind of of helpers in e.g. "activate" callbacks. Signed-off-by: Rafał Miłecki <zajec5@gmail.com> Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
-rw-r--r--drivers/leds/leds-gpio.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
index 8229f063b483..9b991d46ed84 100644
--- a/drivers/leds/leds-gpio.c
+++ b/drivers/leds/leds-gpio.c
@@ -165,6 +165,7 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
165 return ERR_PTR(-ENOMEM); 165 return ERR_PTR(-ENOMEM);
166 166
167 device_for_each_child_node(dev, child) { 167 device_for_each_child_node(dev, child) {
168 struct gpio_led_data *led_dat = &priv->leds[priv->num_leds];
168 struct gpio_led led = {}; 169 struct gpio_led led = {};
169 const char *state = NULL; 170 const char *state = NULL;
170 171
@@ -205,12 +206,12 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
205 if (fwnode_property_present(child, "panic-indicator")) 206 if (fwnode_property_present(child, "panic-indicator"))
206 led.panic_indicator = 1; 207 led.panic_indicator = 1;
207 208
208 ret = create_gpio_led(&led, &priv->leds[priv->num_leds], 209 ret = create_gpio_led(&led, led_dat, dev, NULL);
209 dev, NULL);
210 if (ret < 0) { 210 if (ret < 0) {
211 fwnode_handle_put(child); 211 fwnode_handle_put(child);
212 goto err; 212 goto err;
213 } 213 }
214 led_dat->cdev.dev->of_node = np;
214 priv->num_leds++; 215 priv->num_leds++;
215 } 216 }
216 217