diff options
author | Darrick J. Wong <darrick.wong@oracle.com> | 2018-10-29 19:47:48 -0400 |
---|---|---|
committer | Dave Chinner <david@fromorbit.com> | 2018-10-29 19:47:48 -0400 |
commit | bf4a1fcf0bc18d52cf0fce6571d6f327ab5eaf22 (patch) | |
tree | a3d847deb53d14dcb33f44f361b5fcea7667cf82 | |
parent | 3fc9f5e409319e994d113cf1327ba6ab147423c2 (diff) |
xfs: remove [cm]time update from reflink calls
Now that the vfs remap helper dirties the inode [cm]time for us, xfs no
longer needs to do that on its own.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
-rw-r--r-- | fs/xfs/xfs_reflink.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index 84f372f7ea04..e72218477bf2 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c | |||
@@ -927,8 +927,7 @@ xfs_reflink_update_dest( | |||
927 | struct xfs_trans *tp; | 927 | struct xfs_trans *tp; |
928 | int error; | 928 | int error; |
929 | 929 | ||
930 | if ((remap_flags & REMAP_FILE_DEDUP) && | 930 | if (newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0) |
931 | newlen <= i_size_read(VFS_I(dest)) && cowextsize == 0) | ||
932 | return 0; | 931 | return 0; |
933 | 932 | ||
934 | error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ichange, 0, 0, 0, &tp); | 933 | error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ichange, 0, 0, 0, &tp); |
@@ -949,10 +948,6 @@ xfs_reflink_update_dest( | |||
949 | dest->i_d.di_flags2 |= XFS_DIFLAG2_COWEXTSIZE; | 948 | dest->i_d.di_flags2 |= XFS_DIFLAG2_COWEXTSIZE; |
950 | } | 949 | } |
951 | 950 | ||
952 | if (!(remap_flags & REMAP_FILE_DEDUP)) { | ||
953 | xfs_trans_ichgtime(tp, dest, | ||
954 | XFS_ICHGTIME_MOD | XFS_ICHGTIME_CHG); | ||
955 | } | ||
956 | xfs_trans_log_inode(tp, dest, XFS_ILOG_CORE); | 951 | xfs_trans_log_inode(tp, dest, XFS_ILOG_CORE); |
957 | 952 | ||
958 | error = xfs_trans_commit(tp); | 953 | error = xfs_trans_commit(tp); |