diff options
author | Ming Lei <ming.lei@redhat.com> | 2017-07-14 04:14:44 -0400 |
---|---|---|
committer | Shaohua Li <shli@fb.com> | 2017-07-21 15:47:20 -0400 |
commit | be453e7761d0e72d8a1b2fcfde6d1a7e53881190 (patch) | |
tree | 4d279fad43fde03e4c7eafb3225e440088ac16ef | |
parent | fb0eb5df09307603b21845af1d143cc910154593 (diff) |
md: raid1-10: move raid1/raid10 common code into raid1-10.c
No function change, just move 'struct resync_pages' and related
helpers into raid1-10.c
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Shaohua Li <shli@fb.com>
-rw-r--r-- | drivers/md/md.h | 53 | ||||
-rw-r--r-- | drivers/md/raid1-10.c | 62 | ||||
-rw-r--r-- | drivers/md/raid1.c | 9 | ||||
-rw-r--r-- | drivers/md/raid10.c | 9 |
4 files changed, 62 insertions, 71 deletions
diff --git a/drivers/md/md.h b/drivers/md/md.h index 991769cc3615..09db03455801 100644 --- a/drivers/md/md.h +++ b/drivers/md/md.h | |||
@@ -731,57 +731,4 @@ static inline void mddev_check_write_zeroes(struct mddev *mddev, struct bio *bio | |||
731 | !bdev_get_queue(bio->bi_bdev)->limits.max_write_zeroes_sectors) | 731 | !bdev_get_queue(bio->bi_bdev)->limits.max_write_zeroes_sectors) |
732 | mddev->queue->limits.max_write_zeroes_sectors = 0; | 732 | mddev->queue->limits.max_write_zeroes_sectors = 0; |
733 | } | 733 | } |
734 | |||
735 | /* Maximum size of each resync request */ | ||
736 | #define RESYNC_BLOCK_SIZE (64*1024) | ||
737 | #define RESYNC_PAGES ((RESYNC_BLOCK_SIZE + PAGE_SIZE-1) / PAGE_SIZE) | ||
738 | |||
739 | /* for managing resync I/O pages */ | ||
740 | struct resync_pages { | ||
741 | void *raid_bio; | ||
742 | struct page *pages[RESYNC_PAGES]; | ||
743 | }; | ||
744 | |||
745 | static inline int resync_alloc_pages(struct resync_pages *rp, | ||
746 | gfp_t gfp_flags) | ||
747 | { | ||
748 | int i; | ||
749 | |||
750 | for (i = 0; i < RESYNC_PAGES; i++) { | ||
751 | rp->pages[i] = alloc_page(gfp_flags); | ||
752 | if (!rp->pages[i]) | ||
753 | goto out_free; | ||
754 | } | ||
755 | |||
756 | return 0; | ||
757 | |||
758 | out_free: | ||
759 | while (--i >= 0) | ||
760 | put_page(rp->pages[i]); | ||
761 | return -ENOMEM; | ||
762 | } | ||
763 | |||
764 | static inline void resync_free_pages(struct resync_pages *rp) | ||
765 | { | ||
766 | int i; | ||
767 | |||
768 | for (i = 0; i < RESYNC_PAGES; i++) | ||
769 | put_page(rp->pages[i]); | ||
770 | } | ||
771 | |||
772 | static inline void resync_get_all_pages(struct resync_pages *rp) | ||
773 | { | ||
774 | int i; | ||
775 | |||
776 | for (i = 0; i < RESYNC_PAGES; i++) | ||
777 | get_page(rp->pages[i]); | ||
778 | } | ||
779 | |||
780 | static inline struct page *resync_fetch_page(struct resync_pages *rp, | ||
781 | unsigned idx) | ||
782 | { | ||
783 | if (WARN_ON_ONCE(idx >= RESYNC_PAGES)) | ||
784 | return NULL; | ||
785 | return rp->pages[idx]; | ||
786 | } | ||
787 | #endif /* _MD_MD_H */ | 734 | #endif /* _MD_MD_H */ |
diff --git a/drivers/md/raid1-10.c b/drivers/md/raid1-10.c index 3adb5b9dc4b4..9f2670b45f31 100644 --- a/drivers/md/raid1-10.c +++ b/drivers/md/raid1-10.c | |||
@@ -1,3 +1,65 @@ | |||
1 | /* Maximum size of each resync request */ | ||
2 | #define RESYNC_BLOCK_SIZE (64*1024) | ||
3 | #define RESYNC_PAGES ((RESYNC_BLOCK_SIZE + PAGE_SIZE-1) / PAGE_SIZE) | ||
4 | |||
5 | /* for managing resync I/O pages */ | ||
6 | struct resync_pages { | ||
7 | void *raid_bio; | ||
8 | struct page *pages[RESYNC_PAGES]; | ||
9 | }; | ||
10 | |||
11 | static inline int resync_alloc_pages(struct resync_pages *rp, | ||
12 | gfp_t gfp_flags) | ||
13 | { | ||
14 | int i; | ||
15 | |||
16 | for (i = 0; i < RESYNC_PAGES; i++) { | ||
17 | rp->pages[i] = alloc_page(gfp_flags); | ||
18 | if (!rp->pages[i]) | ||
19 | goto out_free; | ||
20 | } | ||
21 | |||
22 | return 0; | ||
23 | |||
24 | out_free: | ||
25 | while (--i >= 0) | ||
26 | put_page(rp->pages[i]); | ||
27 | return -ENOMEM; | ||
28 | } | ||
29 | |||
30 | static inline void resync_free_pages(struct resync_pages *rp) | ||
31 | { | ||
32 | int i; | ||
33 | |||
34 | for (i = 0; i < RESYNC_PAGES; i++) | ||
35 | put_page(rp->pages[i]); | ||
36 | } | ||
37 | |||
38 | static inline void resync_get_all_pages(struct resync_pages *rp) | ||
39 | { | ||
40 | int i; | ||
41 | |||
42 | for (i = 0; i < RESYNC_PAGES; i++) | ||
43 | get_page(rp->pages[i]); | ||
44 | } | ||
45 | |||
46 | static inline struct page *resync_fetch_page(struct resync_pages *rp, | ||
47 | unsigned idx) | ||
48 | { | ||
49 | if (WARN_ON_ONCE(idx >= RESYNC_PAGES)) | ||
50 | return NULL; | ||
51 | return rp->pages[idx]; | ||
52 | } | ||
53 | |||
54 | /* | ||
55 | * 'strct resync_pages' stores actual pages used for doing the resync | ||
56 | * IO, and it is per-bio, so make .bi_private points to it. | ||
57 | */ | ||
58 | static inline struct resync_pages *get_resync_pages(struct bio *bio) | ||
59 | { | ||
60 | return bio->bi_private; | ||
61 | } | ||
62 | |||
1 | /* generally called after bio_reset() for reseting bvec */ | 63 | /* generally called after bio_reset() for reseting bvec */ |
2 | static void md_bio_reset_resync_pages(struct bio *bio, struct resync_pages *rp, | 64 | static void md_bio_reset_resync_pages(struct bio *bio, struct resync_pages *rp, |
3 | int size) | 65 | int size) |
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c index fe86ab18961b..8387eb1540cd 100644 --- a/drivers/md/raid1.c +++ b/drivers/md/raid1.c | |||
@@ -84,15 +84,6 @@ static void lower_barrier(struct r1conf *conf, sector_t sector_nr); | |||
84 | #include "raid1-10.c" | 84 | #include "raid1-10.c" |
85 | 85 | ||
86 | /* | 86 | /* |
87 | * 'strct resync_pages' stores actual pages used for doing the resync | ||
88 | * IO, and it is per-bio, so make .bi_private points to it. | ||
89 | */ | ||
90 | static inline struct resync_pages *get_resync_pages(struct bio *bio) | ||
91 | { | ||
92 | return bio->bi_private; | ||
93 | } | ||
94 | |||
95 | /* | ||
96 | * for resync bio, r1bio pointer can be retrieved from the per-bio | 87 | * for resync bio, r1bio pointer can be retrieved from the per-bio |
97 | * 'struct resync_pages'. | 88 | * 'struct resync_pages'. |
98 | */ | 89 | */ |
diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c index 9952721e1cde..e2617d0f37dc 100644 --- a/drivers/md/raid10.c +++ b/drivers/md/raid10.c | |||
@@ -113,15 +113,6 @@ static void end_reshape(struct r10conf *conf); | |||
113 | #include "raid1-10.c" | 113 | #include "raid1-10.c" |
114 | 114 | ||
115 | /* | 115 | /* |
116 | * 'strct resync_pages' stores actual pages used for doing the resync | ||
117 | * IO, and it is per-bio, so make .bi_private points to it. | ||
118 | */ | ||
119 | static inline struct resync_pages *get_resync_pages(struct bio *bio) | ||
120 | { | ||
121 | return bio->bi_private; | ||
122 | } | ||
123 | |||
124 | /* | ||
125 | * for resync bio, r10bio pointer can be retrieved from the per-bio | 116 | * for resync bio, r10bio pointer can be retrieved from the per-bio |
126 | * 'struct resync_pages'. | 117 | * 'struct resync_pages'. |
127 | */ | 118 | */ |