aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristoph Hellwig <hch@lst.de>2015-11-07 03:39:28 -0500
committerJens Axboe <axboe@fb.com>2015-12-22 11:38:34 -0500
commitbbc758ec04c2f30805ce0fcdfbaa4c3445fafbae (patch)
treec21b3c256ba04e5ea21d34f3eeb1a24694e906f3
parentf4800d6d1548e0d5ab94f2216d41d94282e2588c (diff)
block: remove REQ_NO_TIMEOUT flag
This was added for the 'magic' AEN requests in the NVMe driver that never return. We now handle them purely inside the driver and don't need this core hack any more. Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Keith Busch <keith.busch@intel.com> Signed-off-by: Jens Axboe <axboe@fb.com>
-rw-r--r--block/blk-mq.c2
-rw-r--r--block/blk-timeout.c3
-rw-r--r--include/linux/blk_types.h2
3 files changed, 0 insertions, 7 deletions
diff --git a/block/blk-mq.c b/block/blk-mq.c
index 9cb2894840ab..8f812b486c07 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -603,8 +603,6 @@ static void blk_mq_check_expired(struct blk_mq_hw_ctx *hctx,
603 blk_mq_complete_request(rq, -EIO); 603 blk_mq_complete_request(rq, -EIO);
604 return; 604 return;
605 } 605 }
606 if (rq->cmd_flags & REQ_NO_TIMEOUT)
607 return;
608 606
609 if (time_after_eq(jiffies, rq->deadline)) { 607 if (time_after_eq(jiffies, rq->deadline)) {
610 if (!blk_mark_rq_complete(rq)) 608 if (!blk_mark_rq_complete(rq))
diff --git a/block/blk-timeout.c b/block/blk-timeout.c
index dd4fdfbcb3dd..a30441a200c0 100644
--- a/block/blk-timeout.c
+++ b/block/blk-timeout.c
@@ -197,9 +197,6 @@ void blk_add_timer(struct request *req)
197 struct request_queue *q = req->q; 197 struct request_queue *q = req->q;
198 unsigned long expiry; 198 unsigned long expiry;
199 199
200 if (req->cmd_flags & REQ_NO_TIMEOUT)
201 return;
202
203 /* blk-mq has its own handler, so we don't need ->rq_timed_out_fn */ 200 /* blk-mq has its own handler, so we don't need ->rq_timed_out_fn */
204 if (!q->mq_ops && !q->rq_timed_out_fn) 201 if (!q->mq_ops && !q->rq_timed_out_fn)
205 return; 202 return;
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 0fb65843ec1e..86a38ea1823f 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -188,7 +188,6 @@ enum rq_flag_bits {
188 __REQ_PM, /* runtime pm request */ 188 __REQ_PM, /* runtime pm request */
189 __REQ_HASHED, /* on IO scheduler merge hash */ 189 __REQ_HASHED, /* on IO scheduler merge hash */
190 __REQ_MQ_INFLIGHT, /* track inflight for MQ */ 190 __REQ_MQ_INFLIGHT, /* track inflight for MQ */
191 __REQ_NO_TIMEOUT, /* requests may never expire */
192 __REQ_NR_BITS, /* stops here */ 191 __REQ_NR_BITS, /* stops here */
193}; 192};
194 193
@@ -242,7 +241,6 @@ enum rq_flag_bits {
242#define REQ_PM (1ULL << __REQ_PM) 241#define REQ_PM (1ULL << __REQ_PM)
243#define REQ_HASHED (1ULL << __REQ_HASHED) 242#define REQ_HASHED (1ULL << __REQ_HASHED)
244#define REQ_MQ_INFLIGHT (1ULL << __REQ_MQ_INFLIGHT) 243#define REQ_MQ_INFLIGHT (1ULL << __REQ_MQ_INFLIGHT)
245#define REQ_NO_TIMEOUT (1ULL << __REQ_NO_TIMEOUT)
246 244
247typedef unsigned int blk_qc_t; 245typedef unsigned int blk_qc_t;
248#define BLK_QC_T_NONE -1U 246#define BLK_QC_T_NONE -1U