aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTim Collier <osdevtc@gmail.com>2018-05-25 13:40:40 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2018-05-31 13:00:53 -0400
commitbb1192cbf43ec5b0db9ed593fa150cba917642ae (patch)
treee7399d279ccfcd356ba3b8483371a67990c7c45a
parent889cea43c54b91b92011649ce53db4fdc51ed86c (diff)
staging: wlan-ng: remove unused declarations from p80211types.h
A number of extern struct declarations in p80211types.h were causing checkpatch warnings: "extern prototypes should be avoided in .h files" and "function definition argument 'xxxxxx' should also have an identifier name". This appears to be a result of using a macro to form the declarations and checkpatch consequently misinterpreting the declarations as function prototypes. On checking, the declarations have no corresponding definition in the driver and are not used, so they are removed along with the macro used to construct them, which is not needed elsewhere. After this change, checkpatch reports that p80211types.h has no obvious issues. Signed-off-by: Tim Collier <osdevtc@gmail.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/staging/wlan-ng/p80211types.h31
1 files changed, 0 insertions, 31 deletions
diff --git a/drivers/staging/wlan-ng/p80211types.h b/drivers/staging/wlan-ng/p80211types.h
index 388357bbcbf5..7c37d56dd9b7 100644
--- a/drivers/staging/wlan-ng/p80211types.h
+++ b/drivers/staging/wlan-ng/p80211types.h
@@ -119,11 +119,6 @@
119 /* is a DID-LEN-DATA triple */ 119 /* is a DID-LEN-DATA triple */
120 /* with a max size of 4+4+384 */ 120 /* with a max size of 4+4+384 */
121 121
122/*----------------------------------------------------------------*/
123/* The following macro creates a name for an enum */
124
125#define MKENUMNAME(name) p80211enum_ ## name
126
127/*---------------------------------------------------------------- 122/*----------------------------------------------------------------
128 * The following constants and macros are used to construct and 123 * The following constants and macros are used to construct and
129 * deconstruct the Data ID codes. The coding is as follows: 124 * deconstruct the Data ID codes. The coding is as follows:
@@ -348,30 +343,4 @@ typedef void (*p80211_fromtext_t) (struct catlistitem *, u32 did, u8 *itembuf,
348 char *textbuf); 343 char *textbuf);
349typedef u32(*p80211_valid_t) (struct catlistitem *, u32 did, u8 *itembuf); 344typedef u32(*p80211_valid_t) (struct catlistitem *, u32 did, u8 *itembuf);
350 345
351/*----------------------------------------------------------------*/
352/* Enumeration Lists */
353/* The following are the external declarations */
354/* for all enumerations */
355
356extern struct p80211enum MKENUMNAME(truth);
357extern struct p80211enum MKENUMNAME(ifstate);
358extern struct p80211enum MKENUMNAME(powermgmt);
359extern struct p80211enum MKENUMNAME(bsstype);
360extern struct p80211enum MKENUMNAME(authalg);
361extern struct p80211enum MKENUMNAME(phytype);
362extern struct p80211enum MKENUMNAME(temptype);
363extern struct p80211enum MKENUMNAME(regdomain);
364extern struct p80211enum MKENUMNAME(ccamode);
365extern struct p80211enum MKENUMNAME(diversity);
366extern struct p80211enum MKENUMNAME(scantype);
367extern struct p80211enum MKENUMNAME(resultcode);
368extern struct p80211enum MKENUMNAME(reason);
369extern struct p80211enum MKENUMNAME(status);
370extern struct p80211enum MKENUMNAME(msgcode);
371extern struct p80211enum MKENUMNAME(msgitem_status);
372
373extern struct p80211enum MKENUMNAME(lnxroam_reason);
374
375extern struct p80211enum MKENUMNAME(p2preamble);
376
377#endif /* _P80211TYPES_H */ 346#endif /* _P80211TYPES_H */