diff options
author | Jakub Kicinski <jakub.kicinski@netronome.com> | 2018-01-25 17:00:53 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-01-25 21:23:09 -0500 |
commit | baf6a07e040d8308165654c7f49ee9ee18cd89be (patch) | |
tree | 4ebce6a79ade544f6568d78491065a785cc8f63d | |
parent | 2fb89a38d35bb6c935edb819d9096de455ce87cf (diff) |
selftests/bpf: check for chain-non-0 extack message
Make sure netdevsim doesn't allow offload of chains other than 0,
and that it reports the expected extack message.
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rwxr-xr-x | tools/testing/selftests/bpf/test_offload.py | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/tools/testing/selftests/bpf/test_offload.py b/tools/testing/selftests/bpf/test_offload.py index 49f5ceeabfa6..e78aad0a68bb 100755 --- a/tools/testing/selftests/bpf/test_offload.py +++ b/tools/testing/selftests/bpf/test_offload.py | |||
@@ -430,13 +430,15 @@ class NetdevSim: | |||
430 | return filters | 430 | return filters |
431 | 431 | ||
432 | def cls_filter_op(self, op, qdisc="ingress", prio=None, handle=None, | 432 | def cls_filter_op(self, op, qdisc="ingress", prio=None, handle=None, |
433 | cls="", params="", | 433 | chain=None, cls="", params="", |
434 | fail=True, include_stderr=False): | 434 | fail=True, include_stderr=False): |
435 | spec = "" | 435 | spec = "" |
436 | if prio is not None: | 436 | if prio is not None: |
437 | spec += " prio %d" % (prio) | 437 | spec += " prio %d" % (prio) |
438 | if handle: | 438 | if handle: |
439 | spec += " handle %s" % (handle) | 439 | spec += " handle %s" % (handle) |
440 | if chain is not None: | ||
441 | spec += " chain %d" % (chain) | ||
440 | 442 | ||
441 | return tc("filter {op} dev {dev} {qdisc} {spec} {cls} {params}"\ | 443 | return tc("filter {op} dev {dev} {qdisc} {spec} {cls} {params}"\ |
442 | .format(op=op, dev=self['ifname'], qdisc=qdisc, spec=spec, | 444 | .format(op=op, dev=self['ifname'], qdisc=qdisc, spec=spec, |
@@ -444,7 +446,7 @@ class NetdevSim: | |||
444 | fail=fail, include_stderr=include_stderr) | 446 | fail=fail, include_stderr=include_stderr) |
445 | 447 | ||
446 | def cls_bpf_add_filter(self, bpf, op="add", prio=None, handle=None, | 448 | def cls_bpf_add_filter(self, bpf, op="add", prio=None, handle=None, |
447 | da=False, verbose=False, | 449 | chain=None, da=False, verbose=False, |
448 | skip_sw=False, skip_hw=False, | 450 | skip_sw=False, skip_hw=False, |
449 | fail=True, include_stderr=False): | 451 | fail=True, include_stderr=False): |
450 | cls = "bpf " + bpf | 452 | cls = "bpf " + bpf |
@@ -460,7 +462,7 @@ class NetdevSim: | |||
460 | params += " skip_hw" | 462 | params += " skip_hw" |
461 | 463 | ||
462 | return self.cls_filter_op(op=op, prio=prio, handle=handle, cls=cls, | 464 | return self.cls_filter_op(op=op, prio=prio, handle=handle, cls=cls, |
463 | params=params, | 465 | chain=chain, params=params, |
464 | fail=fail, include_stderr=include_stderr) | 466 | fail=fail, include_stderr=include_stderr) |
465 | 467 | ||
466 | def set_ethtool_tc_offloads(self, enable, fail=True): | 468 | def set_ethtool_tc_offloads(self, enable, fail=True): |
@@ -679,6 +681,14 @@ try: | |||
679 | args) | 681 | args) |
680 | sim.wait_for_flush() | 682 | sim.wait_for_flush() |
681 | 683 | ||
684 | start_test("Test non-0 chain offload...") | ||
685 | ret, _, err = sim.cls_bpf_add_filter(obj, chain=1, prio=1, handle=1, | ||
686 | skip_sw=True, | ||
687 | fail=False, include_stderr=True) | ||
688 | fail(ret == 0, "Offloaded a filter to chain other than 0") | ||
689 | check_extack(err, "Error: Driver supports only offload of chain 0.", args) | ||
690 | sim.tc_flush_filters() | ||
691 | |||
682 | start_test("Test TC replace...") | 692 | start_test("Test TC replace...") |
683 | sim.cls_bpf_add_filter(obj, prio=1, handle=1) | 693 | sim.cls_bpf_add_filter(obj, prio=1, handle=1) |
684 | sim.cls_bpf_add_filter(obj, op="replace", prio=1, handle=1) | 694 | sim.cls_bpf_add_filter(obj, op="replace", prio=1, handle=1) |