diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2017-08-26 15:48:29 -0400 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2017-08-26 15:48:29 -0400 |
commit | bab9752480c54b5f483a0f52e53cbdef55a83219 (patch) | |
tree | 5fd22b796212de801182aa810e0f9aced5de639d | |
parent | 9716bdb23e1d44276299d3cc90884edbeff00341 (diff) | |
parent | 4a646580f793d19717f7e034c8d473b509c27d49 (diff) |
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
Pull input fixes from Dmitry Torokhov:
- a tweak to the IBM Trackpoint driver that helps recognizing
trackpoints on never Lenovo Carbons
- a fix to the ALPS driver solving scroll issues on some Dells
- yet another ACPI ID has been added to Elan I2C toucpad driver
- quieted diagnostic message in soc_button_array driver
* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input:
Input: ALPS - fix two-finger scroll breakage in right side on ALPS touchpad
Input: soc_button_array - silence -ENOENT error on Dell XPS13 9365
Input: trackpoint - add new trackpoint firmware ID
Input: elan_i2c - add ELAN0602 ACPI ID to support Lenovo Yoga310
-rw-r--r-- | drivers/input/misc/soc_button_array.c | 2 | ||||
-rw-r--r-- | drivers/input/mouse/alps.c | 41 | ||||
-rw-r--r-- | drivers/input/mouse/alps.h | 8 | ||||
-rw-r--r-- | drivers/input/mouse/elan_i2c_core.c | 1 | ||||
-rw-r--r-- | drivers/input/mouse/trackpoint.c | 3 | ||||
-rw-r--r-- | drivers/input/mouse/trackpoint.h | 3 |
6 files changed, 45 insertions, 13 deletions
diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c index f600f3a7a3c6..23520df7650f 100644 --- a/drivers/input/misc/soc_button_array.c +++ b/drivers/input/misc/soc_button_array.c | |||
@@ -331,7 +331,7 @@ static int soc_button_probe(struct platform_device *pdev) | |||
331 | error = gpiod_count(dev, NULL); | 331 | error = gpiod_count(dev, NULL); |
332 | if (error < 0) { | 332 | if (error < 0) { |
333 | dev_dbg(dev, "no GPIO attached, ignoring...\n"); | 333 | dev_dbg(dev, "no GPIO attached, ignoring...\n"); |
334 | return error; | 334 | return -ENODEV; |
335 | } | 335 | } |
336 | 336 | ||
337 | priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); | 337 | priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); |
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 262d1057c1da..850b00e3ad8e 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c | |||
@@ -1215,14 +1215,24 @@ static int alps_decode_ss4_v2(struct alps_fields *f, | |||
1215 | 1215 | ||
1216 | case SS4_PACKET_ID_TWO: | 1216 | case SS4_PACKET_ID_TWO: |
1217 | if (priv->flags & ALPS_BUTTONPAD) { | 1217 | if (priv->flags & ALPS_BUTTONPAD) { |
1218 | f->mt[0].x = SS4_BTL_MF_X_V2(p, 0); | 1218 | if (IS_SS4PLUS_DEV(priv->dev_id)) { |
1219 | f->mt[0].x = SS4_PLUS_BTL_MF_X_V2(p, 0); | ||
1220 | f->mt[1].x = SS4_PLUS_BTL_MF_X_V2(p, 1); | ||
1221 | } else { | ||
1222 | f->mt[0].x = SS4_BTL_MF_X_V2(p, 0); | ||
1223 | f->mt[1].x = SS4_BTL_MF_X_V2(p, 1); | ||
1224 | } | ||
1219 | f->mt[0].y = SS4_BTL_MF_Y_V2(p, 0); | 1225 | f->mt[0].y = SS4_BTL_MF_Y_V2(p, 0); |
1220 | f->mt[1].x = SS4_BTL_MF_X_V2(p, 1); | ||
1221 | f->mt[1].y = SS4_BTL_MF_Y_V2(p, 1); | 1226 | f->mt[1].y = SS4_BTL_MF_Y_V2(p, 1); |
1222 | } else { | 1227 | } else { |
1223 | f->mt[0].x = SS4_STD_MF_X_V2(p, 0); | 1228 | if (IS_SS4PLUS_DEV(priv->dev_id)) { |
1229 | f->mt[0].x = SS4_PLUS_STD_MF_X_V2(p, 0); | ||
1230 | f->mt[1].x = SS4_PLUS_STD_MF_X_V2(p, 1); | ||
1231 | } else { | ||
1232 | f->mt[0].x = SS4_STD_MF_X_V2(p, 0); | ||
1233 | f->mt[1].x = SS4_STD_MF_X_V2(p, 1); | ||
1234 | } | ||
1224 | f->mt[0].y = SS4_STD_MF_Y_V2(p, 0); | 1235 | f->mt[0].y = SS4_STD_MF_Y_V2(p, 0); |
1225 | f->mt[1].x = SS4_STD_MF_X_V2(p, 1); | ||
1226 | f->mt[1].y = SS4_STD_MF_Y_V2(p, 1); | 1236 | f->mt[1].y = SS4_STD_MF_Y_V2(p, 1); |
1227 | } | 1237 | } |
1228 | f->pressure = SS4_MF_Z_V2(p, 0) ? 0x30 : 0; | 1238 | f->pressure = SS4_MF_Z_V2(p, 0) ? 0x30 : 0; |
@@ -1239,16 +1249,27 @@ static int alps_decode_ss4_v2(struct alps_fields *f, | |||
1239 | 1249 | ||
1240 | case SS4_PACKET_ID_MULTI: | 1250 | case SS4_PACKET_ID_MULTI: |
1241 | if (priv->flags & ALPS_BUTTONPAD) { | 1251 | if (priv->flags & ALPS_BUTTONPAD) { |
1242 | f->mt[2].x = SS4_BTL_MF_X_V2(p, 0); | 1252 | if (IS_SS4PLUS_DEV(priv->dev_id)) { |
1253 | f->mt[0].x = SS4_PLUS_BTL_MF_X_V2(p, 0); | ||
1254 | f->mt[1].x = SS4_PLUS_BTL_MF_X_V2(p, 1); | ||
1255 | } else { | ||
1256 | f->mt[2].x = SS4_BTL_MF_X_V2(p, 0); | ||
1257 | f->mt[3].x = SS4_BTL_MF_X_V2(p, 1); | ||
1258 | } | ||
1259 | |||
1243 | f->mt[2].y = SS4_BTL_MF_Y_V2(p, 0); | 1260 | f->mt[2].y = SS4_BTL_MF_Y_V2(p, 0); |
1244 | f->mt[3].x = SS4_BTL_MF_X_V2(p, 1); | ||
1245 | f->mt[3].y = SS4_BTL_MF_Y_V2(p, 1); | 1261 | f->mt[3].y = SS4_BTL_MF_Y_V2(p, 1); |
1246 | no_data_x = SS4_MFPACKET_NO_AX_BL; | 1262 | no_data_x = SS4_MFPACKET_NO_AX_BL; |
1247 | no_data_y = SS4_MFPACKET_NO_AY_BL; | 1263 | no_data_y = SS4_MFPACKET_NO_AY_BL; |
1248 | } else { | 1264 | } else { |
1249 | f->mt[2].x = SS4_STD_MF_X_V2(p, 0); | 1265 | if (IS_SS4PLUS_DEV(priv->dev_id)) { |
1266 | f->mt[0].x = SS4_PLUS_STD_MF_X_V2(p, 0); | ||
1267 | f->mt[1].x = SS4_PLUS_STD_MF_X_V2(p, 1); | ||
1268 | } else { | ||
1269 | f->mt[0].x = SS4_STD_MF_X_V2(p, 0); | ||
1270 | f->mt[1].x = SS4_STD_MF_X_V2(p, 1); | ||
1271 | } | ||
1250 | f->mt[2].y = SS4_STD_MF_Y_V2(p, 0); | 1272 | f->mt[2].y = SS4_STD_MF_Y_V2(p, 0); |
1251 | f->mt[3].x = SS4_STD_MF_X_V2(p, 1); | ||
1252 | f->mt[3].y = SS4_STD_MF_Y_V2(p, 1); | 1273 | f->mt[3].y = SS4_STD_MF_Y_V2(p, 1); |
1253 | no_data_x = SS4_MFPACKET_NO_AX; | 1274 | no_data_x = SS4_MFPACKET_NO_AX; |
1254 | no_data_y = SS4_MFPACKET_NO_AY; | 1275 | no_data_y = SS4_MFPACKET_NO_AY; |
@@ -2541,8 +2562,8 @@ static int alps_set_defaults_ss4_v2(struct psmouse *psmouse, | |||
2541 | 2562 | ||
2542 | memset(otp, 0, sizeof(otp)); | 2563 | memset(otp, 0, sizeof(otp)); |
2543 | 2564 | ||
2544 | if (alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0]) || | 2565 | if (alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0]) || |
2545 | alps_get_otp_values_ss4_v2(psmouse, 1, &otp[1][0])) | 2566 | alps_get_otp_values_ss4_v2(psmouse, 0, &otp[0][0])) |
2546 | return -1; | 2567 | return -1; |
2547 | 2568 | ||
2548 | alps_update_device_area_ss4_v2(otp, priv); | 2569 | alps_update_device_area_ss4_v2(otp, priv); |
diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h index ed2d6879fa52..c80a7c76cb76 100644 --- a/drivers/input/mouse/alps.h +++ b/drivers/input/mouse/alps.h | |||
@@ -100,6 +100,10 @@ enum SS4_PACKET_ID { | |||
100 | ((_b[1 + _i * 3] << 5) & 0x1F00) \ | 100 | ((_b[1 + _i * 3] << 5) & 0x1F00) \ |
101 | ) | 101 | ) |
102 | 102 | ||
103 | #define SS4_PLUS_STD_MF_X_V2(_b, _i) (((_b[0 + (_i) * 3] << 4) & 0x0070) | \ | ||
104 | ((_b[1 + (_i) * 3] << 4) & 0x0F80) \ | ||
105 | ) | ||
106 | |||
103 | #define SS4_STD_MF_Y_V2(_b, _i) (((_b[1 + (_i) * 3] << 3) & 0x0010) | \ | 107 | #define SS4_STD_MF_Y_V2(_b, _i) (((_b[1 + (_i) * 3] << 3) & 0x0010) | \ |
104 | ((_b[2 + (_i) * 3] << 5) & 0x01E0) | \ | 108 | ((_b[2 + (_i) * 3] << 5) & 0x01E0) | \ |
105 | ((_b[2 + (_i) * 3] << 4) & 0x0E00) \ | 109 | ((_b[2 + (_i) * 3] << 4) & 0x0E00) \ |
@@ -109,6 +113,10 @@ enum SS4_PACKET_ID { | |||
109 | ((_b[0 + (_i) * 3] >> 3) & 0x0010) \ | 113 | ((_b[0 + (_i) * 3] >> 3) & 0x0010) \ |
110 | ) | 114 | ) |
111 | 115 | ||
116 | #define SS4_PLUS_BTL_MF_X_V2(_b, _i) (SS4_PLUS_STD_MF_X_V2(_b, _i) | \ | ||
117 | ((_b[0 + (_i) * 3] >> 4) & 0x0008) \ | ||
118 | ) | ||
119 | |||
112 | #define SS4_BTL_MF_Y_V2(_b, _i) (SS4_STD_MF_Y_V2(_b, _i) | \ | 120 | #define SS4_BTL_MF_Y_V2(_b, _i) (SS4_STD_MF_Y_V2(_b, _i) | \ |
113 | ((_b[0 + (_i) * 3] >> 3) & 0x0008) \ | 121 | ((_b[0 + (_i) * 3] >> 3) & 0x0008) \ |
114 | ) | 122 | ) |
diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index 714cf7f9b138..cfbc8ba4c96c 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c | |||
@@ -1247,6 +1247,7 @@ static const struct acpi_device_id elan_acpi_id[] = { | |||
1247 | { "ELAN0000", 0 }, | 1247 | { "ELAN0000", 0 }, |
1248 | { "ELAN0100", 0 }, | 1248 | { "ELAN0100", 0 }, |
1249 | { "ELAN0600", 0 }, | 1249 | { "ELAN0600", 0 }, |
1250 | { "ELAN0602", 0 }, | ||
1250 | { "ELAN0605", 0 }, | 1251 | { "ELAN0605", 0 }, |
1251 | { "ELAN0608", 0 }, | 1252 | { "ELAN0608", 0 }, |
1252 | { "ELAN0605", 0 }, | 1253 | { "ELAN0605", 0 }, |
diff --git a/drivers/input/mouse/trackpoint.c b/drivers/input/mouse/trackpoint.c index 20b5b21c1bba..0871010f18d5 100644 --- a/drivers/input/mouse/trackpoint.c +++ b/drivers/input/mouse/trackpoint.c | |||
@@ -265,7 +265,8 @@ static int trackpoint_start_protocol(struct psmouse *psmouse, unsigned char *fir | |||
265 | if (ps2_command(&psmouse->ps2dev, param, MAKE_PS2_CMD(0, 2, TP_READ_ID))) | 265 | if (ps2_command(&psmouse->ps2dev, param, MAKE_PS2_CMD(0, 2, TP_READ_ID))) |
266 | return -1; | 266 | return -1; |
267 | 267 | ||
268 | if (param[0] != TP_MAGIC_IDENT) | 268 | /* add new TP ID. */ |
269 | if (!(param[0] & TP_MAGIC_IDENT)) | ||
269 | return -1; | 270 | return -1; |
270 | 271 | ||
271 | if (firmware_id) | 272 | if (firmware_id) |
diff --git a/drivers/input/mouse/trackpoint.h b/drivers/input/mouse/trackpoint.h index 5617ed3a7d7a..88055755f82e 100644 --- a/drivers/input/mouse/trackpoint.h +++ b/drivers/input/mouse/trackpoint.h | |||
@@ -21,8 +21,9 @@ | |||
21 | #define TP_COMMAND 0xE2 /* Commands start with this */ | 21 | #define TP_COMMAND 0xE2 /* Commands start with this */ |
22 | 22 | ||
23 | #define TP_READ_ID 0xE1 /* Sent for device identification */ | 23 | #define TP_READ_ID 0xE1 /* Sent for device identification */ |
24 | #define TP_MAGIC_IDENT 0x01 /* Sent after a TP_READ_ID followed */ | 24 | #define TP_MAGIC_IDENT 0x03 /* Sent after a TP_READ_ID followed */ |
25 | /* by the firmware ID */ | 25 | /* by the firmware ID */ |
26 | /* Firmware ID includes 0x1, 0x2, 0x3 */ | ||
26 | 27 | ||
27 | 28 | ||
28 | /* | 29 | /* |