diff options
author | Noralf Trønnes <noralf@tronnes.org> | 2017-01-26 17:56:05 -0500 |
---|---|---|
committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2017-01-27 03:02:03 -0500 |
commit | ba0c6d0087510b5db4d4b4f96f202bc893844c55 (patch) | |
tree | 62763f02ca5fdc1f5c2b3a28f691d51f3416cad6 | |
parent | a67834f8bfa1e2f48bb27d07b9a552ba7c3af82a (diff) |
drm/atomic: Remove drm_atomic_debugfs_cleanup()
drm_debugfs_cleanup() now removes all minor->debugfs_list entries
automatically, so no need to call drm_debugfs_remove_files().
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170126225621.12314-4-noralf@tronnes.org
-rw-r--r-- | drivers/gpu/drm/drm_atomic.c | 7 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_crtc_internal.h | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/drm_debugfs.c | 9 |
3 files changed, 0 insertions, 17 deletions
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index 7fd88a09304b..e5b738660d66 100644 --- a/drivers/gpu/drm/drm_atomic.c +++ b/drivers/gpu/drm/drm_atomic.c | |||
@@ -1727,13 +1727,6 @@ int drm_atomic_debugfs_init(struct drm_minor *minor) | |||
1727 | ARRAY_SIZE(drm_atomic_debugfs_list), | 1727 | ARRAY_SIZE(drm_atomic_debugfs_list), |
1728 | minor->debugfs_root, minor); | 1728 | minor->debugfs_root, minor); |
1729 | } | 1729 | } |
1730 | |||
1731 | int drm_atomic_debugfs_cleanup(struct drm_minor *minor) | ||
1732 | { | ||
1733 | return drm_debugfs_remove_files(drm_atomic_debugfs_list, | ||
1734 | ARRAY_SIZE(drm_atomic_debugfs_list), | ||
1735 | minor); | ||
1736 | } | ||
1737 | #endif | 1730 | #endif |
1738 | 1731 | ||
1739 | /* | 1732 | /* |
diff --git a/drivers/gpu/drm/drm_crtc_internal.h b/drivers/gpu/drm/drm_crtc_internal.h index 724c329186d5..1bdcfd566695 100644 --- a/drivers/gpu/drm/drm_crtc_internal.h +++ b/drivers/gpu/drm/drm_crtc_internal.h | |||
@@ -177,7 +177,6 @@ int drm_mode_dirtyfb_ioctl(struct drm_device *dev, | |||
177 | #ifdef CONFIG_DEBUG_FS | 177 | #ifdef CONFIG_DEBUG_FS |
178 | struct drm_minor; | 178 | struct drm_minor; |
179 | int drm_atomic_debugfs_init(struct drm_minor *minor); | 179 | int drm_atomic_debugfs_init(struct drm_minor *minor); |
180 | int drm_atomic_debugfs_cleanup(struct drm_minor *minor); | ||
181 | #endif | 180 | #endif |
182 | 181 | ||
183 | int drm_atomic_get_property(struct drm_mode_object *obj, | 182 | int drm_atomic_get_property(struct drm_mode_object *obj, |
diff --git a/drivers/gpu/drm/drm_debugfs.c b/drivers/gpu/drm/drm_debugfs.c index 04b0af3c903e..2290a74a6e46 100644 --- a/drivers/gpu/drm/drm_debugfs.c +++ b/drivers/gpu/drm/drm_debugfs.c | |||
@@ -243,7 +243,6 @@ static void drm_debugfs_remove_all_files(struct drm_minor *minor) | |||
243 | int drm_debugfs_cleanup(struct drm_minor *minor) | 243 | int drm_debugfs_cleanup(struct drm_minor *minor) |
244 | { | 244 | { |
245 | struct drm_device *dev = minor->dev; | 245 | struct drm_device *dev = minor->dev; |
246 | int ret; | ||
247 | 246 | ||
248 | if (!minor->debugfs_root) | 247 | if (!minor->debugfs_root) |
249 | return 0; | 248 | return 0; |
@@ -251,14 +250,6 @@ int drm_debugfs_cleanup(struct drm_minor *minor) | |||
251 | if (dev->driver->debugfs_cleanup) | 250 | if (dev->driver->debugfs_cleanup) |
252 | dev->driver->debugfs_cleanup(minor); | 251 | dev->driver->debugfs_cleanup(minor); |
253 | 252 | ||
254 | if (drm_core_check_feature(dev, DRIVER_ATOMIC)) { | ||
255 | ret = drm_atomic_debugfs_cleanup(minor); | ||
256 | if (ret) { | ||
257 | DRM_ERROR("DRM: Failed to remove atomic debugfs entries\n"); | ||
258 | return ret; | ||
259 | } | ||
260 | } | ||
261 | |||
262 | drm_debugfs_remove_all_files(minor); | 253 | drm_debugfs_remove_all_files(minor); |
263 | 254 | ||
264 | debugfs_remove_recursive(minor->debugfs_root); | 255 | debugfs_remove_recursive(minor->debugfs_root); |