diff options
author | Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com> | 2018-03-09 23:46:05 -0500 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2018-03-12 10:57:38 -0400 |
commit | b9ecc3400bc418af3ba9e56ea852f4ad69c23454 (patch) | |
tree | 37fea15c3b173aa9330b8a669bd01fca53e71ec8 | |
parent | 6fc2ffdf1001ae4fb485b3ba95ff757ae54565c9 (diff) |
bnxt_en: Remove unwanted ovs-offload messages in some conditions
In some conditions when the driver fails to add a flow in HW and returns
an error back to the stack, the stack continues to invoke get_flow_stats()
and/or del_flow() on it. The driver fails these APIs with an error message
"no flow_node for cookie". The message gets logged repeatedly as long as
the stack keeps invoking these functions.
Fix this by removing the corresponding netdev_info() calls from these
functions.
Fixes: d7bc73053024 ("bnxt_en: add code to query TC flower offload stats")
Signed-off-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | 10 |
1 files changed, 2 insertions, 8 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c index fbe6e208e17b..2049d4356df4 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c | |||
@@ -1269,11 +1269,8 @@ static int bnxt_tc_del_flow(struct bnxt *bp, | |||
1269 | flow_node = rhashtable_lookup_fast(&tc_info->flow_table, | 1269 | flow_node = rhashtable_lookup_fast(&tc_info->flow_table, |
1270 | &tc_flow_cmd->cookie, | 1270 | &tc_flow_cmd->cookie, |
1271 | tc_info->flow_ht_params); | 1271 | tc_info->flow_ht_params); |
1272 | if (!flow_node) { | 1272 | if (!flow_node) |
1273 | netdev_info(bp->dev, "ERROR: no flow_node for cookie %lx", | ||
1274 | tc_flow_cmd->cookie); | ||
1275 | return -EINVAL; | 1273 | return -EINVAL; |
1276 | } | ||
1277 | 1274 | ||
1278 | return __bnxt_tc_del_flow(bp, flow_node); | 1275 | return __bnxt_tc_del_flow(bp, flow_node); |
1279 | } | 1276 | } |
@@ -1290,11 +1287,8 @@ static int bnxt_tc_get_flow_stats(struct bnxt *bp, | |||
1290 | flow_node = rhashtable_lookup_fast(&tc_info->flow_table, | 1287 | flow_node = rhashtable_lookup_fast(&tc_info->flow_table, |
1291 | &tc_flow_cmd->cookie, | 1288 | &tc_flow_cmd->cookie, |
1292 | tc_info->flow_ht_params); | 1289 | tc_info->flow_ht_params); |
1293 | if (!flow_node) { | 1290 | if (!flow_node) |
1294 | netdev_info(bp->dev, "Error: no flow_node for cookie %lx", | ||
1295 | tc_flow_cmd->cookie); | ||
1296 | return -1; | 1291 | return -1; |
1297 | } | ||
1298 | 1292 | ||
1299 | flow = &flow_node->flow; | 1293 | flow = &flow_node->flow; |
1300 | curr_stats = &flow->stats; | 1294 | curr_stats = &flow->stats; |