aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBob Peterson <rpeterso@redhat.com>2018-02-14 11:32:39 -0500
committerBob Peterson <rpeterso@redhat.com>2018-03-08 11:26:20 -0500
commitb9e03f1861d8ee117aebb40e5d975cf355879405 (patch)
tree259366993189bcf0156f9a3ced58b23e853b9821
parent9bc980cdb9ac2fd2e6c18ba5ba18a6909971a4a2 (diff)
GFS2: Only set PageChecked for jdata pages
Before this patch, GFS2 was setting the PageChecked flag for ordered write pages. This is unnecessary. The ext3 file system only does it for jdata, and it's only used in jdata circumstances. It only muddies the already murky waters of writing pages in the aops. Signed-off-by: Bob Peterson <rpeterso@redhat.com>
-rw-r--r--fs/gfs2/aops.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/gfs2/aops.c b/fs/gfs2/aops.c
index 2f725b4a386b..f58716567972 100644
--- a/fs/gfs2/aops.c
+++ b/fs/gfs2/aops.c
@@ -940,13 +940,13 @@ failed:
940} 940}
941 941
942/** 942/**
943 * gfs2_set_page_dirty - Page dirtying function 943 * jdata_set_page_dirty - Page dirtying function
944 * @page: The page to dirty 944 * @page: The page to dirty
945 * 945 *
946 * Returns: 1 if it dirtyed the page, or 0 otherwise 946 * Returns: 1 if it dirtyed the page, or 0 otherwise
947 */ 947 */
948 948
949static int gfs2_set_page_dirty(struct page *page) 949static int jdata_set_page_dirty(struct page *page)
950{ 950{
951 SetPageChecked(page); 951 SetPageChecked(page);
952 return __set_page_dirty_buffers(page); 952 return __set_page_dirty_buffers(page);
@@ -1214,7 +1214,7 @@ static const struct address_space_operations gfs2_ordered_aops = {
1214 .readpages = gfs2_readpages, 1214 .readpages = gfs2_readpages,
1215 .write_begin = gfs2_write_begin, 1215 .write_begin = gfs2_write_begin,
1216 .write_end = gfs2_write_end, 1216 .write_end = gfs2_write_end,
1217 .set_page_dirty = gfs2_set_page_dirty, 1217 .set_page_dirty = __set_page_dirty_buffers,
1218 .bmap = gfs2_bmap, 1218 .bmap = gfs2_bmap,
1219 .invalidatepage = gfs2_invalidatepage, 1219 .invalidatepage = gfs2_invalidatepage,
1220 .releasepage = gfs2_releasepage, 1220 .releasepage = gfs2_releasepage,
@@ -1231,7 +1231,7 @@ static const struct address_space_operations gfs2_jdata_aops = {
1231 .readpages = gfs2_readpages, 1231 .readpages = gfs2_readpages,
1232 .write_begin = gfs2_write_begin, 1232 .write_begin = gfs2_write_begin,
1233 .write_end = gfs2_write_end, 1233 .write_end = gfs2_write_end,
1234 .set_page_dirty = gfs2_set_page_dirty, 1234 .set_page_dirty = jdata_set_page_dirty,
1235 .bmap = gfs2_bmap, 1235 .bmap = gfs2_bmap,
1236 .invalidatepage = gfs2_invalidatepage, 1236 .invalidatepage = gfs2_invalidatepage,
1237 .releasepage = gfs2_releasepage, 1237 .releasepage = gfs2_releasepage,