diff options
| author | Tyrel Datwyler <tyreld@linux.vnet.ibm.com> | 2017-04-17 20:29:17 -0400 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2017-04-18 12:04:12 -0400 |
| commit | b8475cbee5ab2eac05f9cd5dbcc94c453d3cbf10 (patch) | |
| tree | ebfce07a5c838a42fb11af8fb24d706e4656b8b0 | |
| parent | ac37f761ce80386f8a8f11a181c7ce3f9695a9ca (diff) | |
of: fix "/cpus" reference leak in of_numa_parse_cpu_nodes()
The call to of_find_node_by_path("/cpus") returns the cpus device_node
with its reference count incremented. There is no matching of_node_put()
call in of_numa_parse_cpu_nodes() which results in a leaked reference
to the "/cpus" node.
This patch adds an of_node_put() to release the reference.
fixes: 298535c00a2c ("of, numa: Add NUMA of binding implementation.")
Signed-off-by: Tyrel Datwyler <tyreld@linux.vnet.ibm.com>
Acked-by: David Daney <david.daney@cavium.com>
Cc: stable@vger.kernel.org # v4.7+
Signed-off-by: Rob Herring <robh@kernel.org>
| -rw-r--r-- | drivers/of/of_numa.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/of/of_numa.c b/drivers/of/of_numa.c index a53982a330ea..2db1f7a04baf 100644 --- a/drivers/of/of_numa.c +++ b/drivers/of/of_numa.c | |||
| @@ -57,6 +57,8 @@ static void __init of_numa_parse_cpu_nodes(void) | |||
| 57 | else | 57 | else |
| 58 | node_set(nid, numa_nodes_parsed); | 58 | node_set(nid, numa_nodes_parsed); |
| 59 | } | 59 | } |
| 60 | |||
| 61 | of_node_put(cpus); | ||
| 60 | } | 62 | } |
| 61 | 63 | ||
| 62 | static int __init of_numa_parse_memory_nodes(void) | 64 | static int __init of_numa_parse_memory_nodes(void) |
