aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRaed Salem <raeds@mellanox.com>2019-06-02 05:04:08 -0400
committerSaeed Mahameed <saeedm@mellanox.com>2019-06-07 17:40:37 -0400
commitb83c0730167c7ea6c03bffceefb86ae710ab30e2 (patch)
tree5b2c543db928c453be624f2dfb1153daedb53cb7
parent57c70d8740f740498a52f9c0c0d7295829b944de (diff)
net/mlx5e: Fix source port matching in fdb peer flow rule
The cited commit changed the initialization placement of the eswitch attributes so it is done prior to parse tc actions function call, including among others the in_rep and in_mdev fields which are mistakenly reassigned inside the parse actions function. This breaks the source port matching criteria of the peer redirect rule. Fix by removing the now redundant reassignment of the already initialized fields. Fixes: 988ab9c7363a ("net/mlx5e: Introduce mlx5e_flow_esw_attr_init() helper") Signed-off-by: Raed Salem <raeds@mellanox.com> Reviewed-by: Roi Dayan <roid@mellanox.com> Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/en_tc.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 31cd02f11499..e40c60d1631f 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -2812,9 +2812,6 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv,
2812 if (!flow_action_has_entries(flow_action)) 2812 if (!flow_action_has_entries(flow_action))
2813 return -EINVAL; 2813 return -EINVAL;
2814 2814
2815 attr->in_rep = rpriv->rep;
2816 attr->in_mdev = priv->mdev;
2817
2818 flow_action_for_each(i, act, flow_action) { 2815 flow_action_for_each(i, act, flow_action) {
2819 switch (act->id) { 2816 switch (act->id) {
2820 case FLOW_ACTION_DROP: 2817 case FLOW_ACTION_DROP: