diff options
author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2016-03-02 19:48:30 -0500 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2016-03-04 22:54:36 -0500 |
commit | b821957a5ae76994eebf9eed3247be0ba5775c30 (patch) | |
tree | 502c0268437f81a71138816ce44dfc1e6b821d4f | |
parent | e6ef243fa4660f3206137bd5f3e69b13a9b7c28a (diff) |
regmap: replace regmap_write_bits()
commit 23b92e4cf5fd ("regmap: remove regmap_write_bits()")
removed regmap_write_bits(), but MFD driver was using it.
So, commit e30fccd6771d ("regmap: Keep regmap_write_bits()")
turns out it, but it is using original style.
This patch uses regmap_update_bits_base() for regmap_write_bits()
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | drivers/base/regmap/regmap.c | 23 | ||||
-rw-r--r-- | include/linux/regmap.h | 12 |
2 files changed, 3 insertions, 32 deletions
diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index c7d4a636778d..3fb04c36ae5e 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c | |||
@@ -2650,29 +2650,6 @@ int regmap_update_bits_base(struct regmap *map, unsigned int reg, | |||
2650 | } | 2650 | } |
2651 | EXPORT_SYMBOL_GPL(regmap_update_bits_base); | 2651 | EXPORT_SYMBOL_GPL(regmap_update_bits_base); |
2652 | 2652 | ||
2653 | /** | ||
2654 | * regmap_write_bits: Perform a read/modify/write cycle on the register map | ||
2655 | * | ||
2656 | * @map: Register map to update | ||
2657 | * @reg: Register to update | ||
2658 | * @mask: Bitmask to change | ||
2659 | * @val: New value for bitmask | ||
2660 | * | ||
2661 | * Returns zero for success, a negative number on error. | ||
2662 | */ | ||
2663 | int regmap_write_bits(struct regmap *map, unsigned int reg, | ||
2664 | unsigned int mask, unsigned int val) | ||
2665 | { | ||
2666 | int ret; | ||
2667 | |||
2668 | map->lock(map->lock_arg); | ||
2669 | ret = _regmap_update_bits(map, reg, mask, val, NULL, true); | ||
2670 | map->unlock(map->lock_arg); | ||
2671 | |||
2672 | return ret; | ||
2673 | } | ||
2674 | EXPORT_SYMBOL_GPL(regmap_write_bits); | ||
2675 | |||
2676 | void regmap_async_complete_cb(struct regmap_async *async, int ret) | 2653 | void regmap_async_complete_cb(struct regmap_async *async, int ret) |
2677 | { | 2654 | { |
2678 | struct regmap *map = async->map; | 2655 | struct regmap *map = async->map; |
diff --git a/include/linux/regmap.h b/include/linux/regmap.h index e0960b3ff290..0744c9fea24c 100644 --- a/include/linux/regmap.h +++ b/include/linux/regmap.h | |||
@@ -74,6 +74,9 @@ struct reg_sequence { | |||
74 | #define regmap_update_bits_check_async(map, reg, mask, val, change)\ | 74 | #define regmap_update_bits_check_async(map, reg, mask, val, change)\ |
75 | regmap_update_bits_base(map, reg, mask, val, change, true, false) | 75 | regmap_update_bits_base(map, reg, mask, val, change, true, false) |
76 | 76 | ||
77 | #define regmap_write_bits(map, reg, mask, val) \ | ||
78 | regmap_update_bits_base(map, reg, mask, val, NULL, false, true) | ||
79 | |||
77 | #define regmap_field_write(field, val) \ | 80 | #define regmap_field_write(field, val) \ |
78 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false) | 81 | regmap_field_update_bits_base(field, ~0, val, NULL, false, false) |
79 | #define regmap_field_force_write(field, val) \ | 82 | #define regmap_field_force_write(field, val) \ |
@@ -721,8 +724,6 @@ int regmap_bulk_read(struct regmap *map, unsigned int reg, void *val, | |||
721 | int regmap_update_bits_base(struct regmap *map, unsigned int reg, | 724 | int regmap_update_bits_base(struct regmap *map, unsigned int reg, |
722 | unsigned int mask, unsigned int val, | 725 | unsigned int mask, unsigned int val, |
723 | bool *change, bool async, bool force); | 726 | bool *change, bool async, bool force); |
724 | int regmap_write_bits(struct regmap *map, unsigned int reg, | ||
725 | unsigned int mask, unsigned int val); | ||
726 | int regmap_get_val_bytes(struct regmap *map); | 727 | int regmap_get_val_bytes(struct regmap *map); |
727 | int regmap_get_max_register(struct regmap *map); | 728 | int regmap_get_max_register(struct regmap *map); |
728 | int regmap_get_reg_stride(struct regmap *map); | 729 | int regmap_get_reg_stride(struct regmap *map); |
@@ -961,13 +962,6 @@ static inline int regmap_update_bits_base(struct regmap *map, unsigned int reg, | |||
961 | return -EINVAL; | 962 | return -EINVAL; |
962 | } | 963 | } |
963 | 964 | ||
964 | static inline int regmap_write_bits(struct regmap *map, unsigned int reg, | ||
965 | unsigned int mask, unsigned int val) | ||
966 | { | ||
967 | WARN_ONCE(1, "regmap API is disabled"); | ||
968 | return -EINVAL; | ||
969 | } | ||
970 | |||
971 | static inline int regmap_field_update_bits_base(struct regmap_field *field, | 965 | static inline int regmap_field_update_bits_base(struct regmap_field *field, |
972 | unsigned int mask, unsigned int val, | 966 | unsigned int mask, unsigned int val, |
973 | bool *change, bool async, bool force) | 967 | bool *change, bool async, bool force) |