aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMarkus Elfring <elfring@users.sourceforge.net>2019-08-21 15:48:46 -0400
committerDavid S. Miller <davem@davemloft.net>2019-08-22 19:22:03 -0400
commitb7deac31979bd09c69e0e6e064609fad55df35be (patch)
treefe8485ecbc691daec727b18ba4d7f8b3b5b0f209
parent038dab7efc38254e151adbbade13b8860055d44a (diff)
hamradio: Delete unnecessary checks before the macro call “dev_kfree_skb”
The dev_kfree_skb() function performs also input parameter validation. Thus the test around the shown calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/hamradio/baycom_epp.c3
-rw-r--r--drivers/net/hamradio/hdlcdrv.c3
2 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/hamradio/baycom_epp.c b/drivers/net/hamradio/baycom_epp.c
index 9303aeb2595f..4476491b58f9 100644
--- a/drivers/net/hamradio/baycom_epp.c
+++ b/drivers/net/hamradio/baycom_epp.c
@@ -961,8 +961,7 @@ static int epp_close(struct net_device *dev)
961 parport_write_control(pp, 0); /* reset the adapter */ 961 parport_write_control(pp, 0); /* reset the adapter */
962 parport_release(bc->pdev); 962 parport_release(bc->pdev);
963 parport_unregister_device(bc->pdev); 963 parport_unregister_device(bc->pdev);
964 if (bc->skb) 964 dev_kfree_skb(bc->skb);
965 dev_kfree_skb(bc->skb);
966 bc->skb = NULL; 965 bc->skb = NULL;
967 printk(KERN_INFO "%s: close epp at iobase 0x%lx irq %u\n", 966 printk(KERN_INFO "%s: close epp at iobase 0x%lx irq %u\n",
968 bc_drvname, dev->base_addr, dev->irq); 967 bc_drvname, dev->base_addr, dev->irq);
diff --git a/drivers/net/hamradio/hdlcdrv.c b/drivers/net/hamradio/hdlcdrv.c
index c6f83e0df0a3..df495b5595f5 100644
--- a/drivers/net/hamradio/hdlcdrv.c
+++ b/drivers/net/hamradio/hdlcdrv.c
@@ -475,8 +475,7 @@ static int hdlcdrv_close(struct net_device *dev)
475 475
476 if (s->ops && s->ops->close) 476 if (s->ops && s->ops->close)
477 i = s->ops->close(dev); 477 i = s->ops->close(dev);
478 if (s->skb) 478 dev_kfree_skb(s->skb);
479 dev_kfree_skb(s->skb);
480 s->skb = NULL; 479 s->skb = NULL;
481 s->opened = 0; 480 s->opened = 0;
482 return i; 481 return i;