diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2017-05-08 04:48:21 -0400 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2017-05-22 04:39:10 -0400 |
| commit | b4d2ea2af95cb77e2f320e24da526280d4aa2f6b (patch) | |
| tree | 24005db946ede7cec566c13c407e1c53be400866 | |
| parent | a9de080bbcd5c4e213a3d7bbb1e314d60980e943 (diff) | |
Revert "pinctrl: generic: Add bi-directional and output-enable"
This reverts commit 8c58f1a7a4b6d1d723bf25fef9d842d5a11200d0.
It turns out that applying these generic properties was
premature: the properties used in the driver using this
are of unclear electrical nature and the subject need to
be discussed.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | 2 | ||||
| -rw-r--r-- | drivers/pinctrl/pinconf-generic.c | 3 | ||||
| -rw-r--r-- | include/linux/pinctrl/pinconf-generic.h | 3 |
3 files changed, 0 insertions, 8 deletions
diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt index 71a3c134af1b..f01d154090da 100644 --- a/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-bindings.txt | |||
| @@ -247,7 +247,6 @@ bias-bus-hold - latch weakly | |||
| 247 | bias-pull-up - pull up the pin | 247 | bias-pull-up - pull up the pin |
| 248 | bias-pull-down - pull down the pin | 248 | bias-pull-down - pull down the pin |
| 249 | bias-pull-pin-default - use pin-default pull state | 249 | bias-pull-pin-default - use pin-default pull state |
| 250 | bi-directional - pin supports simultaneous input/output operations | ||
| 251 | drive-push-pull - drive actively high and low | 250 | drive-push-pull - drive actively high and low |
| 252 | drive-open-drain - drive with open drain | 251 | drive-open-drain - drive with open drain |
| 253 | drive-open-source - drive with open source | 252 | drive-open-source - drive with open source |
| @@ -260,7 +259,6 @@ input-debounce - debounce mode with debound time X | |||
| 260 | power-source - select between different power supplies | 259 | power-source - select between different power supplies |
| 261 | low-power-enable - enable low power mode | 260 | low-power-enable - enable low power mode |
| 262 | low-power-disable - disable low power mode | 261 | low-power-disable - disable low power mode |
| 263 | output-enable - enable output on pin regardless of output value | ||
| 264 | output-low - set the pin to output mode with low level | 262 | output-low - set the pin to output mode with low level |
| 265 | output-high - set the pin to output mode with high level | 263 | output-high - set the pin to output mode with high level |
| 266 | slew-rate - set the slew rate | 264 | slew-rate - set the slew rate |
diff --git a/drivers/pinctrl/pinconf-generic.c b/drivers/pinctrl/pinconf-generic.c index 0d6b7f4b82af..720a19fd38d2 100644 --- a/drivers/pinctrl/pinconf-generic.c +++ b/drivers/pinctrl/pinconf-generic.c | |||
| @@ -35,7 +35,6 @@ static const struct pin_config_item conf_items[] = { | |||
| 35 | PCONFDUMP(PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, | 35 | PCONFDUMP(PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, |
| 36 | "input bias pull to pin specific state", NULL, false), | 36 | "input bias pull to pin specific state", NULL, false), |
| 37 | PCONFDUMP(PIN_CONFIG_BIAS_PULL_UP, "input bias pull up", NULL, false), | 37 | PCONFDUMP(PIN_CONFIG_BIAS_PULL_UP, "input bias pull up", NULL, false), |
| 38 | PCONFDUMP(PIN_CONFIG_BIDIRECTIONAL, "bi-directional pin operations", NULL, false), | ||
| 39 | PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_DRAIN, "output drive open drain", NULL, false), | 38 | PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_DRAIN, "output drive open drain", NULL, false), |
| 40 | PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_SOURCE, "output drive open source", NULL, false), | 39 | PCONFDUMP(PIN_CONFIG_DRIVE_OPEN_SOURCE, "output drive open source", NULL, false), |
| 41 | PCONFDUMP(PIN_CONFIG_DRIVE_PUSH_PULL, "output drive push pull", NULL, false), | 40 | PCONFDUMP(PIN_CONFIG_DRIVE_PUSH_PULL, "output drive push pull", NULL, false), |
| @@ -161,7 +160,6 @@ static const struct pinconf_generic_params dt_params[] = { | |||
| 161 | { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 1 }, | 160 | { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 1 }, |
| 162 | { "bias-pull-pin-default", PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, 1 }, | 161 | { "bias-pull-pin-default", PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, 1 }, |
| 163 | { "bias-pull-down", PIN_CONFIG_BIAS_PULL_DOWN, 1 }, | 162 | { "bias-pull-down", PIN_CONFIG_BIAS_PULL_DOWN, 1 }, |
| 164 | { "bi-directional", PIN_CONFIG_BIDIRECTIONAL, 1 }, | ||
| 165 | { "drive-open-drain", PIN_CONFIG_DRIVE_OPEN_DRAIN, 0 }, | 163 | { "drive-open-drain", PIN_CONFIG_DRIVE_OPEN_DRAIN, 0 }, |
| 166 | { "drive-open-source", PIN_CONFIG_DRIVE_OPEN_SOURCE, 0 }, | 164 | { "drive-open-source", PIN_CONFIG_DRIVE_OPEN_SOURCE, 0 }, |
| 167 | { "drive-push-pull", PIN_CONFIG_DRIVE_PUSH_PULL, 0 }, | 165 | { "drive-push-pull", PIN_CONFIG_DRIVE_PUSH_PULL, 0 }, |
| @@ -174,7 +172,6 @@ static const struct pinconf_generic_params dt_params[] = { | |||
| 174 | { "input-schmitt-enable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 1 }, | 172 | { "input-schmitt-enable", PIN_CONFIG_INPUT_SCHMITT_ENABLE, 1 }, |
| 175 | { "low-power-disable", PIN_CONFIG_LOW_POWER_MODE, 0 }, | 173 | { "low-power-disable", PIN_CONFIG_LOW_POWER_MODE, 0 }, |
| 176 | { "low-power-enable", PIN_CONFIG_LOW_POWER_MODE, 1 }, | 174 | { "low-power-enable", PIN_CONFIG_LOW_POWER_MODE, 1 }, |
| 177 | { "output-enable", PIN_CONFIG_OUTPUT, 1, }, | ||
| 178 | { "output-high", PIN_CONFIG_OUTPUT, 1, }, | 175 | { "output-high", PIN_CONFIG_OUTPUT, 1, }, |
| 179 | { "output-low", PIN_CONFIG_OUTPUT, 0, }, | 176 | { "output-low", PIN_CONFIG_OUTPUT, 0, }, |
| 180 | { "power-source", PIN_CONFIG_POWER_SOURCE, 0 }, | 177 | { "power-source", PIN_CONFIG_POWER_SOURCE, 0 }, |
diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h index 279e3c5326e3..7620eb127cff 100644 --- a/include/linux/pinctrl/pinconf-generic.h +++ b/include/linux/pinctrl/pinconf-generic.h | |||
| @@ -42,8 +42,6 @@ | |||
| 42 | * @PIN_CONFIG_BIAS_PULL_UP: the pin will be pulled up (usually with high | 42 | * @PIN_CONFIG_BIAS_PULL_UP: the pin will be pulled up (usually with high |
| 43 | * impedance to VDD). If the argument is != 0 pull-up is enabled, | 43 | * impedance to VDD). If the argument is != 0 pull-up is enabled, |
| 44 | * if it is 0, pull-up is total, i.e. the pin is connected to VDD. | 44 | * if it is 0, pull-up is total, i.e. the pin is connected to VDD. |
| 45 | * @PIN_CONFIG_BIDIRECTIONAL: the pin will be configured to allow simultaneous | ||
| 46 | * input and output operations. | ||
| 47 | * @PIN_CONFIG_DRIVE_OPEN_DRAIN: the pin will be driven with open drain (open | 45 | * @PIN_CONFIG_DRIVE_OPEN_DRAIN: the pin will be driven with open drain (open |
| 48 | * collector) which means it is usually wired with other output ports | 46 | * collector) which means it is usually wired with other output ports |
| 49 | * which are then pulled up with an external resistor. Setting this | 47 | * which are then pulled up with an external resistor. Setting this |
| @@ -98,7 +96,6 @@ enum pin_config_param { | |||
| 98 | PIN_CONFIG_BIAS_PULL_DOWN, | 96 | PIN_CONFIG_BIAS_PULL_DOWN, |
| 99 | PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, | 97 | PIN_CONFIG_BIAS_PULL_PIN_DEFAULT, |
| 100 | PIN_CONFIG_BIAS_PULL_UP, | 98 | PIN_CONFIG_BIAS_PULL_UP, |
| 101 | PIN_CONFIG_BIDIRECTIONAL, | ||
| 102 | PIN_CONFIG_DRIVE_OPEN_DRAIN, | 99 | PIN_CONFIG_DRIVE_OPEN_DRAIN, |
| 103 | PIN_CONFIG_DRIVE_OPEN_SOURCE, | 100 | PIN_CONFIG_DRIVE_OPEN_SOURCE, |
| 104 | PIN_CONFIG_DRIVE_PUSH_PULL, | 101 | PIN_CONFIG_DRIVE_PUSH_PULL, |
