aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHimangi Saraogi <himangi774@gmail.com>2014-06-20 16:38:58 -0400
committerMark Brown <broonie@linaro.org>2014-06-21 16:54:23 -0400
commitb3f6a57506b8c07894549ef3a2aa6bf3b0ba33fd (patch)
tree06e8f17e1bdd70ca694bce5de779603b2a9addf4
parent7171511eaec5bf23fb06078f59784a3a0626b38f (diff)
spi: omap-uwire: use devm_ functions
This patch introduces the use of devm_clk_get and devm_ioremap instead of the unmanaged interfaces and removes the corresponding free function calls. Signed-off-by: Himangi Saraogi <himangi774@gmail.com> Acked-by: Julia Lawall <julia.lawall@lip6.fr> Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r--drivers/spi/spi-omap-uwire.c8
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/spi/spi-omap-uwire.c b/drivers/spi/spi-omap-uwire.c
index 0f5a0aa3b871..cbf67f92ec22 100644
--- a/drivers/spi/spi-omap-uwire.c
+++ b/drivers/spi/spi-omap-uwire.c
@@ -447,7 +447,6 @@ static void uwire_off(struct uwire_spi *uwire)
447{ 447{
448 uwire_write_reg(UWIRE_SR3, 0); 448 uwire_write_reg(UWIRE_SR3, 0);
449 clk_disable(uwire->ck); 449 clk_disable(uwire->ck);
450 clk_put(uwire->ck);
451 spi_master_put(uwire->bitbang.master); 450 spi_master_put(uwire->bitbang.master);
452} 451}
453 452
@@ -463,7 +462,7 @@ static int uwire_probe(struct platform_device *pdev)
463 462
464 uwire = spi_master_get_devdata(master); 463 uwire = spi_master_get_devdata(master);
465 464
466 uwire_base = ioremap(UWIRE_BASE_PHYS, UWIRE_IO_SIZE); 465 uwire_base = devm_ioremap(&pdev->dev, UWIRE_BASE_PHYS, UWIRE_IO_SIZE);
467 if (!uwire_base) { 466 if (!uwire_base) {
468 dev_dbg(&pdev->dev, "can't ioremap UWIRE\n"); 467 dev_dbg(&pdev->dev, "can't ioremap UWIRE\n");
469 spi_master_put(master); 468 spi_master_put(master);
@@ -472,12 +471,11 @@ static int uwire_probe(struct platform_device *pdev)
472 471
473 platform_set_drvdata(pdev, uwire); 472 platform_set_drvdata(pdev, uwire);
474 473
475 uwire->ck = clk_get(&pdev->dev, "fck"); 474 uwire->ck = devm_clk_get(&pdev->dev, "fck");
476 if (IS_ERR(uwire->ck)) { 475 if (IS_ERR(uwire->ck)) {
477 status = PTR_ERR(uwire->ck); 476 status = PTR_ERR(uwire->ck);
478 dev_dbg(&pdev->dev, "no functional clock?\n"); 477 dev_dbg(&pdev->dev, "no functional clock?\n");
479 spi_master_put(master); 478 spi_master_put(master);
480 iounmap(uwire_base);
481 return status; 479 return status;
482 } 480 }
483 clk_enable(uwire->ck); 481 clk_enable(uwire->ck);
@@ -507,7 +505,6 @@ static int uwire_probe(struct platform_device *pdev)
507 status = spi_bitbang_start(&uwire->bitbang); 505 status = spi_bitbang_start(&uwire->bitbang);
508 if (status < 0) { 506 if (status < 0) {
509 uwire_off(uwire); 507 uwire_off(uwire);
510 iounmap(uwire_base);
511 } 508 }
512 return status; 509 return status;
513} 510}
@@ -520,7 +517,6 @@ static int uwire_remove(struct platform_device *pdev)
520 517
521 spi_bitbang_stop(&uwire->bitbang); 518 spi_bitbang_stop(&uwire->bitbang);
522 uwire_off(uwire); 519 uwire_off(uwire);
523 iounmap(uwire_base);
524 return 0; 520 return 0;
525} 521}
526 522