diff options
author | Markus Elfring <elfring@users.sourceforge.net> | 2017-11-22 14:40:47 -0500 |
---|---|---|
committer | Mark Brown <broonie@kernel.org> | 2017-11-27 08:11:21 -0500 |
commit | b28ad41ec831b099dccac1f84a9cfb40b0650724 (patch) | |
tree | d842c1ecefc41b581c8b326b536236d6722fcd34 | |
parent | 410afed04b130fc1c22f82b10b20aed1636d2f15 (diff) |
ASoC: cs35l32: Improve two size determinations in cs35l32_i2c_probe()
Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mark Brown <broonie@kernel.org>
-rw-r--r-- | sound/soc/codecs/cs35l32.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/sound/soc/codecs/cs35l32.c b/sound/soc/codecs/cs35l32.c index e41d8ebe6eea..bc3a72e4c4ed 100644 --- a/sound/soc/codecs/cs35l32.c +++ b/sound/soc/codecs/cs35l32.c | |||
@@ -355,9 +355,7 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client, | |||
355 | unsigned int devid = 0; | 355 | unsigned int devid = 0; |
356 | unsigned int reg; | 356 | unsigned int reg; |
357 | 357 | ||
358 | 358 | cs35l32 = devm_kzalloc(&i2c_client->dev, sizeof(*cs35l32), GFP_KERNEL); | |
359 | cs35l32 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs35l32_private), | ||
360 | GFP_KERNEL); | ||
361 | if (!cs35l32) | 359 | if (!cs35l32) |
362 | return -ENOMEM; | 360 | return -ENOMEM; |
363 | 361 | ||
@@ -373,9 +371,8 @@ static int cs35l32_i2c_probe(struct i2c_client *i2c_client, | |||
373 | if (pdata) { | 371 | if (pdata) { |
374 | cs35l32->pdata = *pdata; | 372 | cs35l32->pdata = *pdata; |
375 | } else { | 373 | } else { |
376 | pdata = devm_kzalloc(&i2c_client->dev, | 374 | pdata = devm_kzalloc(&i2c_client->dev, sizeof(*pdata), |
377 | sizeof(struct cs35l32_platform_data), | 375 | GFP_KERNEL); |
378 | GFP_KERNEL); | ||
379 | if (!pdata) | 376 | if (!pdata) |
380 | return -ENOMEM; | 377 | return -ENOMEM; |
381 | 378 | ||