diff options
| author | Mathieu Malaterre <malat@debian.org> | 2018-05-16 15:20:20 -0400 |
|---|---|---|
| committer | Ulf Hansson <ulf.hansson@linaro.org> | 2018-05-21 04:57:59 -0400 |
| commit | b25b750df99bcba29317d3f9d9f93c4ec58890e6 (patch) | |
| tree | 8c935897ab184a76bea945aaf2c60371f632a8bf | |
| parent | 6da6c0db5316275015e8cc2959f12a17584aeb64 (diff) | |
mmc: block: propagate correct returned value in mmc_rpmb_ioctl
In commit 97548575bef3 ("mmc: block: Convert RPMB to a character device") a
new function `mmc_rpmb_ioctl` was added. The final return is simply
returning a value of `0` instead of propagating the correct return code.
Discovered during a compilation with W=1, silence the following gcc warning
drivers/mmc/core/block.c:2470:6: warning: variable ‘ret’ set but not used
[-Wunused-but-set-variable]
Signed-off-by: Mathieu Malaterre <malat@debian.org>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Fixes: 97548575bef3 ("mmc: block: Convert RPMB to a character device")
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
| -rw-r--r-- | drivers/mmc/core/block.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 9e923cd1d80e..38a7586b00cc 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c | |||
| @@ -2485,7 +2485,7 @@ static long mmc_rpmb_ioctl(struct file *filp, unsigned int cmd, | |||
| 2485 | break; | 2485 | break; |
| 2486 | } | 2486 | } |
| 2487 | 2487 | ||
| 2488 | return 0; | 2488 | return ret; |
| 2489 | } | 2489 | } |
| 2490 | 2490 | ||
| 2491 | #ifdef CONFIG_COMPAT | 2491 | #ifdef CONFIG_COMPAT |