diff options
author | Alexandre Belloni <alexandre.belloni@free-electrons.com> | 2014-05-06 11:44:41 -0400 |
---|---|---|
committer | Mark Brown <broonie@linaro.org> | 2014-05-07 15:50:20 -0400 |
commit | b112f0585edd1c10e4986373d93ab0d95d12da82 (patch) | |
tree | 468579ff0f745525be227eef4bebc4b634b3dad1 | |
parent | 0c3b97487d15a452f1fa7bfd9b6f1bd1a31d538d (diff) |
spi: atmel: fix incorrect comparison
Found using smatch:
drivers/spi/spi-atmel.c:878 atmel_spi_pump_pio_data() warn: unsigned
'as->current_remaining_bytes' is never less than zero.
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: Mark Brown <broonie@linaro.org>
-rw-r--r-- | drivers/spi/spi-atmel.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 485e6cce94bf..e6fe837d49fb 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c | |||
@@ -874,8 +874,9 @@ atmel_spi_pump_pio_data(struct atmel_spi *as, struct spi_transfer *xfer) | |||
874 | spi_readl(as, RDR); | 874 | spi_readl(as, RDR); |
875 | } | 875 | } |
876 | if (xfer->bits_per_word > 8) { | 876 | if (xfer->bits_per_word > 8) { |
877 | as->current_remaining_bytes -= 2; | 877 | if (as->current_remaining_bytes > 2) |
878 | if (as->current_remaining_bytes < 0) | 878 | as->current_remaining_bytes -= 2; |
879 | else | ||
879 | as->current_remaining_bytes = 0; | 880 | as->current_remaining_bytes = 0; |
880 | } else { | 881 | } else { |
881 | as->current_remaining_bytes--; | 882 | as->current_remaining_bytes--; |