diff options
author | Michael Walle <michael@walle.cc> | 2016-11-15 05:13:16 -0500 |
---|---|---|
committer | Ulf Hansson <ulf.hansson@linaro.org> | 2016-11-18 08:41:47 -0500 |
commit | b0921d5c9ed6ffa8a4d6afc5ee5f136b87445f14 (patch) | |
tree | f9566c3945231eea57649951897b82d461c0db4d | |
parent | a25f0944ba9b1d8a6813fd6f1a86f1bd59ac25a6 (diff) |
mmc: sdhci-of-esdhc: fixup PRESENT_STATE read
Since commit 87a18a6a5652 ("mmc: mmc: Use ->card_busy() to detect busy
cards in __mmc_switch()") the ESDHC driver is broken:
mmc0: Card stuck in programming state! __mmc_switch
mmc0: error -110 whilst initialising MMC card
Since this commit __mmc_switch() uses ->card_busy(), which is
sdhci_card_busy() for the esdhc driver. sdhci_card_busy() uses the
PRESENT_STATE register, specifically the DAT0 signal level bit. But the
ESDHC uses a non-conformant PRESENT_STATE register, thus a read fixup is
required to make the driver work again.
Signed-off-by: Michael Walle <michael@walle.cc>
Fixes: 87a18a6a5652 ("mmc: mmc: Use ->card_busy() to detect busy cards in __mmc_switch()")
Acked-by: Yangbo Lu <yangbo.lu@nxp.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: <stable@vger.kernel.org> # v4.8+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
-rw-r--r-- | drivers/mmc/host/sdhci-of-esdhc.c | 14 | ||||
-rw-r--r-- | drivers/mmc/host/sdhci.h | 1 |
2 files changed, 15 insertions, 0 deletions
diff --git a/drivers/mmc/host/sdhci-of-esdhc.c b/drivers/mmc/host/sdhci-of-esdhc.c index fb71c866eacc..1bb11e4a9fe5 100644 --- a/drivers/mmc/host/sdhci-of-esdhc.c +++ b/drivers/mmc/host/sdhci-of-esdhc.c | |||
@@ -66,6 +66,20 @@ static u32 esdhc_readl_fixup(struct sdhci_host *host, | |||
66 | return ret; | 66 | return ret; |
67 | } | 67 | } |
68 | } | 68 | } |
69 | /* | ||
70 | * The DAT[3:0] line signal levels and the CMD line signal level are | ||
71 | * not compatible with standard SDHC register. The line signal levels | ||
72 | * DAT[7:0] are at bits 31:24 and the command line signal level is at | ||
73 | * bit 23. All other bits are the same as in the standard SDHC | ||
74 | * register. | ||
75 | */ | ||
76 | if (spec_reg == SDHCI_PRESENT_STATE) { | ||
77 | ret = value & 0x000fffff; | ||
78 | ret |= (value >> 4) & SDHCI_DATA_LVL_MASK; | ||
79 | ret |= (value << 1) & SDHCI_CMD_LVL; | ||
80 | return ret; | ||
81 | } | ||
82 | |||
69 | ret = value; | 83 | ret = value; |
70 | return ret; | 84 | return ret; |
71 | } | 85 | } |
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h index 766df17fb7eb..2570455b219a 100644 --- a/drivers/mmc/host/sdhci.h +++ b/drivers/mmc/host/sdhci.h | |||
@@ -73,6 +73,7 @@ | |||
73 | #define SDHCI_DATA_LVL_MASK 0x00F00000 | 73 | #define SDHCI_DATA_LVL_MASK 0x00F00000 |
74 | #define SDHCI_DATA_LVL_SHIFT 20 | 74 | #define SDHCI_DATA_LVL_SHIFT 20 |
75 | #define SDHCI_DATA_0_LVL_MASK 0x00100000 | 75 | #define SDHCI_DATA_0_LVL_MASK 0x00100000 |
76 | #define SDHCI_CMD_LVL 0x01000000 | ||
76 | 77 | ||
77 | #define SDHCI_HOST_CONTROL 0x28 | 78 | #define SDHCI_HOST_CONTROL 0x28 |
78 | #define SDHCI_CTRL_LED 0x01 | 79 | #define SDHCI_CTRL_LED 0x01 |