aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRex Zhu <Rex.Zhu@amd.com>2017-09-20 07:28:29 -0400
committerAlex Deucher <alexander.deucher@amd.com>2017-09-26 15:14:29 -0400
commitb05720cbf6458450700d1c3e91d2b2620b4f6295 (patch)
tree4aa7415095f715c02ddcc15e4bef7a797e8c1ca7
parentd92cb1629bcc8cdf4d616f144ced399723816ba3 (diff)
drm/amd/powerplay: move SMUM_WAIT_INDIRECT_FIELD_UNEQUAL to hwmgr.h
the macro is not relevent to SMU, so move to hwmgr.h and rename to PHM_WAIT_INDIRECT_FIELD_UNEQUAL Reviewed-by: Alex Deucher <alexander.deucher@amd.com> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
-rw-r--r--drivers/gpu/drm/amd/powerplay/inc/hwmgr.h13
-rw-r--r--drivers/gpu/drm/amd/powerplay/inc/smumgr.h11
-rw-r--r--drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c2
-rw-r--r--drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c2
4 files changed, 16 insertions, 12 deletions
diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
index 1c605f966b5f..277d2604e32e 100644
--- a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
+++ b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h
@@ -889,4 +889,17 @@ extern int phm_get_voltage_evv_on_sclk(struct pp_hwmgr *hwmgr, uint8_t voltage_t
889 PHM_WAIT_INDIRECT_REGISTER(hwmgr, port, reg, (fieldval) \ 889 PHM_WAIT_INDIRECT_REGISTER(hwmgr, port, reg, (fieldval) \
890 << PHM_FIELD_SHIFT(reg, field), PHM_FIELD_MASK(reg, field)) 890 << PHM_FIELD_SHIFT(reg, field), PHM_FIELD_MASK(reg, field))
891 891
892#define PHM_WAIT_INDIRECT_REGISTER_UNEQUAL_GIVEN_INDEX(hwmgr, port, index, value, mask) \
893 phm_wait_for_indirect_register_unequal(hwmgr, \
894 mm##port##_INDEX, index, value, mask)
895
896#define PHM_WAIT_INDIRECT_REGISTER_UNEQUAL(hwmgr, port, reg, value, mask) \
897 PHM_WAIT_INDIRECT_REGISTER_UNEQUAL_GIVEN_INDEX(hwmgr, port, ix##reg, value, mask)
898
899#define PHM_WAIT_INDIRECT_FIELD_UNEQUAL(hwmgr, port, reg, field, fieldval) \
900 PHM_WAIT_INDIRECT_REGISTER_UNEQUAL(hwmgr, port, reg, \
901 (fieldval) << PHM_FIELD_SHIFT(reg, field), \
902 PHM_FIELD_MASK(reg, field) )
903
904
892#endif /* _HWMGR_H_ */ 905#endif /* _HWMGR_H_ */
diff --git a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h b/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
index 54b151b03aa8..c64abd57f908 100644
--- a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
+++ b/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
@@ -117,6 +117,7 @@ extern void smum_wait_for_indirect_register_unequal(
117 uint32_t indirect_port, uint32_t index, 117 uint32_t indirect_port, uint32_t index,
118 uint32_t value, uint32_t mask); 118 uint32_t value, uint32_t mask);
119 119
120
120extern int smu_allocate_memory(void *device, uint32_t size, 121extern int smu_allocate_memory(void *device, uint32_t size,
121 enum cgs_gpu_mem_type type, 122 enum cgs_gpu_mem_type type,
122 uint32_t byte_align, uint64_t *mc_addr, 123 uint32_t byte_align, uint64_t *mc_addr,
@@ -242,15 +243,5 @@ extern bool smum_is_hw_avfs_present(struct pp_hwmgr *hwmgr);
242 (fieldval) << SMUM_FIELD_SHIFT(reg, field), \ 243 (fieldval) << SMUM_FIELD_SHIFT(reg, field), \
243 SMUM_FIELD_MASK(reg, field)) 244 SMUM_FIELD_MASK(reg, field))
244 245
245#define SMUM_WAIT_INDIRECT_REGISTER_UNEQUAL_GIVEN_INDEX(hwmgr, port, index, value, mask) \
246 smum_wait_for_indirect_register_unequal(hwmgr, \
247 mm##port##_INDEX, index, value, mask)
248
249#define SMUM_WAIT_INDIRECT_REGISTER_UNEQUAL(hwmgr, port, reg, value, mask) \
250 SMUM_WAIT_INDIRECT_REGISTER_UNEQUAL_GIVEN_INDEX(hwmgr, port, ix##reg, value, mask)
251
252#define SMUM_WAIT_INDIRECT_FIELD_UNEQUAL(hwmgr, port, reg, field, fieldval) \
253 SMUM_WAIT_INDIRECT_REGISTER_UNEQUAL(hwmgr, port, reg, (fieldval) << SMUM_FIELD_SHIFT(reg, field), \
254 SMUM_FIELD_MASK(reg, field) )
255 246
256#endif 247#endif
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c
index eafac957b0f6..d40f4a3d5e28 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/fiji_smumgr.c
@@ -63,7 +63,7 @@ static int fiji_start_smu_in_protection_mode(struct pp_hwmgr *hwmgr)
63 int result = 0; 63 int result = 0;
64 64
65 /* Wait for smc boot up */ 65 /* Wait for smc boot up */
66 /* SMUM_WAIT_INDIRECT_FIELD_UNEQUAL(hwmgr, SMC_IND, 66 /* PHM_WAIT_INDIRECT_FIELD_UNEQUAL(hwmgr, SMC_IND,
67 RCU_UC_EVENTS, boot_seq_done, 0); */ 67 RCU_UC_EVENTS, boot_seq_done, 0); */
68 68
69 SMUM_WRITE_VFPF_INDIRECT_FIELD(hwmgr->device, CGS_IND_REG__SMC, 69 SMUM_WRITE_VFPF_INDIRECT_FIELD(hwmgr->device, CGS_IND_REG__SMC,
diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c
index fd63d2800d05..3a134eae5292 100644
--- a/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/iceland_smumgr.c
@@ -137,7 +137,7 @@ static int iceland_smu_upload_firmware_image(struct pp_hwmgr *hwmgr)
137 } 137 }
138 138
139 /* wait for smc boot up */ 139 /* wait for smc boot up */
140 SMUM_WAIT_INDIRECT_FIELD_UNEQUAL(hwmgr, SMC_IND, 140 PHM_WAIT_INDIRECT_FIELD_UNEQUAL(hwmgr, SMC_IND,
141 RCU_UC_EVENTS, boot_seq_done, 0); 141 RCU_UC_EVENTS, boot_seq_done, 0);
142 142
143 /* clear firmware interrupt enable flag */ 143 /* clear firmware interrupt enable flag */