aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2015-05-14 04:32:56 -0400
committerJiri Kosina <jkosina@suse.cz>2015-05-18 05:22:53 -0400
commitaf43c4086cf24c3eb74a968195351163750c82b6 (patch)
tree04b01b156f190db2f87cb3656c1e1edde633818f
parentd0091f5749eadfce87ce0436994584637a353e2c (diff)
HID: rmi: fix some harmless BIT() mistakes
These defines are used like this: if (!(test_bit(RMI_STARTED, &hdata->flags))) So the intent was to use bits 0, 1 and 2 but because of the extra BIT() shifts we're actually using 1, 2 and 4. It's harmless because it's done consistently but static checkers will complain. Fixes: 9fb6bf02e3ad ('HID: rmi: introduce RMI driver for Synaptics touchpads') Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/hid-rmi.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/hid/hid-rmi.c b/drivers/hid/hid-rmi.c
index 368ffdf2c0a3..2f3e51d45f0c 100644
--- a/drivers/hid/hid-rmi.c
+++ b/drivers/hid/hid-rmi.c
@@ -29,9 +29,9 @@
29#define RMI_SET_RMI_MODE_REPORT_ID 0x0f /* Feature Report */ 29#define RMI_SET_RMI_MODE_REPORT_ID 0x0f /* Feature Report */
30 30
31/* flags */ 31/* flags */
32#define RMI_READ_REQUEST_PENDING BIT(0) 32#define RMI_READ_REQUEST_PENDING 0
33#define RMI_READ_DATA_PENDING BIT(1) 33#define RMI_READ_DATA_PENDING 1
34#define RMI_STARTED BIT(2) 34#define RMI_STARTED 2
35 35
36/* device flags */ 36/* device flags */
37#define RMI_DEVICE BIT(0) 37#define RMI_DEVICE BIT(0)