diff options
author | Jiri Olsa <jolsa@kernel.org> | 2016-10-11 07:52:05 -0400 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2016-10-21 09:32:02 -0400 |
commit | af09b2d35e18f1a377aaa2bc4e5ba4abb98a1088 (patch) | |
tree | 9fa3b9926f9c0b4f93495706c357221b533b213f | |
parent | 18f278d2dd68fdccf8810e78d10d6b75a6f2f67a (diff) |
perf c2c report: Add --show-all option
Normally we limit the main list to contain only entries with HITM %
value > 0.0005, but it might be useful to display all captured entries.
Adding --show-all option for that.
Requested-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Joe Mario <jmario@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-nokgjdwikbegec5jzj4mxhqc@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/Documentation/perf-c2c.txt | 3 | ||||
-rw-r--r-- | tools/perf/builtin-c2c.c | 7 |
2 files changed, 8 insertions, 2 deletions
diff --git a/tools/perf/Documentation/perf-c2c.txt b/tools/perf/Documentation/perf-c2c.txt index 33ed4564a8c0..21810d711f5f 100644 --- a/tools/perf/Documentation/perf-c2c.txt +++ b/tools/perf/Documentation/perf-c2c.txt | |||
@@ -97,6 +97,9 @@ REPORT OPTIONS | |||
97 | --no-source:: | 97 | --no-source:: |
98 | Do not display Source:Line column. | 98 | Do not display Source:Line column. |
99 | 99 | ||
100 | --show-all:: | ||
101 | Show all captured HITM lines, with no regard to HITM % 0.0005 limit. | ||
102 | |||
100 | C2C RECORD | 103 | C2C RECORD |
101 | ---------- | 104 | ---------- |
102 | The perf c2c record command setup options related to HITM cacheline analysis | 105 | The perf c2c record command setup options related to HITM cacheline analysis |
diff --git a/tools/perf/builtin-c2c.c b/tools/perf/builtin-c2c.c index 7eb418d3af04..c6d0dda594d9 100644 --- a/tools/perf/builtin-c2c.c +++ b/tools/perf/builtin-c2c.c | |||
@@ -71,6 +71,7 @@ struct perf_c2c { | |||
71 | int node_info; | 71 | int node_info; |
72 | 72 | ||
73 | bool show_src; | 73 | bool show_src; |
74 | bool show_all; | ||
74 | bool use_stdio; | 75 | bool use_stdio; |
75 | bool stats_only; | 76 | bool stats_only; |
76 | bool symbol_full; | 77 | bool symbol_full; |
@@ -1773,8 +1774,8 @@ static bool he__display(struct hist_entry *he, struct c2c_stats *stats) | |||
1773 | struct c2c_hist_entry *c2c_he; | 1774 | struct c2c_hist_entry *c2c_he; |
1774 | double ld_dist; | 1775 | double ld_dist; |
1775 | 1776 | ||
1776 | /* XXX Disabled for now, till we get a command line switch to control this */ | 1777 | if (c2c.show_all) |
1777 | return true; | 1778 | return true; |
1778 | 1779 | ||
1779 | c2c_he = container_of(he, struct c2c_hist_entry, he); | 1780 | c2c_he = container_of(he, struct c2c_hist_entry, he); |
1780 | 1781 | ||
@@ -2513,6 +2514,8 @@ static int perf_c2c__report(int argc, const char **argv) | |||
2513 | "Display full length of symbols"), | 2514 | "Display full length of symbols"), |
2514 | OPT_BOOLEAN(0, "no-source", &no_source, | 2515 | OPT_BOOLEAN(0, "no-source", &no_source, |
2515 | "Do not display Source Line column"), | 2516 | "Do not display Source Line column"), |
2517 | OPT_BOOLEAN(0, "show-all", &c2c.show_all, | ||
2518 | "Show all captured HITM lines."), | ||
2516 | OPT_CALLBACK_DEFAULT('g', "call-graph", &callchain_param, | 2519 | OPT_CALLBACK_DEFAULT('g', "call-graph", &callchain_param, |
2517 | "print_type,threshold[,print_limit],order,sort_key[,branch],value", | 2520 | "print_type,threshold[,print_limit],order,sort_key[,branch],value", |
2518 | callchain_help, &parse_callchain_opt, | 2521 | callchain_help, &parse_callchain_opt, |