diff options
author | Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> | 2017-05-29 02:52:23 -0400 |
---|---|---|
committer | Dmitry Torokhov <dmitry.torokhov@gmail.com> | 2017-06-09 12:56:06 -0400 |
commit | ad2ee015245dfe22743a25d7245b3d6abd33c02e (patch) | |
tree | 597768b37d34a86be081fca82f6097a67275d8a2 | |
parent | d4c9354b4015aa8d1b032c368682dd20a00f4e1f (diff) |
Input: xen-kbdfront - use string constants from PV protocol
Xen input para-virtual protocol defines string constants
used by both back and frontend. Use those instead of
explicit strings in the frontend driver.
Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r-- | drivers/input/misc/xen-kbdfront.c | 22 |
1 files changed, 13 insertions, 9 deletions
diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c index 690148f9940e..eb770613a9bd 100644 --- a/drivers/input/misc/xen-kbdfront.c +++ b/drivers/input/misc/xen-kbdfront.c | |||
@@ -135,14 +135,17 @@ static int xenkbd_probe(struct xenbus_device *dev, | |||
135 | goto error_nomem; | 135 | goto error_nomem; |
136 | 136 | ||
137 | /* Set input abs params to match backend screen res */ | 137 | /* Set input abs params to match backend screen res */ |
138 | abs = xenbus_read_unsigned(dev->otherend, "feature-abs-pointer", 0); | 138 | abs = xenbus_read_unsigned(dev->otherend, |
139 | ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend, "width", | 139 | XENKBD_FIELD_FEAT_ABS_POINTER, 0); |
140 | ptr_size[KPARAM_X] = xenbus_read_unsigned(dev->otherend, | ||
141 | XENKBD_FIELD_WIDTH, | ||
140 | ptr_size[KPARAM_X]); | 142 | ptr_size[KPARAM_X]); |
141 | ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend, "height", | 143 | ptr_size[KPARAM_Y] = xenbus_read_unsigned(dev->otherend, |
144 | XENKBD_FIELD_HEIGHT, | ||
142 | ptr_size[KPARAM_Y]); | 145 | ptr_size[KPARAM_Y]); |
143 | if (abs) { | 146 | if (abs) { |
144 | ret = xenbus_write(XBT_NIL, dev->nodename, | 147 | ret = xenbus_write(XBT_NIL, dev->nodename, |
145 | "request-abs-pointer", "1"); | 148 | XENKBD_FIELD_REQ_ABS_POINTER, "1"); |
146 | if (ret) { | 149 | if (ret) { |
147 | pr_warn("xenkbd: can't request abs-pointer\n"); | 150 | pr_warn("xenkbd: can't request abs-pointer\n"); |
148 | abs = 0; | 151 | abs = 0; |
@@ -271,14 +274,15 @@ static int xenkbd_connect_backend(struct xenbus_device *dev, | |||
271 | xenbus_dev_fatal(dev, ret, "starting transaction"); | 274 | xenbus_dev_fatal(dev, ret, "starting transaction"); |
272 | goto error_irqh; | 275 | goto error_irqh; |
273 | } | 276 | } |
274 | ret = xenbus_printf(xbt, dev->nodename, "page-ref", "%lu", | 277 | ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_RING_REF, "%lu", |
275 | virt_to_gfn(info->page)); | 278 | virt_to_gfn(info->page)); |
276 | if (ret) | 279 | if (ret) |
277 | goto error_xenbus; | 280 | goto error_xenbus; |
278 | ret = xenbus_printf(xbt, dev->nodename, "page-gref", "%u", info->gref); | 281 | ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_RING_GREF, |
282 | "%u", info->gref); | ||
279 | if (ret) | 283 | if (ret) |
280 | goto error_xenbus; | 284 | goto error_xenbus; |
281 | ret = xenbus_printf(xbt, dev->nodename, "event-channel", "%u", | 285 | ret = xenbus_printf(xbt, dev->nodename, XENKBD_FIELD_EVT_CHANNEL, "%u", |
282 | evtchn); | 286 | evtchn); |
283 | if (ret) | 287 | if (ret) |
284 | goto error_xenbus; | 288 | goto error_xenbus; |
@@ -353,7 +357,7 @@ static void xenkbd_backend_changed(struct xenbus_device *dev, | |||
353 | } | 357 | } |
354 | 358 | ||
355 | static const struct xenbus_device_id xenkbd_ids[] = { | 359 | static const struct xenbus_device_id xenkbd_ids[] = { |
356 | { "vkbd" }, | 360 | { XENKBD_DRIVER_NAME }, |
357 | { "" } | 361 | { "" } |
358 | }; | 362 | }; |
359 | 363 | ||
@@ -390,4 +394,4 @@ module_exit(xenkbd_cleanup); | |||
390 | 394 | ||
391 | MODULE_DESCRIPTION("Xen virtual keyboard/pointer device frontend"); | 395 | MODULE_DESCRIPTION("Xen virtual keyboard/pointer device frontend"); |
392 | MODULE_LICENSE("GPL"); | 396 | MODULE_LICENSE("GPL"); |
393 | MODULE_ALIAS("xen:vkbd"); | 397 | MODULE_ALIAS("xen:" XENKBD_DRIVER_NAME); |