diff options
author | Paul Kocialkowski <paul.kocialkowski@bootlin.com> | 2018-11-23 04:24:35 -0500 |
---|---|---|
committer | Maxime Ripard <maxime.ripard@bootlin.com> | 2018-11-27 03:30:59 -0500 |
commit | ad25d0736db00afb2c7bf355bc50437434325387 (patch) | |
tree | 2272692c611abd1f51b0554d6615ae109bb49698 | |
parent | b79a3a97f64f90dac79a9fc57a0280607306ba38 (diff) |
drm/sun4i: Add TODO comment about supporting scaling with the backend
The backend allows integer-only scaling but can handle alpha components,
unlike the frontend. It could be useful to add support for this
eventually, so add a short TODO comment describing the situation.
Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20181123092515.2511-4-paul.kocialkowski@bootlin.com
-rw-r--r-- | drivers/gpu/drm/sun4i/sun4i_backend.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/gpu/drm/sun4i/sun4i_backend.c b/drivers/gpu/drm/sun4i/sun4i_backend.c index 67b4bb4f5365..c3444246755b 100644 --- a/drivers/gpu/drm/sun4i/sun4i_backend.c +++ b/drivers/gpu/drm/sun4i/sun4i_backend.c | |||
@@ -426,6 +426,11 @@ static bool sun4i_backend_plane_uses_frontend(struct drm_plane_state *state) | |||
426 | if (IS_ERR(backend->frontend)) | 426 | if (IS_ERR(backend->frontend)) |
427 | return false; | 427 | return false; |
428 | 428 | ||
429 | /* | ||
430 | * TODO: The backend alone allows 2x and 4x integer scaling, including | ||
431 | * support for an alpha component (which the frontend doesn't support). | ||
432 | * Use the backend directly instead of the frontend in this case. | ||
433 | */ | ||
429 | return sun4i_backend_plane_uses_scaler(state); | 434 | return sun4i_backend_plane_uses_scaler(state); |
430 | } | 435 | } |
431 | 436 | ||