aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSagar Arun Kamble <sagar.a.kamble@intel.com>2017-10-10 17:30:04 -0400
committerChris Wilson <chris@chris-wilson.co.uk>2017-10-11 03:56:54 -0400
commitad1443f0f3dd1b2434af897af8b8f942e47cf8c3 (patch)
treeba2228d1f312abecc69440b1d8c9fbbf81b5beb3
parentd46b00dc38c8aea80357a0dd04f57c097dbfa5b9 (diff)
drm/i915: Name i915_runtime_pm structure in dev_priv as "runtime_pm"
We were using dev_priv->pm for runtime power management related state. This patch renames it to "runtime_pm" which looks more apt. v2: s/rpm/runtime_pm (Chris) Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com> Cc: Imre Deak <imre.deak@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Reviewed-by: Radoslaw Szwichtenberg <radoslaw.szwichtenberg@intel.com> #1 Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/1507360055-19948-7-git-send-email-sagar.a.kamble@intel.com Acked-by: Imre Deak <imre.deak@intel.com> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20171010213010.7415-6-chris@chris-wilson.co.uk
-rw-r--r--drivers/gpu/drm/i915/i915_drv.c8
-rw-r--r--drivers/gpu/drm/i915/i915_drv.h2
-rw-r--r--drivers/gpu/drm/i915/i915_gpu_error.c4
-rw-r--r--drivers/gpu/drm/i915/i915_irq.c8
-rw-r--r--drivers/gpu/drm/i915/intel_drv.h10
-rw-r--r--drivers/gpu/drm/i915/intel_pm.c4
-rw-r--r--drivers/gpu/drm/i915/intel_runtime_pm.c10
7 files changed, 23 insertions, 23 deletions
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 66fc156b294a..9ebbb08dcf2d 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -2544,12 +2544,12 @@ static int intel_runtime_suspend(struct device *kdev)
2544 intel_uncore_suspend(dev_priv); 2544 intel_uncore_suspend(dev_priv);
2545 2545
2546 enable_rpm_wakeref_asserts(dev_priv); 2546 enable_rpm_wakeref_asserts(dev_priv);
2547 WARN_ON_ONCE(atomic_read(&dev_priv->pm.wakeref_count)); 2547 WARN_ON_ONCE(atomic_read(&dev_priv->runtime_pm.wakeref_count));
2548 2548
2549 if (intel_uncore_arm_unclaimed_mmio_detection(dev_priv)) 2549 if (intel_uncore_arm_unclaimed_mmio_detection(dev_priv))
2550 DRM_ERROR("Unclaimed access detected prior to suspending\n"); 2550 DRM_ERROR("Unclaimed access detected prior to suspending\n");
2551 2551
2552 dev_priv->pm.suspended = true; 2552 dev_priv->runtime_pm.suspended = true;
2553 2553
2554 /* 2554 /*
2555 * FIXME: We really should find a document that references the arguments 2555 * FIXME: We really should find a document that references the arguments
@@ -2595,11 +2595,11 @@ static int intel_runtime_resume(struct device *kdev)
2595 2595
2596 DRM_DEBUG_KMS("Resuming device\n"); 2596 DRM_DEBUG_KMS("Resuming device\n");
2597 2597
2598 WARN_ON_ONCE(atomic_read(&dev_priv->pm.wakeref_count)); 2598 WARN_ON_ONCE(atomic_read(&dev_priv->runtime_pm.wakeref_count));
2599 disable_rpm_wakeref_asserts(dev_priv); 2599 disable_rpm_wakeref_asserts(dev_priv);
2600 2600
2601 intel_opregion_notify_adapter(dev_priv, PCI_D0); 2601 intel_opregion_notify_adapter(dev_priv, PCI_D0);
2602 dev_priv->pm.suspended = false; 2602 dev_priv->runtime_pm.suspended = false;
2603 if (intel_uncore_unclaimed_mmio(dev_priv)) 2603 if (intel_uncore_unclaimed_mmio(dev_priv))
2604 DRM_DEBUG_DRIVER("Unclaimed access during suspend, bios?\n"); 2604 DRM_DEBUG_DRIVER("Unclaimed access during suspend, bios?\n");
2605 2605
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 770305bdeabb..f44027f6e5e1 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers/gpu/drm/i915/i915_drv.h
@@ -2533,7 +2533,7 @@ struct drm_i915_private {
2533 bool distrust_bios_wm; 2533 bool distrust_bios_wm;
2534 } wm; 2534 } wm;
2535 2535
2536 struct i915_runtime_pm pm; 2536 struct i915_runtime_pm runtime_pm;
2537 2537
2538 struct { 2538 struct {
2539 bool initialized; 2539 bool initialized;
diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
index dc91b32d699e..653fb69e7ecb 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -1674,8 +1674,8 @@ static void i915_capture_gen_state(struct drm_i915_private *dev_priv,
1674 struct i915_gpu_state *error) 1674 struct i915_gpu_state *error)
1675{ 1675{
1676 error->awake = dev_priv->gt.awake; 1676 error->awake = dev_priv->gt.awake;
1677 error->wakelock = atomic_read(&dev_priv->pm.wakeref_count); 1677 error->wakelock = atomic_read(&dev_priv->runtime_pm.wakeref_count);
1678 error->suspended = dev_priv->pm.suspended; 1678 error->suspended = dev_priv->runtime_pm.suspended;
1679 1679
1680 error->iommu = -1; 1680 error->iommu = -1;
1681#ifdef CONFIG_INTEL_IOMMU 1681#ifdef CONFIG_INTEL_IOMMU
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 3736290f2d0c..915c5b9dc547 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -4173,7 +4173,7 @@ int intel_irq_install(struct drm_i915_private *dev_priv)
4173 * interrupts as enabled _before_ actually enabling them to avoid 4173 * interrupts as enabled _before_ actually enabling them to avoid
4174 * special cases in our ordering checks. 4174 * special cases in our ordering checks.
4175 */ 4175 */
4176 dev_priv->pm.irqs_enabled = true; 4176 dev_priv->runtime_pm.irqs_enabled = true;
4177 4177
4178 return drm_irq_install(&dev_priv->drm, dev_priv->drm.pdev->irq); 4178 return drm_irq_install(&dev_priv->drm, dev_priv->drm.pdev->irq);
4179} 4179}
@@ -4189,7 +4189,7 @@ void intel_irq_uninstall(struct drm_i915_private *dev_priv)
4189{ 4189{
4190 drm_irq_uninstall(&dev_priv->drm); 4190 drm_irq_uninstall(&dev_priv->drm);
4191 intel_hpd_cancel_work(dev_priv); 4191 intel_hpd_cancel_work(dev_priv);
4192 dev_priv->pm.irqs_enabled = false; 4192 dev_priv->runtime_pm.irqs_enabled = false;
4193} 4193}
4194 4194
4195/** 4195/**
@@ -4202,7 +4202,7 @@ void intel_irq_uninstall(struct drm_i915_private *dev_priv)
4202void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv) 4202void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv)
4203{ 4203{
4204 dev_priv->drm.driver->irq_uninstall(&dev_priv->drm); 4204 dev_priv->drm.driver->irq_uninstall(&dev_priv->drm);
4205 dev_priv->pm.irqs_enabled = false; 4205 dev_priv->runtime_pm.irqs_enabled = false;
4206 synchronize_irq(dev_priv->drm.irq); 4206 synchronize_irq(dev_priv->drm.irq);
4207} 4207}
4208 4208
@@ -4215,7 +4215,7 @@ void intel_runtime_pm_disable_interrupts(struct drm_i915_private *dev_priv)
4215 */ 4215 */
4216void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv) 4216void intel_runtime_pm_enable_interrupts(struct drm_i915_private *dev_priv)
4217{ 4217{
4218 dev_priv->pm.irqs_enabled = true; 4218 dev_priv->runtime_pm.irqs_enabled = true;
4219 dev_priv->drm.driver->irq_preinstall(&dev_priv->drm); 4219 dev_priv->drm.driver->irq_preinstall(&dev_priv->drm);
4220 dev_priv->drm.driver->irq_postinstall(&dev_priv->drm); 4220 dev_priv->drm.driver->irq_postinstall(&dev_priv->drm);
4221} 4221}
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index ceb3b8284c86..3fd428b99c37 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/gpu/drm/i915/intel_drv.h
@@ -1254,7 +1254,7 @@ static inline bool intel_irqs_enabled(struct drm_i915_private *dev_priv)
1254 * We only use drm_irq_uninstall() at unload and VT switch, so 1254 * We only use drm_irq_uninstall() at unload and VT switch, so
1255 * this is the only thing we need to check. 1255 * this is the only thing we need to check.
1256 */ 1256 */
1257 return dev_priv->pm.irqs_enabled; 1257 return dev_priv->runtime_pm.irqs_enabled;
1258} 1258}
1259 1259
1260int intel_get_crtc_scanline(struct intel_crtc *crtc); 1260int intel_get_crtc_scanline(struct intel_crtc *crtc);
@@ -1790,7 +1790,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
1790static inline void 1790static inline void
1791assert_rpm_device_not_suspended(struct drm_i915_private *dev_priv) 1791assert_rpm_device_not_suspended(struct drm_i915_private *dev_priv)
1792{ 1792{
1793 WARN_ONCE(dev_priv->pm.suspended, 1793 WARN_ONCE(dev_priv->runtime_pm.suspended,
1794 "Device suspended during HW access\n"); 1794 "Device suspended during HW access\n");
1795} 1795}
1796 1796
@@ -1798,7 +1798,7 @@ static inline void
1798assert_rpm_wakelock_held(struct drm_i915_private *dev_priv) 1798assert_rpm_wakelock_held(struct drm_i915_private *dev_priv)
1799{ 1799{
1800 assert_rpm_device_not_suspended(dev_priv); 1800 assert_rpm_device_not_suspended(dev_priv);
1801 WARN_ONCE(!atomic_read(&dev_priv->pm.wakeref_count), 1801 WARN_ONCE(!atomic_read(&dev_priv->runtime_pm.wakeref_count),
1802 "RPM wakelock ref not held during HW access"); 1802 "RPM wakelock ref not held during HW access");
1803} 1803}
1804 1804
@@ -1823,7 +1823,7 @@ assert_rpm_wakelock_held(struct drm_i915_private *dev_priv)
1823static inline void 1823static inline void
1824disable_rpm_wakeref_asserts(struct drm_i915_private *dev_priv) 1824disable_rpm_wakeref_asserts(struct drm_i915_private *dev_priv)
1825{ 1825{
1826 atomic_inc(&dev_priv->pm.wakeref_count); 1826 atomic_inc(&dev_priv->runtime_pm.wakeref_count);
1827} 1827}
1828 1828
1829/** 1829/**
@@ -1840,7 +1840,7 @@ disable_rpm_wakeref_asserts(struct drm_i915_private *dev_priv)
1840static inline void 1840static inline void
1841enable_rpm_wakeref_asserts(struct drm_i915_private *dev_priv) 1841enable_rpm_wakeref_asserts(struct drm_i915_private *dev_priv)
1842{ 1842{
1843 atomic_dec(&dev_priv->pm.wakeref_count); 1843 atomic_dec(&dev_priv->runtime_pm.wakeref_count);
1844} 1844}
1845 1845
1846void intel_runtime_pm_get(struct drm_i915_private *dev_priv); 1846void intel_runtime_pm_get(struct drm_i915_private *dev_priv);
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 4843e88a7f35..831054084fb7 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -9350,8 +9350,8 @@ void intel_pm_setup(struct drm_i915_private *dev_priv)
9350 __intel_autoenable_gt_powersave); 9350 __intel_autoenable_gt_powersave);
9351 atomic_set(&dev_priv->rps.num_waiters, 0); 9351 atomic_set(&dev_priv->rps.num_waiters, 0);
9352 9352
9353 dev_priv->pm.suspended = false; 9353 dev_priv->runtime_pm.suspended = false;
9354 atomic_set(&dev_priv->pm.wakeref_count, 0); 9354 atomic_set(&dev_priv->runtime_pm.wakeref_count, 0);
9355} 9355}
9356 9356
9357static u64 vlv_residency_raw(struct drm_i915_private *dev_priv, 9357static u64 vlv_residency_raw(struct drm_i915_private *dev_priv,
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index c4e1aba83c3e..7348c16c4a96 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -187,7 +187,7 @@ bool __intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
187 struct i915_power_well *power_well; 187 struct i915_power_well *power_well;
188 bool is_enabled; 188 bool is_enabled;
189 189
190 if (dev_priv->pm.suspended) 190 if (dev_priv->runtime_pm.suspended)
191 return false; 191 return false;
192 192
193 is_enabled = true; 193 is_enabled = true;
@@ -3128,7 +3128,7 @@ void intel_runtime_pm_get(struct drm_i915_private *dev_priv)
3128 ret = pm_runtime_get_sync(kdev); 3128 ret = pm_runtime_get_sync(kdev);
3129 WARN_ONCE(ret < 0, "pm_runtime_get_sync() failed: %d\n", ret); 3129 WARN_ONCE(ret < 0, "pm_runtime_get_sync() failed: %d\n", ret);
3130 3130
3131 atomic_inc(&dev_priv->pm.wakeref_count); 3131 atomic_inc(&dev_priv->runtime_pm.wakeref_count);
3132 assert_rpm_wakelock_held(dev_priv); 3132 assert_rpm_wakelock_held(dev_priv);
3133} 3133}
3134 3134
@@ -3162,7 +3162,7 @@ bool intel_runtime_pm_get_if_in_use(struct drm_i915_private *dev_priv)
3162 return false; 3162 return false;
3163 } 3163 }
3164 3164
3165 atomic_inc(&dev_priv->pm.wakeref_count); 3165 atomic_inc(&dev_priv->runtime_pm.wakeref_count);
3166 assert_rpm_wakelock_held(dev_priv); 3166 assert_rpm_wakelock_held(dev_priv);
3167 3167
3168 return true; 3168 return true;
@@ -3193,7 +3193,7 @@ void intel_runtime_pm_get_noresume(struct drm_i915_private *dev_priv)
3193 assert_rpm_wakelock_held(dev_priv); 3193 assert_rpm_wakelock_held(dev_priv);
3194 pm_runtime_get_noresume(kdev); 3194 pm_runtime_get_noresume(kdev);
3195 3195
3196 atomic_inc(&dev_priv->pm.wakeref_count); 3196 atomic_inc(&dev_priv->runtime_pm.wakeref_count);
3197} 3197}
3198 3198
3199/** 3199/**
@@ -3210,7 +3210,7 @@ void intel_runtime_pm_put(struct drm_i915_private *dev_priv)
3210 struct device *kdev = &pdev->dev; 3210 struct device *kdev = &pdev->dev;
3211 3211
3212 assert_rpm_wakelock_held(dev_priv); 3212 assert_rpm_wakelock_held(dev_priv);
3213 atomic_dec(&dev_priv->pm.wakeref_count); 3213 atomic_dec(&dev_priv->runtime_pm.wakeref_count);
3214 3214
3215 pm_runtime_mark_last_busy(kdev); 3215 pm_runtime_mark_last_busy(kdev);
3216 pm_runtime_put_autosuspend(kdev); 3216 pm_runtime_put_autosuspend(kdev);