aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorArnaldo Carvalho de Melo <acme@redhat.com>2018-04-25 11:39:22 -0400
committerArnaldo Carvalho de Melo <acme@redhat.com>2018-04-26 12:47:12 -0400
commitabe5449d2de6ccc58444451b6fed130100892097 (patch)
treee4464b0abcdcd2654c0394ea49f3372b6ff0d462
parentd05b861e6da27ccb0d1b882f240890b0ed40adff (diff)
perf map: Shorten map_groups__find() signature
Removing the map_type, that is going away. Cc: Adrian Hunter <adrian.hunter@intel.com> Cc: David Ahern <dsahern@gmail.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Wang Nan <wangnan0@huawei.com> Link: https://lkml.kernel.org/n/tip-18iiiw25r75xn7zlppjldk48@git.kernel.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r--tools/perf/arch/arm/tests/dwarf-unwind.c2
-rw-r--r--tools/perf/arch/arm64/tests/dwarf-unwind.c2
-rw-r--r--tools/perf/arch/powerpc/tests/dwarf-unwind.c2
-rw-r--r--tools/perf/arch/x86/tests/dwarf-unwind.c2
-rw-r--r--tools/perf/tests/vmlinux-kallsyms.c3
-rw-r--r--tools/perf/util/event.c2
-rw-r--r--tools/perf/util/map.c5
-rw-r--r--tools/perf/util/map.h9
-rw-r--r--tools/perf/util/symbol.c2
9 files changed, 16 insertions, 13 deletions
diff --git a/tools/perf/arch/arm/tests/dwarf-unwind.c b/tools/perf/arch/arm/tests/dwarf-unwind.c
index 8cb347760233..7d7a65ca2e8d 100644
--- a/tools/perf/arch/arm/tests/dwarf-unwind.c
+++ b/tools/perf/arch/arm/tests/dwarf-unwind.c
@@ -25,7 +25,7 @@ static int sample_ustack(struct perf_sample *sample,
25 25
26 sp = (unsigned long) regs[PERF_REG_ARM_SP]; 26 sp = (unsigned long) regs[PERF_REG_ARM_SP];
27 27
28 map = map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp); 28 map = __map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp);
29 if (!map) { 29 if (!map) {
30 pr_debug("failed to get stack map\n"); 30 pr_debug("failed to get stack map\n");
31 free(buf); 31 free(buf);
diff --git a/tools/perf/arch/arm64/tests/dwarf-unwind.c b/tools/perf/arch/arm64/tests/dwarf-unwind.c
index e907f0f4c20c..f053eae3b6eb 100644
--- a/tools/perf/arch/arm64/tests/dwarf-unwind.c
+++ b/tools/perf/arch/arm64/tests/dwarf-unwind.c
@@ -25,7 +25,7 @@ static int sample_ustack(struct perf_sample *sample,
25 25
26 sp = (unsigned long) regs[PERF_REG_ARM64_SP]; 26 sp = (unsigned long) regs[PERF_REG_ARM64_SP];
27 27
28 map = map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp); 28 map = __map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp);
29 if (!map) { 29 if (!map) {
30 pr_debug("failed to get stack map\n"); 30 pr_debug("failed to get stack map\n");
31 free(buf); 31 free(buf);
diff --git a/tools/perf/arch/powerpc/tests/dwarf-unwind.c b/tools/perf/arch/powerpc/tests/dwarf-unwind.c
index 30cbbd6d5be0..b22d643cb602 100644
--- a/tools/perf/arch/powerpc/tests/dwarf-unwind.c
+++ b/tools/perf/arch/powerpc/tests/dwarf-unwind.c
@@ -26,7 +26,7 @@ static int sample_ustack(struct perf_sample *sample,
26 26
27 sp = (unsigned long) regs[PERF_REG_POWERPC_R1]; 27 sp = (unsigned long) regs[PERF_REG_POWERPC_R1];
28 28
29 map = map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp); 29 map = __map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp);
30 if (!map) { 30 if (!map) {
31 pr_debug("failed to get stack map\n"); 31 pr_debug("failed to get stack map\n");
32 free(buf); 32 free(buf);
diff --git a/tools/perf/arch/x86/tests/dwarf-unwind.c b/tools/perf/arch/x86/tests/dwarf-unwind.c
index 95036c7a59e8..7da845026323 100644
--- a/tools/perf/arch/x86/tests/dwarf-unwind.c
+++ b/tools/perf/arch/x86/tests/dwarf-unwind.c
@@ -26,7 +26,7 @@ static int sample_ustack(struct perf_sample *sample,
26 26
27 sp = (unsigned long) regs[PERF_REG_X86_SP]; 27 sp = (unsigned long) regs[PERF_REG_X86_SP];
28 28
29 map = map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp); 29 map = __map_groups__find(thread->mg, MAP__VARIABLE, (u64) sp);
30 if (!map) { 30 if (!map) {
31 pr_debug("failed to get stack map\n"); 31 pr_debug("failed to get stack map\n");
32 free(buf); 32 free(buf);
diff --git a/tools/perf/tests/vmlinux-kallsyms.c b/tools/perf/tests/vmlinux-kallsyms.c
index a99b0c118541..702cea7371ac 100644
--- a/tools/perf/tests/vmlinux-kallsyms.c
+++ b/tools/perf/tests/vmlinux-kallsyms.c
@@ -19,7 +19,6 @@ int test__vmlinux_matches_kallsyms(struct test *test __maybe_unused, int subtest
19 struct symbol *sym; 19 struct symbol *sym;
20 struct map *kallsyms_map, *vmlinux_map, *map; 20 struct map *kallsyms_map, *vmlinux_map, *map;
21 struct machine kallsyms, vmlinux; 21 struct machine kallsyms, vmlinux;
22 enum map_type type = MAP__FUNCTION;
23 struct maps *maps = machine__kernel_maps(&vmlinux); 22 struct maps *maps = machine__kernel_maps(&vmlinux);
24 u64 mem_start, mem_end; 23 u64 mem_start, mem_end;
25 bool header_printed; 24 bool header_printed;
@@ -205,7 +204,7 @@ next_pair:
205 mem_start = vmlinux_map->unmap_ip(vmlinux_map, map->start); 204 mem_start = vmlinux_map->unmap_ip(vmlinux_map, map->start);
206 mem_end = vmlinux_map->unmap_ip(vmlinux_map, map->end); 205 mem_end = vmlinux_map->unmap_ip(vmlinux_map, map->end);
207 206
208 pair = map_groups__find(&kallsyms.kmaps, type, mem_start); 207 pair = map_groups__find(&kallsyms.kmaps, mem_start);
209 if (pair == NULL || pair->priv) 208 if (pair == NULL || pair->priv)
210 continue; 209 continue;
211 210
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 542bd5b79e48..a8739cd0d8ca 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -1534,7 +1534,7 @@ struct map *__thread__find_map(struct thread *thread, u8 cpumode, enum map_type
1534 return NULL; 1534 return NULL;
1535 } 1535 }
1536try_again: 1536try_again:
1537 al->map = map_groups__find(mg, type, al->addr); 1537 al->map = __map_groups__find(mg, type, al->addr);
1538 if (al->map == NULL) { 1538 if (al->map == NULL) {
1539 /* 1539 /*
1540 * If this is outside of all known maps, and is a negative 1540 * If this is outside of all known maps, and is a negative
diff --git a/tools/perf/util/map.c b/tools/perf/util/map.c
index f553e302bf9c..91e2afb010f8 100644
--- a/tools/perf/util/map.c
+++ b/tools/perf/util/map.c
@@ -574,7 +574,7 @@ struct symbol *map_groups__find_symbol(struct map_groups *mg,
574 enum map_type type, u64 addr, 574 enum map_type type, u64 addr,
575 struct map **mapp) 575 struct map **mapp)
576{ 576{
577 struct map *map = map_groups__find(mg, type, addr); 577 struct map *map = __map_groups__find(mg, type, addr);
578 578
579 /* Ensure map is loaded before using map->map_ip */ 579 /* Ensure map is loaded before using map->map_ip */
580 if (map != NULL && map__load(map) >= 0) { 580 if (map != NULL && map__load(map) >= 0) {
@@ -627,8 +627,7 @@ int map_groups__find_ams(struct addr_map_symbol *ams)
627 if (ams->addr < ams->map->start || ams->addr >= ams->map->end) { 627 if (ams->addr < ams->map->start || ams->addr >= ams->map->end) {
628 if (ams->map->groups == NULL) 628 if (ams->map->groups == NULL)
629 return -1; 629 return -1;
630 ams->map = map_groups__find(ams->map->groups, ams->map->type, 630 ams->map = __map_groups__find(ams->map->groups, ams->map->type, ams->addr);
631 ams->addr);
632 if (ams->map == NULL) 631 if (ams->map == NULL)
633 return -1; 632 return -1;
634 } 633 }
diff --git a/tools/perf/util/map.h b/tools/perf/util/map.h
index 8ff75be0a965..b4bcf569a131 100644
--- a/tools/perf/util/map.h
+++ b/tools/perf/util/map.h
@@ -214,12 +214,17 @@ static inline void map_groups__remove(struct map_groups *mg, struct map *map)
214 maps__remove(&mg->maps[map->type], map); 214 maps__remove(&mg->maps[map->type], map);
215} 215}
216 216
217static inline struct map *map_groups__find(struct map_groups *mg, 217static inline struct map *__map_groups__find(struct map_groups *mg,
218 enum map_type type, u64 addr) 218 enum map_type type, u64 addr)
219{ 219{
220 return maps__find(&mg->maps[type], addr); 220 return maps__find(&mg->maps[type], addr);
221} 221}
222 222
223static inline struct map *map_groups__find(struct map_groups *mg, u64 addr)
224{
225 return __map_groups__find(mg, MAP__FUNCTION, addr);
226}
227
223static inline struct map *map_groups__first(struct map_groups *mg, 228static inline struct map *map_groups__first(struct map_groups *mg,
224 enum map_type type) 229 enum map_type type)
225{ 230{
diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 0bf4cf76f36a..25701078beab 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -723,7 +723,7 @@ static int dso__split_kallsyms_for_kcore(struct dso *dso, struct map *map)
723 if (module) 723 if (module)
724 *module = '\0'; 724 *module = '\0';
725 725
726 curr_map = map_groups__find(kmaps, map->type, pos->start); 726 curr_map = __map_groups__find(kmaps, map->type, pos->start);
727 727
728 if (!curr_map) { 728 if (!curr_map) {
729 symbol__delete(pos); 729 symbol__delete(pos);