aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVitaly Kuznetsov <vkuznets@redhat.com>2016-12-03 15:34:32 -0500
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-12-06 05:10:54 -0500
commitabd1026da4a7700a8db370947f75cd17b6ae6f76 (patch)
tree547629e7f19d3a30165011bb4454b880f5ec74c7
parentf45be72c8ec0b85263d1fe1e6c681d8c87e198e6 (diff)
hv: acquire vmbus_connection.channel_mutex in vmbus_free_channels()
"kernel BUG at drivers/hv/channel_mgmt.c:350!" is observed when hv_vmbus module is unloaded. BUG_ON() was introduced in commit 85d9aa705184 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") as vmbus_free_channels() codepath was apparently forgotten. Fixes: 85d9aa705184 ("Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister()") Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com> Cc: <Stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/hv/channel_mgmt.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c
index e5d1b0e6c922..26b419203f16 100644
--- a/drivers/hv/channel_mgmt.c
+++ b/drivers/hv/channel_mgmt.c
@@ -389,6 +389,7 @@ void vmbus_free_channels(void)
389{ 389{
390 struct vmbus_channel *channel, *tmp; 390 struct vmbus_channel *channel, *tmp;
391 391
392 mutex_lock(&vmbus_connection.channel_mutex);
392 list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list, 393 list_for_each_entry_safe(channel, tmp, &vmbus_connection.chn_list,
393 listentry) { 394 listentry) {
394 /* hv_process_channel_removal() needs this */ 395 /* hv_process_channel_removal() needs this */
@@ -396,6 +397,7 @@ void vmbus_free_channels(void)
396 397
397 vmbus_device_unregister(channel->device_obj); 398 vmbus_device_unregister(channel->device_obj);
398 } 399 }
400 mutex_unlock(&vmbus_connection.channel_mutex);
399} 401}
400 402
401/* 403/*