aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBorislav Petkov <bp@suse.de>2019-03-29 06:28:52 -0400
committerBorislav Petkov <bp@suse.de>2019-03-29 09:13:44 -0400
commitaba0954327c831f593702e3a81ef3ad4bec7a838 (patch)
tree407d37e26a3d06265824d8f3aa053f7d3de11cd9
parent7a8e61f8478639072d402a26789055a4a4de8f77 (diff)
tick/broadcast: Fix warning about undefined tick_broadcast_oneshot_offline()
Randconfig builds with CONFIG_TICK_ONESHOT=y CONFIG_HOTPLUG_CPU=n trigger kernel/time/tick-broadcast.c:39:13: warning: ‘tick_broadcast_oneshot_offline’ \ declared ‘static’ but never defined [-Wunused-function] due to that function's definition missing. Move the CONFIG_HOTPLUG_CPU ifdeffery around its declaration too. Fixes: 1b72d4323798 ("tick: Remove outgoing CPU from broadcast masks") Signed-off-by: Borislav Petkov <bp@suse.de> Acked-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cc: Valentin Schneider <valentin.schneider@arm.com> Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: x86@kernel.org Link: https://lkml.kernel.org/r/20190329110508.6621-1-bp@alien8.de
-rw-r--r--kernel/time/tick-broadcast.c4
1 files changed, 4 insertions, 0 deletions
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index 0283523de045..7541cbca695e 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -36,12 +36,16 @@ static __cacheline_aligned_in_smp DEFINE_RAW_SPINLOCK(tick_broadcast_lock);
36static void tick_broadcast_setup_oneshot(struct clock_event_device *bc); 36static void tick_broadcast_setup_oneshot(struct clock_event_device *bc);
37static void tick_broadcast_clear_oneshot(int cpu); 37static void tick_broadcast_clear_oneshot(int cpu);
38static void tick_resume_broadcast_oneshot(struct clock_event_device *bc); 38static void tick_resume_broadcast_oneshot(struct clock_event_device *bc);
39# ifdef CONFIG_HOTPLUG_CPU
39static void tick_broadcast_oneshot_offline(unsigned int cpu); 40static void tick_broadcast_oneshot_offline(unsigned int cpu);
41# endif
40#else 42#else
41static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc) { BUG(); } 43static inline void tick_broadcast_setup_oneshot(struct clock_event_device *bc) { BUG(); }
42static inline void tick_broadcast_clear_oneshot(int cpu) { } 44static inline void tick_broadcast_clear_oneshot(int cpu) { }
43static inline void tick_resume_broadcast_oneshot(struct clock_event_device *bc) { } 45static inline void tick_resume_broadcast_oneshot(struct clock_event_device *bc) { }
46# ifdef CONFIG_HOTPLUG_CPU
44static inline void tick_broadcast_oneshot_offline(unsigned int cpu) { } 47static inline void tick_broadcast_oneshot_offline(unsigned int cpu) { }
48# endif
45#endif 49#endif
46 50
47/* 51/*