aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPaul Gortmaker <paul.gortmaker@windriver.com>2016-02-21 19:06:06 -0500
committerDavid Vrabel <david.vrabel@citrix.com>2016-03-21 11:13:55 -0400
commitab1241a1fc4351be16a5fd5c34001de08c696169 (patch)
tree9aaadcf20ffe2d90d1092c62c3d835cb2794b8bf
parent106eaa8e6e19cbaff34c99c9996d61634fb44b0d (diff)
drivers/xen: make xenbus_dev_[front/back]end explicitly non-modular
The Makefile / Kconfig currently controlling compilation here is: obj-y += xenbus_dev_frontend.o [...] obj-$(CONFIG_XEN_BACKEND) += xenbus_dev_backend.o ...with: drivers/xen/Kconfig:config XEN_BACKEND drivers/xen/Kconfig: bool "Backend driver support" ...meaning that they currently are not being built as modules by anyone. Lets remove the modular code that is essentially orphaned, so that when reading the driver there is no doubt it is builtin-only. Since module_init translates to device_initcall in the non-modular case, the init ordering remains unchanged with this commit. We also delete the MODULE_LICENSE tag since all that information is already contained at the top of the file in the comments. Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
-rw-r--r--drivers/xen/xenbus/xenbus_dev_backend.c13
-rw-r--r--drivers/xen/xenbus/xenbus_dev_frontend.c13
2 files changed, 4 insertions, 22 deletions
diff --git a/drivers/xen/xenbus/xenbus_dev_backend.c b/drivers/xen/xenbus/xenbus_dev_backend.c
index ee6d9efd7b76..4a41ac9af966 100644
--- a/drivers/xen/xenbus/xenbus_dev_backend.c
+++ b/drivers/xen/xenbus/xenbus_dev_backend.c
@@ -5,7 +5,7 @@
5#include <linux/mm.h> 5#include <linux/mm.h>
6#include <linux/fs.h> 6#include <linux/fs.h>
7#include <linux/miscdevice.h> 7#include <linux/miscdevice.h>
8#include <linux/module.h> 8#include <linux/init.h>
9#include <linux/capability.h> 9#include <linux/capability.h>
10 10
11#include <xen/xen.h> 11#include <xen/xen.h>
@@ -18,8 +18,6 @@
18 18
19#include "xenbus_comms.h" 19#include "xenbus_comms.h"
20 20
21MODULE_LICENSE("GPL");
22
23static int xenbus_backend_open(struct inode *inode, struct file *filp) 21static int xenbus_backend_open(struct inode *inode, struct file *filp)
24{ 22{
25 if (!capable(CAP_SYS_ADMIN)) 23 if (!capable(CAP_SYS_ADMIN))
@@ -132,11 +130,4 @@ static int __init xenbus_backend_init(void)
132 pr_err("Could not register xenbus backend device\n"); 130 pr_err("Could not register xenbus backend device\n");
133 return err; 131 return err;
134} 132}
135 133device_initcall(xenbus_backend_init);
136static void __exit xenbus_backend_exit(void)
137{
138 misc_deregister(&xenbus_backend_dev);
139}
140
141module_init(xenbus_backend_init);
142module_exit(xenbus_backend_exit);
diff --git a/drivers/xen/xenbus/xenbus_dev_frontend.c b/drivers/xen/xenbus/xenbus_dev_frontend.c
index 9433e46518c8..8c0a359ab4a8 100644
--- a/drivers/xen/xenbus/xenbus_dev_frontend.c
+++ b/drivers/xen/xenbus/xenbus_dev_frontend.c
@@ -55,7 +55,7 @@
55#include <linux/string.h> 55#include <linux/string.h>
56#include <linux/slab.h> 56#include <linux/slab.h>
57#include <linux/miscdevice.h> 57#include <linux/miscdevice.h>
58#include <linux/module.h> 58#include <linux/init.h>
59 59
60#include "xenbus_comms.h" 60#include "xenbus_comms.h"
61 61
@@ -63,8 +63,6 @@
63#include <xen/xen.h> 63#include <xen/xen.h>
64#include <asm/xen/hypervisor.h> 64#include <asm/xen/hypervisor.h>
65 65
66MODULE_LICENSE("GPL");
67
68/* 66/*
69 * An element of a list of outstanding transactions, for which we're 67 * An element of a list of outstanding transactions, for which we're
70 * still waiting a reply. 68 * still waiting a reply.
@@ -624,11 +622,4 @@ static int __init xenbus_init(void)
624 pr_err("Could not register xenbus frontend device\n"); 622 pr_err("Could not register xenbus frontend device\n");
625 return err; 623 return err;
626} 624}
627 625device_initcall(xenbus_init);
628static void __exit xenbus_exit(void)
629{
630 misc_deregister(&xenbus_dev);
631}
632
633module_init(xenbus_init);
634module_exit(xenbus_exit);