diff options
author | Johannes Berg <johannes.berg@intel.com> | 2017-06-13 08:28:18 -0400 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2017-06-13 13:54:03 -0400 |
commit | aa9f979c41043d9fcf7957c99948e20bbddefc7f (patch) | |
tree | 121013b5d9c5ae6189070a7bb9f7d209962e4a22 | |
parent | 0e74008b668febb7ae024c7ee04b30dcbd1f1efd (diff) |
networking: use skb_put_zero()
Use the recently introduced helper to replace the pattern of
skb_put() && memset(), this transformation was done with the
following spatch:
@@
identifier p;
expression len;
expression skb;
@@
-p = skb_put(skb, len);
-memset(p, 0, len);
+p = skb_put_zero(skb, len);
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r-- | drivers/net/ethernet/apple/bmac.c | 3 | ||||
-rw-r--r-- | drivers/net/ethernet/broadcom/bcm63xx_enet.c | 3 | ||||
-rw-r--r-- | drivers/net/ethernet/qualcomm/qca_spi.c | 3 | ||||
-rw-r--r-- | drivers/net/wireless/marvell/mwifiex/tdls.c | 4 | ||||
-rw-r--r-- | drivers/nfc/pn533/pn533.c | 3 | ||||
-rw-r--r-- | lib/nlattr.c | 3 | ||||
-rw-r--r-- | net/sctp/sm_make_chunk.c | 3 |
7 files changed, 8 insertions, 14 deletions
diff --git a/drivers/net/ethernet/apple/bmac.c b/drivers/net/ethernet/apple/bmac.c index 2b2d87089987..eac740c476ce 100644 --- a/drivers/net/ethernet/apple/bmac.c +++ b/drivers/net/ethernet/apple/bmac.c | |||
@@ -1218,8 +1218,7 @@ static void bmac_reset_and_enable(struct net_device *dev) | |||
1218 | */ | 1218 | */ |
1219 | skb = netdev_alloc_skb(dev, ETHERMINPACKET); | 1219 | skb = netdev_alloc_skb(dev, ETHERMINPACKET); |
1220 | if (skb != NULL) { | 1220 | if (skb != NULL) { |
1221 | data = skb_put(skb, ETHERMINPACKET); | 1221 | data = skb_put_zero(skb, ETHERMINPACKET); |
1222 | memset(data, 0, ETHERMINPACKET); | ||
1223 | memcpy(data, dev->dev_addr, ETH_ALEN); | 1222 | memcpy(data, dev->dev_addr, ETH_ALEN); |
1224 | memcpy(data + ETH_ALEN, dev->dev_addr, ETH_ALEN); | 1223 | memcpy(data + ETH_ALEN, dev->dev_addr, ETH_ALEN); |
1225 | bmac_transmit_packet(skb, dev); | 1224 | bmac_transmit_packet(skb, dev); |
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index ea3c906fa0e4..61a88b64bd39 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c | |||
@@ -609,8 +609,7 @@ static int bcm_enet_start_xmit(struct sk_buff *skb, struct net_device *dev) | |||
609 | dev_kfree_skb(skb); | 609 | dev_kfree_skb(skb); |
610 | skb = nskb; | 610 | skb = nskb; |
611 | } | 611 | } |
612 | data = skb_put(skb, needed); | 612 | data = skb_put_zero(skb, needed); |
613 | memset(data, 0, needed); | ||
614 | } | 613 | } |
615 | 614 | ||
616 | /* point to the next available desc */ | 615 | /* point to the next available desc */ |
diff --git a/drivers/net/ethernet/qualcomm/qca_spi.c b/drivers/net/ethernet/qualcomm/qca_spi.c index de78f60309a0..9c236298fe21 100644 --- a/drivers/net/ethernet/qualcomm/qca_spi.c +++ b/drivers/net/ethernet/qualcomm/qca_spi.c | |||
@@ -719,8 +719,7 @@ qcaspi_netdev_xmit(struct sk_buff *skb, struct net_device *dev) | |||
719 | qcafrm_create_header(ptmp, frame_len); | 719 | qcafrm_create_header(ptmp, frame_len); |
720 | 720 | ||
721 | if (pad_len) { | 721 | if (pad_len) { |
722 | ptmp = skb_put(skb, pad_len); | 722 | ptmp = skb_put_zero(skb, pad_len); |
723 | memset(ptmp, 0, pad_len); | ||
724 | } | 723 | } |
725 | 724 | ||
726 | ptmp = skb_put(skb, QCAFRM_FOOTER_LEN); | 725 | ptmp = skb_put(skb, QCAFRM_FOOTER_LEN); |
diff --git a/drivers/net/wireless/marvell/mwifiex/tdls.c b/drivers/net/wireless/marvell/mwifiex/tdls.c index d76ce8797de1..b7d124dbef0c 100644 --- a/drivers/net/wireless/marvell/mwifiex/tdls.c +++ b/drivers/net/wireless/marvell/mwifiex/tdls.c | |||
@@ -853,8 +853,8 @@ int mwifiex_send_tdls_action_frame(struct mwifiex_private *priv, const u8 *peer, | |||
853 | 853 | ||
854 | pkt_type = PKT_TYPE_MGMT; | 854 | pkt_type = PKT_TYPE_MGMT; |
855 | tx_control = 0; | 855 | tx_control = 0; |
856 | pos = skb_put(skb, MWIFIEX_MGMT_FRAME_HEADER_SIZE + sizeof(pkt_len)); | 856 | pos = skb_put_zero(skb, |
857 | memset(pos, 0, MWIFIEX_MGMT_FRAME_HEADER_SIZE + sizeof(pkt_len)); | 857 | MWIFIEX_MGMT_FRAME_HEADER_SIZE + sizeof(pkt_len)); |
858 | memcpy(pos, &pkt_type, sizeof(pkt_type)); | 858 | memcpy(pos, &pkt_type, sizeof(pkt_type)); |
859 | memcpy(pos + sizeof(pkt_type), &tx_control, sizeof(tx_control)); | 859 | memcpy(pos + sizeof(pkt_type), &tx_control, sizeof(tx_control)); |
860 | 860 | ||
diff --git a/drivers/nfc/pn533/pn533.c b/drivers/nfc/pn533/pn533.c index 65bbaa5fcdda..70c304504a29 100644 --- a/drivers/nfc/pn533/pn533.c +++ b/drivers/nfc/pn533/pn533.c | |||
@@ -1043,8 +1043,7 @@ static struct sk_buff *pn533_alloc_poll_tg_frame(struct pn533 *dev) | |||
1043 | get_random_bytes(felica + 2, 6); | 1043 | get_random_bytes(felica + 2, 6); |
1044 | 1044 | ||
1045 | /* NFCID3 */ | 1045 | /* NFCID3 */ |
1046 | nfcid3 = skb_put(skb, 10); | 1046 | nfcid3 = skb_put_zero(skb, 10); |
1047 | memset(nfcid3, 0, 10); | ||
1048 | memcpy(nfcid3, felica, 8); | 1047 | memcpy(nfcid3, felica, 8); |
1049 | 1048 | ||
1050 | /* General bytes */ | 1049 | /* General bytes */ |
diff --git a/lib/nlattr.c b/lib/nlattr.c index a7e0b16078df..d09d9746fc5d 100644 --- a/lib/nlattr.c +++ b/lib/nlattr.c | |||
@@ -400,8 +400,7 @@ void *__nla_reserve_nohdr(struct sk_buff *skb, int attrlen) | |||
400 | { | 400 | { |
401 | void *start; | 401 | void *start; |
402 | 402 | ||
403 | start = skb_put(skb, NLA_ALIGN(attrlen)); | 403 | start = skb_put_zero(skb, NLA_ALIGN(attrlen)); |
404 | memset(start, 0, NLA_ALIGN(attrlen)); | ||
405 | 404 | ||
406 | return start; | 405 | return start; |
407 | } | 406 | } |
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c index bd439edf2d8a..ea2601501654 100644 --- a/net/sctp/sm_make_chunk.c +++ b/net/sctp/sm_make_chunk.c | |||
@@ -1296,8 +1296,7 @@ struct sctp_chunk *sctp_make_auth(const struct sctp_association *asoc) | |||
1296 | retval->subh.auth_hdr = sctp_addto_chunk(retval, sizeof(sctp_authhdr_t), | 1296 | retval->subh.auth_hdr = sctp_addto_chunk(retval, sizeof(sctp_authhdr_t), |
1297 | &auth_hdr); | 1297 | &auth_hdr); |
1298 | 1298 | ||
1299 | hmac = skb_put(retval->skb, hmac_desc->hmac_len); | 1299 | hmac = skb_put_zero(retval->skb, hmac_desc->hmac_len); |
1300 | memset(hmac, 0, hmac_desc->hmac_len); | ||
1301 | 1300 | ||
1302 | /* Adjust the chunk header to include the empty MAC */ | 1301 | /* Adjust the chunk header to include the empty MAC */ |
1303 | retval->chunk_hdr->length = | 1302 | retval->chunk_hdr->length = |