aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChris Wilson <chris@chris-wilson.co.uk>2018-09-04 07:57:19 -0400
committerChris Wilson <chris@chris-wilson.co.uk>2018-09-04 13:59:56 -0400
commita9734d8ee63346865d5966551ef4aabf8016d8dd (patch)
tree4419d72449aeeb1a7b57ffe49917c533cef6a918
parentb9a40816fef79a6053b9d601f50e852acdaafebd (diff)
drm: Suppress user controlled spam for invalid drm_wait_vblank_ioctl
The ioctl arguments are under control of the user and as such we should resist any temptation to flood the kernel logs with their errors. Relegate the DRM_ERROR to a DRM_DEBUG so the user has to opt into hearing of their own mistakes. (One day we will have a small ringbuffer attached to the task, so that the concerned process can inspect its own debug info for EINVAL without them being hitting syslog at all.) Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: https://patchwork.freedesktop.org/patch/msgid/20180904115719.24525-1-chris@chris-wilson.co.uk
-rw-r--r--drivers/gpu/drm/drm_vblank.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 7610ff466ef9..ec2dcfdac8ef 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -1541,7 +1541,7 @@ int drm_wait_vblank_ioctl(struct drm_device *dev, void *data,
1541 if (vblwait->request.type & 1541 if (vblwait->request.type &
1542 ~(_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK | 1542 ~(_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK |
1543 _DRM_VBLANK_HIGH_CRTC_MASK)) { 1543 _DRM_VBLANK_HIGH_CRTC_MASK)) {
1544 DRM_ERROR("Unsupported type value 0x%x, supported mask 0x%x\n", 1544 DRM_DEBUG("Unsupported type value 0x%x, supported mask 0x%x\n",
1545 vblwait->request.type, 1545 vblwait->request.type,
1546 (_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK | 1546 (_DRM_VBLANK_TYPES_MASK | _DRM_VBLANK_FLAGS_MASK |
1547 _DRM_VBLANK_HIGH_CRTC_MASK)); 1547 _DRM_VBLANK_HIGH_CRTC_MASK));