diff options
author | Krzysztof Kozlowski <k.kozlowski@samsung.com> | 2015-12-29 23:47:25 -0500 |
---|---|---|
committer | Alexandre Belloni <alexandre.belloni@free-electrons.com> | 2016-01-11 14:21:35 -0500 |
commit | a83a793ad433d24f67aba4d88169235379004235 (patch) | |
tree | ddb66710549215fe5cbe4c7b050fee61798f0f5a | |
parent | f571287bda5390751ab4e4d5e3f54fa2d1788667 (diff) |
rtc: s5m: Cleanup by removing useless 'rtc' prefix from fields
Remove the 'rtc' prefix from some of the fields in struct
s5m_rtc_reg_config because it is obvious - this is a RTC driver. No
functional changes.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Tested-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
-rw-r--r-- | drivers/rtc/rtc-s5m.c | 40 |
1 files changed, 19 insertions, 21 deletions
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c index 0d68a85dd429..85649861a6b0 100644 --- a/drivers/rtc/rtc-s5m.c +++ b/drivers/rtc/rtc-s5m.c | |||
@@ -55,9 +55,9 @@ struct s5m_rtc_reg_config { | |||
55 | * will enable update of time or alarm register. Then it will be | 55 | * will enable update of time or alarm register. Then it will be |
56 | * auto-cleared after successful update. | 56 | * auto-cleared after successful update. |
57 | */ | 57 | */ |
58 | unsigned int rtc_udr_update; | 58 | unsigned int udr_update; |
59 | /* Mask for UDR field in 'rtc_udr_update' register */ | 59 | /* Mask for UDR field in 'udr_update' register */ |
60 | unsigned int rtc_udr_mask; | 60 | unsigned int udr_mask; |
61 | }; | 61 | }; |
62 | 62 | ||
63 | /* Register map for S5M8763 and S5M8767 */ | 63 | /* Register map for S5M8763 and S5M8767 */ |
@@ -67,8 +67,8 @@ static const struct s5m_rtc_reg_config s5m_rtc_regs = { | |||
67 | .ctrl = S5M_ALARM1_CONF, | 67 | .ctrl = S5M_ALARM1_CONF, |
68 | .alarm0 = S5M_ALARM0_SEC, | 68 | .alarm0 = S5M_ALARM0_SEC, |
69 | .alarm1 = S5M_ALARM1_SEC, | 69 | .alarm1 = S5M_ALARM1_SEC, |
70 | .rtc_udr_update = S5M_RTC_UDR_CON, | 70 | .udr_update = S5M_RTC_UDR_CON, |
71 | .rtc_udr_mask = S5M_RTC_UDR_MASK, | 71 | .udr_mask = S5M_RTC_UDR_MASK, |
72 | }; | 72 | }; |
73 | 73 | ||
74 | /* | 74 | /* |
@@ -81,8 +81,8 @@ static const struct s5m_rtc_reg_config s2mps_rtc_regs = { | |||
81 | .ctrl = S2MPS_RTC_CTRL, | 81 | .ctrl = S2MPS_RTC_CTRL, |
82 | .alarm0 = S2MPS_ALARM0_SEC, | 82 | .alarm0 = S2MPS_ALARM0_SEC, |
83 | .alarm1 = S2MPS_ALARM1_SEC, | 83 | .alarm1 = S2MPS_ALARM1_SEC, |
84 | .rtc_udr_update = S2MPS_RTC_UDR_CON, | 84 | .udr_update = S2MPS_RTC_UDR_CON, |
85 | .rtc_udr_mask = S2MPS_RTC_WUDR_MASK, | 85 | .udr_mask = S2MPS_RTC_WUDR_MASK, |
86 | }; | 86 | }; |
87 | 87 | ||
88 | struct s5m_rtc_info { | 88 | struct s5m_rtc_info { |
@@ -166,9 +166,8 @@ static inline int s5m8767_wait_for_udr_update(struct s5m_rtc_info *info) | |||
166 | unsigned int data; | 166 | unsigned int data; |
167 | 167 | ||
168 | do { | 168 | do { |
169 | ret = regmap_read(info->regmap, info->regs->rtc_udr_update, | 169 | ret = regmap_read(info->regmap, info->regs->udr_update, &data); |
170 | &data); | 170 | } while (--retry && (data & info->regs->udr_mask) && !ret); |
171 | } while (--retry && (data & info->regs->rtc_udr_mask) && !ret); | ||
172 | 171 | ||
173 | if (!retry) | 172 | if (!retry) |
174 | dev_err(info->dev, "waiting for UDR update, reached max number of retries\n"); | 173 | dev_err(info->dev, "waiting for UDR update, reached max number of retries\n"); |
@@ -214,7 +213,7 @@ static inline int s5m8767_rtc_set_time_reg(struct s5m_rtc_info *info) | |||
214 | int ret; | 213 | int ret; |
215 | unsigned int data; | 214 | unsigned int data; |
216 | 215 | ||
217 | ret = regmap_read(info->regmap, info->regs->rtc_udr_update, &data); | 216 | ret = regmap_read(info->regmap, info->regs->udr_update, &data); |
218 | if (ret < 0) { | 217 | if (ret < 0) { |
219 | dev_err(info->dev, "failed to read update reg(%d)\n", ret); | 218 | dev_err(info->dev, "failed to read update reg(%d)\n", ret); |
220 | return ret; | 219 | return ret; |
@@ -223,21 +222,20 @@ static inline int s5m8767_rtc_set_time_reg(struct s5m_rtc_info *info) | |||
223 | switch (info->device_type) { | 222 | switch (info->device_type) { |
224 | case S5M8763X: | 223 | case S5M8763X: |
225 | case S5M8767X: | 224 | case S5M8767X: |
226 | data |= info->regs->rtc_udr_mask | S5M_RTC_TIME_EN_MASK; | 225 | data |= info->regs->udr_mask | S5M_RTC_TIME_EN_MASK; |
227 | case S2MPS15X: | 226 | case S2MPS15X: |
228 | /* As per UM, for write time register, set WUDR bit to high */ | 227 | /* As per UM, for write time register, set WUDR bit to high */ |
229 | data |= S2MPS15_RTC_WUDR_MASK; | 228 | data |= S2MPS15_RTC_WUDR_MASK; |
230 | break; | 229 | break; |
231 | case S2MPS14X: | 230 | case S2MPS14X: |
232 | case S2MPS13X: | 231 | case S2MPS13X: |
233 | data |= info->regs->rtc_udr_mask; | 232 | data |= info->regs->udr_mask; |
234 | break; | 233 | break; |
235 | default: | 234 | default: |
236 | return -EINVAL; | 235 | return -EINVAL; |
237 | } | 236 | } |
238 | 237 | ||
239 | 238 | ret = regmap_write(info->regmap, info->regs->udr_update, data); | |
240 | ret = regmap_write(info->regmap, info->regs->rtc_udr_update, data); | ||
241 | if (ret < 0) { | 239 | if (ret < 0) { |
242 | dev_err(info->dev, "failed to write update reg(%d)\n", ret); | 240 | dev_err(info->dev, "failed to write update reg(%d)\n", ret); |
243 | return ret; | 241 | return ret; |
@@ -253,14 +251,14 @@ static inline int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) | |||
253 | int ret; | 251 | int ret; |
254 | unsigned int data; | 252 | unsigned int data; |
255 | 253 | ||
256 | ret = regmap_read(info->regmap, info->regs->rtc_udr_update, &data); | 254 | ret = regmap_read(info->regmap, info->regs->udr_update, &data); |
257 | if (ret < 0) { | 255 | if (ret < 0) { |
258 | dev_err(info->dev, "%s: fail to read update reg(%d)\n", | 256 | dev_err(info->dev, "%s: fail to read update reg(%d)\n", |
259 | __func__, ret); | 257 | __func__, ret); |
260 | return ret; | 258 | return ret; |
261 | } | 259 | } |
262 | 260 | ||
263 | data |= info->regs->rtc_udr_mask; | 261 | data |= info->regs->udr_mask; |
264 | switch (info->device_type) { | 262 | switch (info->device_type) { |
265 | case S5M8763X: | 263 | case S5M8763X: |
266 | case S5M8767X: | 264 | case S5M8767X: |
@@ -268,7 +266,7 @@ static inline int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) | |||
268 | break; | 266 | break; |
269 | case S2MPS15X: | 267 | case S2MPS15X: |
270 | /* As per UM, for write alarm, set A_UDR(bit[4]) to high | 268 | /* As per UM, for write alarm, set A_UDR(bit[4]) to high |
271 | * rtc_udr_mask above sets bit[4] | 269 | * udr_mask above sets bit[4] |
272 | */ | 270 | */ |
273 | break; | 271 | break; |
274 | case S2MPS14X: | 272 | case S2MPS14X: |
@@ -281,7 +279,7 @@ static inline int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) | |||
281 | return -EINVAL; | 279 | return -EINVAL; |
282 | } | 280 | } |
283 | 281 | ||
284 | ret = regmap_write(info->regmap, info->regs->rtc_udr_update, data); | 282 | ret = regmap_write(info->regmap, info->regs->udr_update, data); |
285 | if (ret < 0) { | 283 | if (ret < 0) { |
286 | dev_err(info->dev, "%s: fail to write update reg(%d)\n", | 284 | dev_err(info->dev, "%s: fail to write update reg(%d)\n", |
287 | __func__, ret); | 285 | __func__, ret); |
@@ -292,7 +290,7 @@ static inline int s5m8767_rtc_set_alarm_reg(struct s5m_rtc_info *info) | |||
292 | 290 | ||
293 | /* On S2MPS13 the AUDR is not auto-cleared */ | 291 | /* On S2MPS13 the AUDR is not auto-cleared */ |
294 | if (info->device_type == S2MPS13X) | 292 | if (info->device_type == S2MPS13X) |
295 | regmap_update_bits(info->regmap, info->regs->rtc_udr_update, | 293 | regmap_update_bits(info->regmap, info->regs->udr_update, |
296 | S2MPS13_RTC_AUDR_MASK, 0); | 294 | S2MPS13_RTC_AUDR_MASK, 0); |
297 | 295 | ||
298 | return ret; | 296 | return ret; |
@@ -339,7 +337,7 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm) | |||
339 | if (info->device_type == S2MPS15X || info->device_type == S2MPS14X || | 337 | if (info->device_type == S2MPS15X || info->device_type == S2MPS14X || |
340 | info->device_type == S2MPS13X) { | 338 | info->device_type == S2MPS13X) { |
341 | ret = regmap_update_bits(info->regmap, | 339 | ret = regmap_update_bits(info->regmap, |
342 | info->regs->rtc_udr_update, | 340 | info->regs->udr_update, |
343 | S2MPS_RTC_RUDR_MASK, S2MPS_RTC_RUDR_MASK); | 341 | S2MPS_RTC_RUDR_MASK, S2MPS_RTC_RUDR_MASK); |
344 | if (ret) { | 342 | if (ret) { |
345 | dev_err(dev, | 343 | dev_err(dev, |