aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThierry Reding <treding@nvidia.com>2016-08-15 11:31:31 -0400
committerBjorn Helgaas <bhelgaas@google.com>2016-08-18 16:41:06 -0400
commita7fbae213925488066e296f30cc81aaa2c5c2802 (patch)
tree0fd980a4d3410e94d108d2b42675616d50325e1b
parent29b4817d4018df78086157ea3a55c1d9424a7cfc (diff)
PCI: tegra: Remove redundant _data suffix
The struct tegra_pcie_soc_data represents SoC-specific data. The shorter name tegra_pcie_soc already describes that accurately enough, so the extra five characters are redundant. Also remove the suffix from various variable names to shorten the code a little. This also makes this driver more consistent with the naming used in other drivers that use a similar mechanism to differentiate between various SoC generations. Signed-off-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
-rw-r--r--drivers/pci/host/pci-tegra.c42
1 files changed, 21 insertions, 21 deletions
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c
index 6de0757b11e4..7756a792600c 100644
--- a/drivers/pci/host/pci-tegra.c
+++ b/drivers/pci/host/pci-tegra.c
@@ -240,7 +240,7 @@ struct tegra_msi {
240}; 240};
241 241
242/* used to differentiate between Tegra SoC generations */ 242/* used to differentiate between Tegra SoC generations */
243struct tegra_pcie_soc_data { 243struct tegra_pcie_soc {
244 unsigned int num_ports; 244 unsigned int num_ports;
245 unsigned int msi_base_shift; 245 unsigned int msi_base_shift;
246 u32 pads_pll_ctl; 246 u32 pads_pll_ctl;
@@ -300,7 +300,7 @@ struct tegra_pcie {
300 struct regulator_bulk_data *supplies; 300 struct regulator_bulk_data *supplies;
301 unsigned int num_supplies; 301 unsigned int num_supplies;
302 302
303 const struct tegra_pcie_soc_data *soc_data; 303 const struct tegra_pcie_soc *soc;
304 struct dentry *debugfs; 304 struct dentry *debugfs;
305}; 305};
306 306
@@ -542,8 +542,8 @@ static void tegra_pcie_port_reset(struct tegra_pcie_port *port)
542 542
543static void tegra_pcie_port_enable(struct tegra_pcie_port *port) 543static void tegra_pcie_port_enable(struct tegra_pcie_port *port)
544{ 544{
545 const struct tegra_pcie_soc_data *soc = port->pcie->soc_data;
546 unsigned long ctrl = tegra_pcie_port_get_pex_ctrl(port); 545 unsigned long ctrl = tegra_pcie_port_get_pex_ctrl(port);
546 const struct tegra_pcie_soc *soc = port->pcie->soc;
547 unsigned long value; 547 unsigned long value;
548 548
549 /* enable reference clock */ 549 /* enable reference clock */
@@ -562,8 +562,8 @@ static void tegra_pcie_port_enable(struct tegra_pcie_port *port)
562 562
563static void tegra_pcie_port_disable(struct tegra_pcie_port *port) 563static void tegra_pcie_port_disable(struct tegra_pcie_port *port)
564{ 564{
565 const struct tegra_pcie_soc_data *soc = port->pcie->soc_data;
566 unsigned long ctrl = tegra_pcie_port_get_pex_ctrl(port); 565 unsigned long ctrl = tegra_pcie_port_get_pex_ctrl(port);
566 const struct tegra_pcie_soc *soc = port->pcie->soc;
567 unsigned long value; 567 unsigned long value;
568 568
569 /* assert port reset */ 569 /* assert port reset */
@@ -774,7 +774,7 @@ static void tegra_pcie_setup_translations(struct tegra_pcie *pcie)
774 774
775static int tegra_pcie_pll_wait(struct tegra_pcie *pcie, unsigned long timeout) 775static int tegra_pcie_pll_wait(struct tegra_pcie *pcie, unsigned long timeout)
776{ 776{
777 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 777 const struct tegra_pcie_soc *soc = pcie->soc;
778 u32 value; 778 u32 value;
779 779
780 timeout = jiffies + msecs_to_jiffies(timeout); 780 timeout = jiffies + msecs_to_jiffies(timeout);
@@ -790,7 +790,7 @@ static int tegra_pcie_pll_wait(struct tegra_pcie *pcie, unsigned long timeout)
790 790
791static int tegra_pcie_phy_enable(struct tegra_pcie *pcie) 791static int tegra_pcie_phy_enable(struct tegra_pcie *pcie)
792{ 792{
793 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 793 const struct tegra_pcie_soc *soc = pcie->soc;
794 u32 value; 794 u32 value;
795 int err; 795 int err;
796 796
@@ -845,7 +845,7 @@ static int tegra_pcie_phy_enable(struct tegra_pcie *pcie)
845 845
846static int tegra_pcie_phy_disable(struct tegra_pcie *pcie) 846static int tegra_pcie_phy_disable(struct tegra_pcie *pcie)
847{ 847{
848 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 848 const struct tegra_pcie_soc *soc = pcie->soc;
849 u32 value; 849 u32 value;
850 850
851 /* disable TX/RX data */ 851 /* disable TX/RX data */
@@ -906,7 +906,7 @@ static int tegra_pcie_port_phy_power_off(struct tegra_pcie_port *port)
906 906
907static int tegra_pcie_phy_power_on(struct tegra_pcie *pcie) 907static int tegra_pcie_phy_power_on(struct tegra_pcie *pcie)
908{ 908{
909 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 909 const struct tegra_pcie_soc *soc = pcie->soc;
910 struct tegra_pcie_port *port; 910 struct tegra_pcie_port *port;
911 int err; 911 int err;
912 912
@@ -974,7 +974,7 @@ static int tegra_pcie_phy_power_off(struct tegra_pcie *pcie)
974 974
975static int tegra_pcie_enable_controller(struct tegra_pcie *pcie) 975static int tegra_pcie_enable_controller(struct tegra_pcie *pcie)
976{ 976{
977 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 977 const struct tegra_pcie_soc *soc = pcie->soc;
978 struct tegra_pcie_port *port; 978 struct tegra_pcie_port *port;
979 unsigned long value; 979 unsigned long value;
980 int err; 980 int err;
@@ -1067,7 +1067,7 @@ static void tegra_pcie_power_off(struct tegra_pcie *pcie)
1067 1067
1068static int tegra_pcie_power_on(struct tegra_pcie *pcie) 1068static int tegra_pcie_power_on(struct tegra_pcie *pcie)
1069{ 1069{
1070 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 1070 const struct tegra_pcie_soc *soc = pcie->soc;
1071 int err; 1071 int err;
1072 1072
1073 reset_control_assert(pcie->pcie_xrst); 1073 reset_control_assert(pcie->pcie_xrst);
@@ -1117,7 +1117,7 @@ static int tegra_pcie_power_on(struct tegra_pcie *pcie)
1117 1117
1118static int tegra_pcie_clocks_get(struct tegra_pcie *pcie) 1118static int tegra_pcie_clocks_get(struct tegra_pcie *pcie)
1119{ 1119{
1120 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 1120 const struct tegra_pcie_soc *soc = pcie->soc;
1121 1121
1122 pcie->pex_clk = devm_clk_get(pcie->dev, "pex"); 1122 pcie->pex_clk = devm_clk_get(pcie->dev, "pex");
1123 if (IS_ERR(pcie->pex_clk)) 1123 if (IS_ERR(pcie->pex_clk))
@@ -1234,7 +1234,7 @@ static int tegra_pcie_port_get_phys(struct tegra_pcie_port *port)
1234 1234
1235static int tegra_pcie_phys_get(struct tegra_pcie *pcie) 1235static int tegra_pcie_phys_get(struct tegra_pcie *pcie)
1236{ 1236{
1237 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 1237 const struct tegra_pcie_soc *soc = pcie->soc;
1238 struct device_node *np = pcie->dev->of_node; 1238 struct device_node *np = pcie->dev->of_node;
1239 struct tegra_pcie_port *port; 1239 struct tegra_pcie_port *port;
1240 int err; 1240 int err;
@@ -1486,7 +1486,7 @@ static const struct irq_domain_ops msi_domain_ops = {
1486static int tegra_pcie_enable_msi(struct tegra_pcie *pcie) 1486static int tegra_pcie_enable_msi(struct tegra_pcie *pcie)
1487{ 1487{
1488 struct platform_device *pdev = to_platform_device(pcie->dev); 1488 struct platform_device *pdev = to_platform_device(pcie->dev);
1489 const struct tegra_pcie_soc_data *soc = pcie->soc_data; 1489 const struct tegra_pcie_soc *soc = pcie->soc;
1490 struct tegra_msi *msi = &pcie->msi; 1490 struct tegra_msi *msi = &pcie->msi;
1491 unsigned long base; 1491 unsigned long base;
1492 int err; 1492 int err;
@@ -1799,8 +1799,8 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask)
1799 1799
1800static int tegra_pcie_parse_dt(struct tegra_pcie *pcie) 1800static int tegra_pcie_parse_dt(struct tegra_pcie *pcie)
1801{ 1801{
1802 const struct tegra_pcie_soc_data *soc = pcie->soc_data;
1803 struct device_node *np = pcie->dev->of_node, *port; 1802 struct device_node *np = pcie->dev->of_node, *port;
1803 const struct tegra_pcie_soc *soc = pcie->soc;
1804 struct of_pci_range_parser parser; 1804 struct of_pci_range_parser parser;
1805 struct of_pci_range range; 1805 struct of_pci_range range;
1806 u32 lanes = 0, mask = 0; 1806 u32 lanes = 0, mask = 0;
@@ -2043,7 +2043,7 @@ static int tegra_pcie_enable(struct tegra_pcie *pcie)
2043 return 0; 2043 return 0;
2044} 2044}
2045 2045
2046static const struct tegra_pcie_soc_data tegra20_pcie_data = { 2046static const struct tegra_pcie_soc tegra20_pcie = {
2047 .num_ports = 2, 2047 .num_ports = 2,
2048 .msi_base_shift = 0, 2048 .msi_base_shift = 0,
2049 .pads_pll_ctl = PADS_PLL_CTL_TEGRA20, 2049 .pads_pll_ctl = PADS_PLL_CTL_TEGRA20,
@@ -2056,7 +2056,7 @@ static const struct tegra_pcie_soc_data tegra20_pcie_data = {
2056 .has_gen2 = false, 2056 .has_gen2 = false,
2057}; 2057};
2058 2058
2059static const struct tegra_pcie_soc_data tegra30_pcie_data = { 2059static const struct tegra_pcie_soc tegra30_pcie = {
2060 .num_ports = 3, 2060 .num_ports = 3,
2061 .msi_base_shift = 8, 2061 .msi_base_shift = 8,
2062 .pads_pll_ctl = PADS_PLL_CTL_TEGRA30, 2062 .pads_pll_ctl = PADS_PLL_CTL_TEGRA30,
@@ -2070,7 +2070,7 @@ static const struct tegra_pcie_soc_data tegra30_pcie_data = {
2070 .has_gen2 = false, 2070 .has_gen2 = false,
2071}; 2071};
2072 2072
2073static const struct tegra_pcie_soc_data tegra124_pcie_data = { 2073static const struct tegra_pcie_soc tegra124_pcie = {
2074 .num_ports = 2, 2074 .num_ports = 2,
2075 .msi_base_shift = 8, 2075 .msi_base_shift = 8,
2076 .pads_pll_ctl = PADS_PLL_CTL_TEGRA30, 2076 .pads_pll_ctl = PADS_PLL_CTL_TEGRA30,
@@ -2084,9 +2084,9 @@ static const struct tegra_pcie_soc_data tegra124_pcie_data = {
2084}; 2084};
2085 2085
2086static const struct of_device_id tegra_pcie_of_match[] = { 2086static const struct of_device_id tegra_pcie_of_match[] = {
2087 { .compatible = "nvidia,tegra124-pcie", .data = &tegra124_pcie_data }, 2087 { .compatible = "nvidia,tegra124-pcie", .data = &tegra124_pcie },
2088 { .compatible = "nvidia,tegra30-pcie", .data = &tegra30_pcie_data }, 2088 { .compatible = "nvidia,tegra30-pcie", .data = &tegra30_pcie },
2089 { .compatible = "nvidia,tegra20-pcie", .data = &tegra20_pcie_data }, 2089 { .compatible = "nvidia,tegra20-pcie", .data = &tegra20_pcie },
2090 { }, 2090 { },
2091}; 2091};
2092 2092
@@ -2215,7 +2215,7 @@ static int tegra_pcie_probe(struct platform_device *pdev)
2215 2215
2216 INIT_LIST_HEAD(&pcie->buses); 2216 INIT_LIST_HEAD(&pcie->buses);
2217 INIT_LIST_HEAD(&pcie->ports); 2217 INIT_LIST_HEAD(&pcie->ports);
2218 pcie->soc_data = match->data; 2218 pcie->soc = match->data;
2219 pcie->dev = &pdev->dev; 2219 pcie->dev = &pdev->dev;
2220 2220
2221 err = tegra_pcie_parse_dt(pcie); 2221 err = tegra_pcie_parse_dt(pcie);