diff options
author | Zhenyu Wang <zhenyuw@linux.intel.com> | 2018-07-30 23:02:12 -0400 |
---|---|---|
committer | Zhenyu Wang <zhenyuw@linux.intel.com> | 2018-08-06 22:39:53 -0400 |
commit | a752b070a67823174565322cc48b2668daf9a8da (patch) | |
tree | c2d0116291b05b005e49bee3fe5bb1239f2e07bc | |
parent | 63ef26237ba846b8898c229a85bfae1cf4fac845 (diff) |
drm/i915/gvt: Fix function comment doc errors
Caught by W=1 to fix left wrong function comment doc.
Reviewed-by: Hang Yuan <hang.yuan@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
-rw-r--r-- | drivers/gpu/drm/i915/gvt/cfg_space.c | 12 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/display.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/edid.c | 9 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/gtt.c | 9 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/gvt.c | 3 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/handlers.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/mmio.c | 3 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/opregion.c | 1 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/page_track.c | 2 | ||||
-rw-r--r-- | drivers/gpu/drm/i915/gvt/scheduler.c | 4 |
10 files changed, 37 insertions, 8 deletions
diff --git a/drivers/gpu/drm/i915/gvt/cfg_space.c b/drivers/gpu/drm/i915/gvt/cfg_space.c index c62346fdc05d..19cf1bbe059d 100644 --- a/drivers/gpu/drm/i915/gvt/cfg_space.c +++ b/drivers/gpu/drm/i915/gvt/cfg_space.c | |||
@@ -56,6 +56,10 @@ static const u8 pci_cfg_space_rw_bmp[PCI_INTERRUPT_LINE + 4] = { | |||
56 | 56 | ||
57 | /** | 57 | /** |
58 | * vgpu_pci_cfg_mem_write - write virtual cfg space memory | 58 | * vgpu_pci_cfg_mem_write - write virtual cfg space memory |
59 | * @vgpu: target vgpu | ||
60 | * @off: offset | ||
61 | * @src: src ptr to write | ||
62 | * @bytes: number of bytes | ||
59 | * | 63 | * |
60 | * Use this function to write virtual cfg space memory. | 64 | * Use this function to write virtual cfg space memory. |
61 | * For standard cfg space, only RW bits can be changed, | 65 | * For standard cfg space, only RW bits can be changed, |
@@ -91,6 +95,10 @@ static void vgpu_pci_cfg_mem_write(struct intel_vgpu *vgpu, unsigned int off, | |||
91 | 95 | ||
92 | /** | 96 | /** |
93 | * intel_vgpu_emulate_cfg_read - emulate vGPU configuration space read | 97 | * intel_vgpu_emulate_cfg_read - emulate vGPU configuration space read |
98 | * @vgpu: target vgpu | ||
99 | * @offset: offset | ||
100 | * @p_data: return data ptr | ||
101 | * @bytes: number of bytes to read | ||
94 | * | 102 | * |
95 | * Returns: | 103 | * Returns: |
96 | * Zero on success, negative error code if failed. | 104 | * Zero on success, negative error code if failed. |
@@ -278,6 +286,10 @@ static int emulate_pci_bar_write(struct intel_vgpu *vgpu, unsigned int offset, | |||
278 | 286 | ||
279 | /** | 287 | /** |
280 | * intel_vgpu_emulate_cfg_read - emulate vGPU configuration space write | 288 | * intel_vgpu_emulate_cfg_read - emulate vGPU configuration space write |
289 | * @vgpu: target vgpu | ||
290 | * @offset: offset | ||
291 | * @p_data: write data ptr | ||
292 | * @bytes: number of bytes to write | ||
281 | * | 293 | * |
282 | * Returns: | 294 | * Returns: |
283 | * Zero on success, negative error code if failed. | 295 | * Zero on success, negative error code if failed. |
diff --git a/drivers/gpu/drm/i915/gvt/display.c b/drivers/gpu/drm/i915/gvt/display.c index 6ee50cb328f8..379fc81da863 100644 --- a/drivers/gpu/drm/i915/gvt/display.c +++ b/drivers/gpu/drm/i915/gvt/display.c | |||
@@ -462,6 +462,7 @@ void intel_vgpu_clean_display(struct intel_vgpu *vgpu) | |||
462 | /** | 462 | /** |
463 | * intel_vgpu_init_display- initialize vGPU virtual display emulation | 463 | * intel_vgpu_init_display- initialize vGPU virtual display emulation |
464 | * @vgpu: a vGPU | 464 | * @vgpu: a vGPU |
465 | * @resolution: resolution index for intel_vgpu_edid | ||
465 | * | 466 | * |
466 | * This function is used to initialize vGPU virtual display emulation stuffs | 467 | * This function is used to initialize vGPU virtual display emulation stuffs |
467 | * | 468 | * |
diff --git a/drivers/gpu/drm/i915/gvt/edid.c b/drivers/gpu/drm/i915/gvt/edid.c index 4b98539025c5..5d4bb35bb889 100644 --- a/drivers/gpu/drm/i915/gvt/edid.c +++ b/drivers/gpu/drm/i915/gvt/edid.c | |||
@@ -340,6 +340,9 @@ static int gmbus2_mmio_write(struct intel_vgpu *vgpu, unsigned int offset, | |||
340 | /** | 340 | /** |
341 | * intel_gvt_i2c_handle_gmbus_read - emulate gmbus register mmio read | 341 | * intel_gvt_i2c_handle_gmbus_read - emulate gmbus register mmio read |
342 | * @vgpu: a vGPU | 342 | * @vgpu: a vGPU |
343 | * @offset: reg offset | ||
344 | * @p_data: data return buffer | ||
345 | * @bytes: access data length | ||
343 | * | 346 | * |
344 | * This function is used to emulate gmbus register mmio read | 347 | * This function is used to emulate gmbus register mmio read |
345 | * | 348 | * |
@@ -365,6 +368,9 @@ int intel_gvt_i2c_handle_gmbus_read(struct intel_vgpu *vgpu, | |||
365 | /** | 368 | /** |
366 | * intel_gvt_i2c_handle_gmbus_write - emulate gmbus register mmio write | 369 | * intel_gvt_i2c_handle_gmbus_write - emulate gmbus register mmio write |
367 | * @vgpu: a vGPU | 370 | * @vgpu: a vGPU |
371 | * @offset: reg offset | ||
372 | * @p_data: data return buffer | ||
373 | * @bytes: access data length | ||
368 | * | 374 | * |
369 | * This function is used to emulate gmbus register mmio write | 375 | * This function is used to emulate gmbus register mmio write |
370 | * | 376 | * |
@@ -437,6 +443,9 @@ static inline int get_aux_ch_reg(unsigned int offset) | |||
437 | /** | 443 | /** |
438 | * intel_gvt_i2c_handle_aux_ch_write - emulate AUX channel register write | 444 | * intel_gvt_i2c_handle_aux_ch_write - emulate AUX channel register write |
439 | * @vgpu: a vGPU | 445 | * @vgpu: a vGPU |
446 | * @port_idx: port index | ||
447 | * @offset: reg offset | ||
448 | * @p_data: write ptr | ||
440 | * | 449 | * |
441 | * This function is used to emulate AUX channel register write | 450 | * This function is used to emulate AUX channel register write |
442 | * | 451 | * |
diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c index 156ceeeb7446..f1a4cb1b8438 100644 --- a/drivers/gpu/drm/i915/gvt/gtt.c +++ b/drivers/gpu/drm/i915/gvt/gtt.c | |||
@@ -1113,6 +1113,10 @@ static inline void ppgtt_generate_shadow_entry(struct intel_gvt_gtt_entry *se, | |||
1113 | } | 1113 | } |
1114 | 1114 | ||
1115 | /** | 1115 | /** |
1116 | * Check if can do 2M page | ||
1117 | * @vgpu: target vgpu | ||
1118 | * @entry: target pfn's gtt entry | ||
1119 | * | ||
1116 | * Return 1 if 2MB huge gtt shadowing is possilbe, 0 if miscondition, | 1120 | * Return 1 if 2MB huge gtt shadowing is possilbe, 0 if miscondition, |
1117 | * negtive if found err. | 1121 | * negtive if found err. |
1118 | */ | 1122 | */ |
@@ -1942,7 +1946,7 @@ void intel_vgpu_unpin_mm(struct intel_vgpu_mm *mm) | |||
1942 | 1946 | ||
1943 | /** | 1947 | /** |
1944 | * intel_vgpu_pin_mm - increase the pin count of a vGPU mm object | 1948 | * intel_vgpu_pin_mm - increase the pin count of a vGPU mm object |
1945 | * @vgpu: a vGPU | 1949 | * @mm: target vgpu mm |
1946 | * | 1950 | * |
1947 | * This function is called when user wants to use a vGPU mm object. If this | 1951 | * This function is called when user wants to use a vGPU mm object. If this |
1948 | * mm object hasn't been shadowed yet, the shadow will be populated at this | 1952 | * mm object hasn't been shadowed yet, the shadow will be populated at this |
@@ -2462,8 +2466,7 @@ fail: | |||
2462 | /** | 2466 | /** |
2463 | * intel_vgpu_find_ppgtt_mm - find a PPGTT mm object | 2467 | * intel_vgpu_find_ppgtt_mm - find a PPGTT mm object |
2464 | * @vgpu: a vGPU | 2468 | * @vgpu: a vGPU |
2465 | * @page_table_level: PPGTT page table level | 2469 | * @pdps: pdp root array |
2466 | * @root_entry: PPGTT page table root pointers | ||
2467 | * | 2470 | * |
2468 | * This function is used to find a PPGTT mm object from mm object pool | 2471 | * This function is used to find a PPGTT mm object from mm object pool |
2469 | * | 2472 | * |
diff --git a/drivers/gpu/drm/i915/gvt/gvt.c b/drivers/gpu/drm/i915/gvt/gvt.c index 712f9d14e720..e14416d97e73 100644 --- a/drivers/gpu/drm/i915/gvt/gvt.c +++ b/drivers/gpu/drm/i915/gvt/gvt.c | |||
@@ -188,7 +188,6 @@ static const struct intel_gvt_ops intel_gvt_ops = { | |||
188 | 188 | ||
189 | /** | 189 | /** |
190 | * intel_gvt_init_host - Load MPT modules and detect if we're running in host | 190 | * intel_gvt_init_host - Load MPT modules and detect if we're running in host |
191 | * @gvt: intel gvt device | ||
192 | * | 191 | * |
193 | * This function is called at the driver loading stage. If failed to find a | 192 | * This function is called at the driver loading stage. If failed to find a |
194 | * loadable MPT module or detect currently we're running in a VM, then GVT-g | 193 | * loadable MPT module or detect currently we're running in a VM, then GVT-g |
@@ -302,7 +301,7 @@ static int init_service_thread(struct intel_gvt *gvt) | |||
302 | 301 | ||
303 | /** | 302 | /** |
304 | * intel_gvt_clean_device - clean a GVT device | 303 | * intel_gvt_clean_device - clean a GVT device |
305 | * @gvt: intel gvt device | 304 | * @dev_priv: i915 private |
306 | * | 305 | * |
307 | * This function is called at the driver unloading stage, to free the | 306 | * This function is called at the driver unloading stage, to free the |
308 | * resources owned by a GVT device. | 307 | * resources owned by a GVT device. |
diff --git a/drivers/gpu/drm/i915/gvt/handlers.c b/drivers/gpu/drm/i915/gvt/handlers.c index e2e252c67de8..131b37b038f0 100644 --- a/drivers/gpu/drm/i915/gvt/handlers.c +++ b/drivers/gpu/drm/i915/gvt/handlers.c | |||
@@ -3405,6 +3405,7 @@ bool intel_gvt_in_force_nonpriv_whitelist(struct intel_gvt *gvt, | |||
3405 | * @offset: register offset | 3405 | * @offset: register offset |
3406 | * @pdata: data buffer | 3406 | * @pdata: data buffer |
3407 | * @bytes: data length | 3407 | * @bytes: data length |
3408 | * @is_read: read or write | ||
3408 | * | 3409 | * |
3409 | * Returns: | 3410 | * Returns: |
3410 | * Zero on success, negative error code if failed. | 3411 | * Zero on success, negative error code if failed. |
diff --git a/drivers/gpu/drm/i915/gvt/mmio.c b/drivers/gpu/drm/i915/gvt/mmio.c index 2be1be2cf49a..dcd31e3781df 100644 --- a/drivers/gpu/drm/i915/gvt/mmio.c +++ b/drivers/gpu/drm/i915/gvt/mmio.c | |||
@@ -39,6 +39,7 @@ | |||
39 | /** | 39 | /** |
40 | * intel_vgpu_gpa_to_mmio_offset - translate a GPA to MMIO offset | 40 | * intel_vgpu_gpa_to_mmio_offset - translate a GPA to MMIO offset |
41 | * @vgpu: a vGPU | 41 | * @vgpu: a vGPU |
42 | * @gpa: guest physical address | ||
42 | * | 43 | * |
43 | * Returns: | 44 | * Returns: |
44 | * Zero on success, negative error code if failed | 45 | * Zero on success, negative error code if failed |
@@ -228,7 +229,7 @@ out: | |||
228 | /** | 229 | /** |
229 | * intel_vgpu_reset_mmio - reset virtual MMIO space | 230 | * intel_vgpu_reset_mmio - reset virtual MMIO space |
230 | * @vgpu: a vGPU | 231 | * @vgpu: a vGPU |
231 | * | 232 | * @dmlr: whether this is device model level reset |
232 | */ | 233 | */ |
233 | void intel_vgpu_reset_mmio(struct intel_vgpu *vgpu, bool dmlr) | 234 | void intel_vgpu_reset_mmio(struct intel_vgpu *vgpu, bool dmlr) |
234 | { | 235 | { |
diff --git a/drivers/gpu/drm/i915/gvt/opregion.c b/drivers/gpu/drm/i915/gvt/opregion.c index fa75a2eead90..82586c8e434f 100644 --- a/drivers/gpu/drm/i915/gvt/opregion.c +++ b/drivers/gpu/drm/i915/gvt/opregion.c | |||
@@ -216,7 +216,6 @@ static void virt_vbt_generation(struct vbt *v) | |||
216 | /** | 216 | /** |
217 | * intel_vgpu_init_opregion - initialize the stuff used to emulate opregion | 217 | * intel_vgpu_init_opregion - initialize the stuff used to emulate opregion |
218 | * @vgpu: a vGPU | 218 | * @vgpu: a vGPU |
219 | * @gpa: guest physical address of opregion | ||
220 | * | 219 | * |
221 | * Returns: | 220 | * Returns: |
222 | * Zero on success, negative error code if failed. | 221 | * Zero on success, negative error code if failed. |
diff --git a/drivers/gpu/drm/i915/gvt/page_track.c b/drivers/gpu/drm/i915/gvt/page_track.c index 256d0db8bbb1..84856022528e 100644 --- a/drivers/gpu/drm/i915/gvt/page_track.c +++ b/drivers/gpu/drm/i915/gvt/page_track.c | |||
@@ -41,6 +41,8 @@ struct intel_vgpu_page_track *intel_vgpu_find_page_track( | |||
41 | * intel_vgpu_register_page_track - register a guest page to be tacked | 41 | * intel_vgpu_register_page_track - register a guest page to be tacked |
42 | * @vgpu: a vGPU | 42 | * @vgpu: a vGPU |
43 | * @gfn: the gfn of guest page | 43 | * @gfn: the gfn of guest page |
44 | * @handler: page track handler | ||
45 | * @priv: tracker private | ||
44 | * | 46 | * |
45 | * Returns: | 47 | * Returns: |
46 | * zero on success, negative error code if failed. | 48 | * zero on success, negative error code if failed. |
diff --git a/drivers/gpu/drm/i915/gvt/scheduler.c b/drivers/gpu/drm/i915/gvt/scheduler.c index 049c0ea324fa..cd6f63b5a40a 100644 --- a/drivers/gpu/drm/i915/gvt/scheduler.c +++ b/drivers/gpu/drm/i915/gvt/scheduler.c | |||
@@ -1135,6 +1135,7 @@ out_shadow_ctx: | |||
1135 | /** | 1135 | /** |
1136 | * intel_vgpu_select_submission_ops - select virtual submission interface | 1136 | * intel_vgpu_select_submission_ops - select virtual submission interface |
1137 | * @vgpu: a vGPU | 1137 | * @vgpu: a vGPU |
1138 | * @engine_mask: either ALL_ENGINES or target engine mask | ||
1138 | * @interface: expected vGPU virtual submission interface | 1139 | * @interface: expected vGPU virtual submission interface |
1139 | * | 1140 | * |
1140 | * This function is called when guest configures submission interface. | 1141 | * This function is called when guest configures submission interface. |
@@ -1187,7 +1188,7 @@ int intel_vgpu_select_submission_ops(struct intel_vgpu *vgpu, | |||
1187 | 1188 | ||
1188 | /** | 1189 | /** |
1189 | * intel_vgpu_destroy_workload - destroy a vGPU workload | 1190 | * intel_vgpu_destroy_workload - destroy a vGPU workload |
1190 | * @vgpu: a vGPU | 1191 | * @workload: workload to destroy |
1191 | * | 1192 | * |
1192 | * This function is called when destroy a vGPU workload. | 1193 | * This function is called when destroy a vGPU workload. |
1193 | * | 1194 | * |
@@ -1279,6 +1280,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload) | |||
1279 | /** | 1280 | /** |
1280 | * intel_vgpu_create_workload - create a vGPU workload | 1281 | * intel_vgpu_create_workload - create a vGPU workload |
1281 | * @vgpu: a vGPU | 1282 | * @vgpu: a vGPU |
1283 | * @ring_id: ring index | ||
1282 | * @desc: a guest context descriptor | 1284 | * @desc: a guest context descriptor |
1283 | * | 1285 | * |
1284 | * This function is called when creating a vGPU workload. | 1286 | * This function is called when creating a vGPU workload. |