diff options
author | Namhyung Kim <namhyung@kernel.org> | 2014-11-24 03:13:27 -0500 |
---|---|---|
committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2014-11-24 09:34:33 -0500 |
commit | a7444af69b2898bb9b3a847d3599e1fc98356ce5 (patch) | |
tree | 1444afa100133e0acd6d82032bf7fca834f51293 | |
parent | 4087d11cd9455cd28da0795504451d1188633a0d (diff) |
perf tools: Collapse first level callchain entry if it has sibling
If first level callchain has more than single path like when -g caller
option is given, it should show only first one in the path and hide
others. But it didn't do it properly and just hindered the output.
Before:
- 80.33% 11.11% abc2 abc2 [.] main
+ 86.18% main
13.82% __libc_start_main
main
After:
- 80.33% 11.11% abc2 abc2 [.] main
+ 86.18% main
+ 13.82% __libc_start_main
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung.kim@lge.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1416816807-6495-2-git-send-email-namhyung@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
-rw-r--r-- | tools/perf/ui/browsers/hists.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c index 8d22905a4687..502daff76ceb 100644 --- a/tools/perf/ui/browsers/hists.c +++ b/tools/perf/ui/browsers/hists.c | |||
@@ -227,10 +227,14 @@ static void callchain_node__init_have_children_rb_tree(struct callchain_node *no | |||
227 | } | 227 | } |
228 | } | 228 | } |
229 | 229 | ||
230 | static void callchain_node__init_have_children(struct callchain_node *node) | 230 | static void callchain_node__init_have_children(struct callchain_node *node, |
231 | bool has_sibling) | ||
231 | { | 232 | { |
232 | struct callchain_list *chain; | 233 | struct callchain_list *chain; |
233 | 234 | ||
235 | chain = list_entry(node->val.next, struct callchain_list, list); | ||
236 | chain->ms.has_children = has_sibling; | ||
237 | |||
234 | if (!list_empty(&node->val)) { | 238 | if (!list_empty(&node->val)) { |
235 | chain = list_entry(node->val.prev, struct callchain_list, list); | 239 | chain = list_entry(node->val.prev, struct callchain_list, list); |
236 | chain->ms.has_children = !RB_EMPTY_ROOT(&node->rb_root); | 240 | chain->ms.has_children = !RB_EMPTY_ROOT(&node->rb_root); |
@@ -241,11 +245,12 @@ static void callchain_node__init_have_children(struct callchain_node *node) | |||
241 | 245 | ||
242 | static void callchain__init_have_children(struct rb_root *root) | 246 | static void callchain__init_have_children(struct rb_root *root) |
243 | { | 247 | { |
244 | struct rb_node *nd; | 248 | struct rb_node *nd = rb_first(root); |
249 | bool has_sibling = nd && rb_next(nd); | ||
245 | 250 | ||
246 | for (nd = rb_first(root); nd; nd = rb_next(nd)) { | 251 | for (nd = rb_first(root); nd; nd = rb_next(nd)) { |
247 | struct callchain_node *node = rb_entry(nd, struct callchain_node, rb_node); | 252 | struct callchain_node *node = rb_entry(nd, struct callchain_node, rb_node); |
248 | callchain_node__init_have_children(node); | 253 | callchain_node__init_have_children(node, has_sibling); |
249 | } | 254 | } |
250 | } | 255 | } |
251 | 256 | ||