diff options
author | Arnd Bergmann <arnd@arndb.de> | 2016-02-22 16:33:31 -0500 |
---|---|---|
committer | Stefan Agner <stefan@agner.ch> | 2016-04-25 23:27:18 -0400 |
commit | a5dab991398996aaef658641a707ae09e002db6b (patch) | |
tree | ef5dc088ce1b999d60b38e1d77194389936f6abe | |
parent | fb127b7943c9262f5d95f402922d92b9d6c1dad2 (diff) |
drm/layerscape: reduce excessive stack usage
The fsl-dcu driver copies a drm_mode_config object to its
stack but then only accesses a single member (dpms_property)
once. The data structure is large enough to trigger a warning
about the amount of kernel stack being used:
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c: In function 'fsl_dcu_drm_connector_create':
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c:182:1: error: the frame size of 1040 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
This changes the fsl_dcu_drm_connector_create() function to
only access the drm_mode_config by reference, which is also
more efficient.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 109eee2f2a18 ("drm/layerscape: Add Freescale DCU DRM driver")
Signed-off-by: Stefan Agner <stefan@agner.ch>
-rw-r--r-- | drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c index f586f1e681d7..99cb7ba44d2b 100644 --- a/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c +++ b/drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_rgb.c | |||
@@ -142,7 +142,7 @@ int fsl_dcu_drm_connector_create(struct fsl_dcu_drm_device *fsl_dev, | |||
142 | struct drm_encoder *encoder) | 142 | struct drm_encoder *encoder) |
143 | { | 143 | { |
144 | struct drm_connector *connector = &fsl_dev->connector.base; | 144 | struct drm_connector *connector = &fsl_dev->connector.base; |
145 | struct drm_mode_config mode_config = fsl_dev->drm->mode_config; | 145 | struct drm_mode_config *mode_config = &fsl_dev->drm->mode_config; |
146 | struct device_node *panel_node; | 146 | struct device_node *panel_node; |
147 | int ret; | 147 | int ret; |
148 | 148 | ||
@@ -164,7 +164,7 @@ int fsl_dcu_drm_connector_create(struct fsl_dcu_drm_device *fsl_dev, | |||
164 | goto err_sysfs; | 164 | goto err_sysfs; |
165 | 165 | ||
166 | drm_object_property_set_value(&connector->base, | 166 | drm_object_property_set_value(&connector->base, |
167 | mode_config.dpms_property, | 167 | mode_config->dpms_property, |
168 | DRM_MODE_DPMS_OFF); | 168 | DRM_MODE_DPMS_OFF); |
169 | 169 | ||
170 | panel_node = of_parse_phandle(fsl_dev->np, "fsl,panel", 0); | 170 | panel_node = of_parse_phandle(fsl_dev->np, "fsl,panel", 0); |