aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHannes Reinecke <hare@suse.de>2015-01-08 01:43:49 -0500
committerChristoph Hellwig <hch@lst.de>2015-01-09 09:44:32 -0500
commita4a6afb477a9e724a6ff7204e4199f0c2cd97d6a (patch)
treee39e98a108671423f094f61c7071f04753aaf61d
parent2dd951ecd511756f405ae9324db87bb0159f6225 (diff)
scsi: Do not display buffer pointers in scsi_log_send()
scsi_log_send() would display buffer pointer for higher logging levels. This is not only of questionable value but also exposes kernel pointer to userspace, which is discouraged in some setups. So drop this message altogether. Tested-by: Robert Elliott <elliott@hp.com> Reviewed-by: Robert Elliott <elliott@hp.com> Signed-off-by: Hannes Reinecke <hare@suse.de> Signed-off-by: Christoph Hellwig <hch@lst.de>
-rw-r--r--drivers/scsi/scsi.c9
1 files changed, 1 insertions, 8 deletions
diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
index 7f028cb1d099..08c90a711556 100644
--- a/drivers/scsi/scsi.c
+++ b/drivers/scsi/scsi.c
@@ -531,7 +531,7 @@ void scsi_log_send(struct scsi_cmnd *cmd)
531 * 531 *
532 * 3: same as 2 532 * 3: same as 2
533 * 533 *
534 * 4: same as 3 plus dump extra junk 534 * 4: same as 3
535 */ 535 */
536 if (unlikely(scsi_logging_level)) { 536 if (unlikely(scsi_logging_level)) {
537 level = SCSI_LOG_LEVEL(SCSI_LOG_MLQUEUE_SHIFT, 537 level = SCSI_LOG_LEVEL(SCSI_LOG_MLQUEUE_SHIFT,
@@ -540,13 +540,6 @@ void scsi_log_send(struct scsi_cmnd *cmd)
540 scmd_printk(KERN_INFO, cmd, 540 scmd_printk(KERN_INFO, cmd,
541 "Send: scmd 0x%p\n", cmd); 541 "Send: scmd 0x%p\n", cmd);
542 scsi_print_command(cmd); 542 scsi_print_command(cmd);
543 if (level > 3) {
544 printk(KERN_INFO "buffer = 0x%p, bufflen = %d,"
545 " queuecommand 0x%p\n",
546 scsi_sglist(cmd), scsi_bufflen(cmd),
547 cmd->device->host->hostt->queuecommand);
548
549 }
550 } 543 }
551 } 544 }
552} 545}