diff options
author | Jan Kara <jack@suse.cz> | 2017-04-11 10:51:34 -0400 |
---|---|---|
committer | Jan Kara <jack@suse.cz> | 2017-04-19 08:21:23 -0400 |
commit | a480b5bebdeac6831f44f598616197fb1d37f987 (patch) | |
tree | caf3bf519238df2ca0ea158cca972dba03456dab | |
parent | a73415a8a5c260b1543fafe01c6dfb254c454ec0 (diff) |
reiserfs: Remove i_attrs_to_sd_attrs()
Now that all places setting inode->i_flags that should be reflected in
on-disk flags are gone, we can remove i_attrs_to_sd_attrs() call.
Signed-off-by: Jan Kara <jack@suse.cz>
-rw-r--r-- | fs/reiserfs/inode.c | 27 | ||||
-rw-r--r-- | fs/reiserfs/ioctl.c | 1 | ||||
-rw-r--r-- | fs/reiserfs/reiserfs.h | 1 |
3 files changed, 1 insertions, 28 deletions
diff --git a/fs/reiserfs/inode.c b/fs/reiserfs/inode.c index aeca1a0b7b5a..873fc04e9403 100644 --- a/fs/reiserfs/inode.c +++ b/fs/reiserfs/inode.c | |||
@@ -1375,7 +1375,6 @@ static void init_inode(struct inode *inode, struct treepath *path) | |||
1375 | static void inode2sd(void *sd, struct inode *inode, loff_t size) | 1375 | static void inode2sd(void *sd, struct inode *inode, loff_t size) |
1376 | { | 1376 | { |
1377 | struct stat_data *sd_v2 = (struct stat_data *)sd; | 1377 | struct stat_data *sd_v2 = (struct stat_data *)sd; |
1378 | __u16 flags; | ||
1379 | 1378 | ||
1380 | set_sd_v2_mode(sd_v2, inode->i_mode); | 1379 | set_sd_v2_mode(sd_v2, inode->i_mode); |
1381 | set_sd_v2_nlink(sd_v2, inode->i_nlink); | 1380 | set_sd_v2_nlink(sd_v2, inode->i_nlink); |
@@ -1390,9 +1389,7 @@ static void inode2sd(void *sd, struct inode *inode, loff_t size) | |||
1390 | set_sd_v2_rdev(sd_v2, new_encode_dev(inode->i_rdev)); | 1389 | set_sd_v2_rdev(sd_v2, new_encode_dev(inode->i_rdev)); |
1391 | else | 1390 | else |
1392 | set_sd_v2_generation(sd_v2, inode->i_generation); | 1391 | set_sd_v2_generation(sd_v2, inode->i_generation); |
1393 | flags = REISERFS_I(inode)->i_attrs; | 1392 | set_sd_v2_attrs(sd_v2, REISERFS_I(inode)->i_attrs); |
1394 | i_attrs_to_sd_attrs(inode, &flags); | ||
1395 | set_sd_v2_attrs(sd_v2, flags); | ||
1396 | } | 1393 | } |
1397 | 1394 | ||
1398 | /* used to copy inode's fields to old stat data */ | 1395 | /* used to copy inode's fields to old stat data */ |
@@ -3091,28 +3088,6 @@ void sd_attrs_to_i_attrs(__u16 sd_attrs, struct inode *inode) | |||
3091 | } | 3088 | } |
3092 | } | 3089 | } |
3093 | 3090 | ||
3094 | void i_attrs_to_sd_attrs(struct inode *inode, __u16 * sd_attrs) | ||
3095 | { | ||
3096 | if (reiserfs_attrs(inode->i_sb)) { | ||
3097 | if (inode->i_flags & S_IMMUTABLE) | ||
3098 | *sd_attrs |= REISERFS_IMMUTABLE_FL; | ||
3099 | else | ||
3100 | *sd_attrs &= ~REISERFS_IMMUTABLE_FL; | ||
3101 | if (inode->i_flags & S_SYNC) | ||
3102 | *sd_attrs |= REISERFS_SYNC_FL; | ||
3103 | else | ||
3104 | *sd_attrs &= ~REISERFS_SYNC_FL; | ||
3105 | if (inode->i_flags & S_NOATIME) | ||
3106 | *sd_attrs |= REISERFS_NOATIME_FL; | ||
3107 | else | ||
3108 | *sd_attrs &= ~REISERFS_NOATIME_FL; | ||
3109 | if (REISERFS_I(inode)->i_flags & i_nopack_mask) | ||
3110 | *sd_attrs |= REISERFS_NOTAIL_FL; | ||
3111 | else | ||
3112 | *sd_attrs &= ~REISERFS_NOTAIL_FL; | ||
3113 | } | ||
3114 | } | ||
3115 | |||
3116 | /* | 3091 | /* |
3117 | * decide if this buffer needs to stay around for data logging or ordered | 3092 | * decide if this buffer needs to stay around for data logging or ordered |
3118 | * write purposes | 3093 | * write purposes |
diff --git a/fs/reiserfs/ioctl.c b/fs/reiserfs/ioctl.c index 1f4692a505a0..acbbaf7a0bb2 100644 --- a/fs/reiserfs/ioctl.c +++ b/fs/reiserfs/ioctl.c | |||
@@ -47,7 +47,6 @@ long reiserfs_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) | |||
47 | } | 47 | } |
48 | 48 | ||
49 | flags = REISERFS_I(inode)->i_attrs; | 49 | flags = REISERFS_I(inode)->i_attrs; |
50 | i_attrs_to_sd_attrs(inode, (__u16 *) & flags); | ||
51 | err = put_user(flags, (int __user *)arg); | 50 | err = put_user(flags, (int __user *)arg); |
52 | break; | 51 | break; |
53 | case REISERFS_IOC_SETFLAGS:{ | 52 | case REISERFS_IOC_SETFLAGS:{ |
diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h index 6ca00471afbf..1d34377fef97 100644 --- a/fs/reiserfs/reiserfs.h +++ b/fs/reiserfs/reiserfs.h | |||
@@ -3099,7 +3099,6 @@ static inline void reiserfs_update_sd(struct reiserfs_transaction_handle *th, | |||
3099 | } | 3099 | } |
3100 | 3100 | ||
3101 | void sd_attrs_to_i_attrs(__u16 sd_attrs, struct inode *inode); | 3101 | void sd_attrs_to_i_attrs(__u16 sd_attrs, struct inode *inode); |
3102 | void i_attrs_to_sd_attrs(struct inode *inode, __u16 * sd_attrs); | ||
3103 | int reiserfs_setattr(struct dentry *dentry, struct iattr *attr); | 3102 | int reiserfs_setattr(struct dentry *dentry, struct iattr *attr); |
3104 | 3103 | ||
3105 | int __reiserfs_write_begin(struct page *page, unsigned from, unsigned len); | 3104 | int __reiserfs_write_begin(struct page *page, unsigned from, unsigned len); |