diff options
author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-08-22 05:24:13 -0400 |
---|---|---|
committer | Takashi Iwai <tiwai@suse.de> | 2015-08-22 05:36:26 -0400 |
commit | a3b3a9db5d26bef1e62054c95c3d7701de5110d5 (patch) | |
tree | f43a9115bf6e65644c66aacd07aeb1f905188c26 | |
parent | f09d4f26f6192ec9b060047cc7126e01980bb36c (diff) |
ALSA: hdsp: silence a sprinft() overflow warning
card->shortname is a 32 char string so the sprintf() can theoretically
overflow. snd_rawmidi_new() can accept strings up to 64 bytes long.
I have made the temporay buf[] array 40 bytes long and changed the
sprintf() to snprintf().
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
-rw-r--r-- | sound/pci/rme9652/hdsp.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 468a95cdce70..9bba275b4c9b 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c | |||
@@ -1526,7 +1526,7 @@ static struct snd_rawmidi_ops snd_hdsp_midi_input = | |||
1526 | 1526 | ||
1527 | static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int id) | 1527 | static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int id) |
1528 | { | 1528 | { |
1529 | char buf[32]; | 1529 | char buf[40]; |
1530 | 1530 | ||
1531 | hdsp->midi[id].id = id; | 1531 | hdsp->midi[id].id = id; |
1532 | hdsp->midi[id].rmidi = NULL; | 1532 | hdsp->midi[id].rmidi = NULL; |
@@ -1537,7 +1537,7 @@ static int snd_hdsp_create_midi (struct snd_card *card, struct hdsp *hdsp, int i | |||
1537 | hdsp->midi[id].pending = 0; | 1537 | hdsp->midi[id].pending = 0; |
1538 | spin_lock_init (&hdsp->midi[id].lock); | 1538 | spin_lock_init (&hdsp->midi[id].lock); |
1539 | 1539 | ||
1540 | sprintf (buf, "%s MIDI %d", card->shortname, id+1); | 1540 | snprintf(buf, sizeof(buf), "%s MIDI %d", card->shortname, id + 1); |
1541 | if (snd_rawmidi_new (card, buf, id, 1, 1, &hdsp->midi[id].rmidi) < 0) | 1541 | if (snd_rawmidi_new (card, buf, id, 1, 1, &hdsp->midi[id].rmidi) < 0) |
1542 | return -1; | 1542 | return -1; |
1543 | 1543 | ||