aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2019-04-15 17:11:41 -0400
committerDavid S. Miller <davem@davemloft.net>2019-04-17 00:03:02 -0400
commita32b9d91b72588d6d90ba2772cd431a94b0122a0 (patch)
treeed0c85fdb24606f4ff985782e2b00548aff58b33
parent432bc230700f86801cffa5e159e05dea6229f722 (diff)
xen-netfront: mark expected switch fall-through
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/net/xen-netfront.c: In function ‘netback_changed’: drivers/net/xen-netfront.c:2038:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (dev->state == XenbusStateClosed) ^ drivers/net/xen-netfront.c:2041:2: note: here case XenbusStateClosing: ^~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 Notice that, in this particular case, the code comment is modified in accordance with what GCC is expecting to find. This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Juergen Gross <jgross@suse.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--drivers/net/xen-netfront.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/xen-netfront.c b/drivers/net/xen-netfront.c
index 80c30321de41..8d33970a2950 100644
--- a/drivers/net/xen-netfront.c
+++ b/drivers/net/xen-netfront.c
@@ -2037,7 +2037,7 @@ static void netback_changed(struct xenbus_device *dev,
2037 case XenbusStateClosed: 2037 case XenbusStateClosed:
2038 if (dev->state == XenbusStateClosed) 2038 if (dev->state == XenbusStateClosed)
2039 break; 2039 break;
2040 /* Missed the backend's CLOSING state -- fallthrough */ 2040 /* Fall through - Missed the backend's CLOSING state. */
2041 case XenbusStateClosing: 2041 case XenbusStateClosing:
2042 xenbus_frontend_closed(dev); 2042 xenbus_frontend_closed(dev);
2043 break; 2043 break;